From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Herbert Euler" Newsgroups: gmane.emacs.devel Subject: Re: Wrong comment in keymap.c Date: Mon, 26 Mar 2007 12:24:59 +0800 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; format=flowed X-Trace: sea.gmane.org 1174883131 16357 80.91.229.12 (26 Mar 2007 04:25:31 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 26 Mar 2007 04:25:31 +0000 (UTC) Cc: emacs-devel@gnu.org To: monnier@iro.umontreal.ca Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 26 06:25:23 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HVglj-00005C-U7 for ged-emacs-devel@m.gmane.org; Mon, 26 Mar 2007 06:25:20 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HVgnv-0007jm-9e for ged-emacs-devel@m.gmane.org; Sun, 25 Mar 2007 23:27:35 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HVgnr-0007ha-Ck for emacs-devel@gnu.org; Mon, 26 Mar 2007 00:27:31 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HVgno-0007fX-Uu for emacs-devel@gnu.org; Mon, 26 Mar 2007 00:27:30 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HVgno-0007ep-LY for emacs-devel@gnu.org; Sun, 25 Mar 2007 23:27:28 -0500 Original-Received: from bay0-omc3-s26.bay0.hotmail.com ([65.54.246.226]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HVgla-00038a-No for emacs-devel@gnu.org; Mon, 26 Mar 2007 00:25:11 -0400 Original-Received: from hotmail.com ([65.55.154.117]) by bay0-omc3-s26.bay0.hotmail.com with Microsoft SMTPSVC(6.0.3790.2668); Sun, 25 Mar 2007 21:25:01 -0700 Original-Received: from mail pickup service by hotmail.com with Microsoft SMTPSVC; Sun, 25 Mar 2007 21:25:01 -0700 Original-Received: from 65.55.154.123 by by143fd.bay143.hotmail.msn.com with HTTP; Mon, 26 Mar 2007 04:24:59 GMT X-Originating-IP: [216.145.54.158] X-Originating-Email: [herberteuler@hotmail.com] X-Sender: herberteuler@hotmail.com In-Reply-To: X-OriginalArrivalTime: 26 Mar 2007 04:25:01.0869 (UTC) FILETIME=[B8A3A5D0:01C76F5E] X-detected-kernel: Windows 2000 SP4, XP SP1+ X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:68568 Archived-At: > > Here is another one, for `read_key_sequence' in keyboard.c. > > `first_binding' is always used with `submaps', shouldn't the > > comment for it be `submaps', rather than `defs'? > >No, the comment is correct. The "submaps[first_binding]" expressions are >used to check whether that first binding is a prefix or not. I.e. kind of >like "KEYMAPP (defs[first_binding])". > >It's mostly set in follow_key: > > if (! NILP (defs[i])) > first_binding = i; Excuse me, but there are two ``first_binding''s in this file; I refered the one in ``read_key_sequence''. Please take a look at near line 8996: /* Find an accurate initial value for first_binding. */ for (first_binding = 0; first_binding < nmaps; first_binding++) if (! NILP (submaps[first_binding])) break; Regards, Guanpeng Xu _________________________________________________________________ Express yourself instantly with MSN Messenger! Download today it's FREE! http://messenger.msn.click-url.com/go/onm00200471ave/direct/01/