From: "Toru TSUNEYOSHI" <t_tuneyosi@hotmail.com>
To: "Karl Fogel" <kfogel@red-bean.com>
Cc: emacs-devel@gnu.org
Subject: Re: proposition about bookmark-buffer-file-name in bookmark.el
Date: Thu, 20 Nov 2008 11:15:10 +0900 [thread overview]
Message-ID: <BAY121-DAV10E4F3805788EDE04AA347E20C0@phx.gbl> (raw)
In-Reply-To: 87skpnbmqp.fsf@red-bean.com
----- Original Message -----
From: "Karl Fogel" <kfogel@red-bean.com>
To: "Toru TSUNEYOSHI" <t_tuneyosi@hotmail.com>
Cc: <emacs-devel@gnu.org>
Sent: Thursday, November 20, 2008 3:21 AM
Subject: Re: proposition about bookmark-buffer-file-name in bookmark.el
> "Toru TSUNEYOSHI" <t_tuneyosi@hotmail.com> writes:
> >> This sounds reasonable to me, but could you give examples of what the
> >> new names would look like for those kinds of bookmarks?
> >
> > Sorry, I can't understand you clearly.
>
> What I meant was, could you describe the effect your change will have?
> I mean the effect that will be visible to users.
>
Thanks. I have understood clearly.
The effect is as same as description about `bookmark-buffer-file-name'
in bookmark.el on Emacs 22.3.1. In short, "shorter and portable".
comment about `bookmark-buffer-file-name' in bookmark.el on Emacs 22.3.1:
========================================================================
(buffer-file-name
;; Abbreviate the path, both so it's shorter and so it's more
;; portable. E.g., the user's home dir might be a different
;; path on different machines, but "~/" will still reach it.
(abbreviate-file-name buffer-file-name))
========================================================================
> > examples of `bookmark-buffer-file-name' processing:
> >
> > case:
> > home directory: "d:/home/user/"
> > dired-directory: "d:/home/user/xyz/"
> >
> > (bookmark-buffer-file-name)
> > now
> > => "d:/home/user/xyz/"
> > wish
> > => "~/xyz/"
>
> This looks good to me!
>
> >> (By the way, expressing the proposed change in 'patch' format is
> >> probably the most precise way to communicate it.)
> >>
> >> Thanks,
> >> -Karl
> >
> > Yes.
> > I use `defadvice' in practice.
> > But I made a patch for bookmark.el temporarily.
>
> Can you post that patch?
>
I have already attached it in my previous email. Please check it.
> Thanks,
> -Karl
>
next prev parent reply other threads:[~2008-11-20 2:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-19 4:27 proposition about bookmark-buffer-file-name in bookmark.el Toru TSUNEYOSHI
2008-11-19 7:37 ` Karl Fogel
2008-11-19 12:32 ` Toru TSUNEYOSHI
2008-11-19 18:21 ` Karl Fogel
2008-11-20 2:15 ` Toru TSUNEYOSHI [this message]
2008-11-20 14:28 ` Stefan Monnier
2008-11-21 18:32 ` Karl Fogel
2008-11-22 3:15 ` Toru TSUNEYOSHI
2008-11-21 19:07 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BAY121-DAV10E4F3805788EDE04AA347E20C0@phx.gbl \
--to=t_tuneyosi@hotmail.com \
--cc=emacs-devel@gnu.org \
--cc=kfogel@red-bean.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).