From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Herbert Euler" Newsgroups: gmane.emacs.devel Subject: Comint Completion Broken Date: Tue, 16 May 2006 18:48:36 +0800 Message-ID: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; format=flowed X-Trace: sea.gmane.org 1147776681 1117 80.91.229.2 (16 May 2006 10:51:21 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 16 May 2006 10:51:21 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 16 12:51:18 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Ffx8p-0003yF-OM for ged-emacs-devel@m.gmane.org; Tue, 16 May 2006 12:51:05 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ffx8m-0007Hv-89 for ged-emacs-devel@m.gmane.org; Tue, 16 May 2006 06:51:00 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ffx8a-0007HV-Lt for emacs-devel@gnu.org; Tue, 16 May 2006 06:50:48 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ffx8R-0007Cz-0N for emacs-devel@gnu.org; Tue, 16 May 2006 06:50:48 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ffx8Q-0007Cw-QI for emacs-devel@gnu.org; Tue, 16 May 2006 06:50:38 -0400 Original-Received: from [64.4.26.26] (helo=hotmail.com) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FfxAr-0005kO-Ao for emacs-devel@gnu.org; Tue, 16 May 2006 06:53:14 -0400 Original-Received: from mail pickup service by hotmail.com with Microsoft SMTPSVC; Tue, 16 May 2006 03:48:39 -0700 Original-Received: from 64.4.26.200 by by112fd.bay112.hotmail.msn.com with HTTP; Tue, 16 May 2006 10:48:36 GMT X-Originating-IP: [216.145.54.158] X-Originating-Email: [herberteuler@hotmail.com] X-Sender: herberteuler@hotmail.com Original-To: emacs-devel@gnu.org X-OriginalArrivalTime: 16 May 2006 10:48:39.0487 (UTC) FILETIME=[4A7FECF0:01C678D6] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:54568 Archived-At: Hello, Comint in the newest Unicode 2 CVS Emacs is broken. In the past, if comint shows a completion window, this window will be automatically deleted after the user types a complement supplied in it or just types space. Now it won't be deleted even if the user types SPC directly, contradicts to what is said in echo area: "Type space to flush". Comparing the current source code and the latest working source code, I found the following change for `comint-dynamic-list-completions' in lisp/comint.el: 2945,2948c2980,2982 < (unless (eq first ?\s) < (setq unread-command-events (listify-key-sequence key))) < (unless (eq first ?\t) < (set-window-configuration comint-dynamic-list-completions-config)))))) --- > (if (eq first ?\s) > (set-window-configuration >comint-dynamic-list-completions-config) > (setq unread-command-events (listify-key-sequence key))))))) The above one is the correct code, the below one is the wrong code. Note that these two code aren't equal. If the current source is substituted with the above one, comint will act correctly. There's no such entry in changelog shows `comint-dynamic-list-completions' is changed recently. Why do someone alter the behavior of `comint-dynamic-list-completions'? Regards, Guanpeng Xu _________________________________________________________________ Express yourself instantly with MSN Messenger! Download today it's FREE! http://messenger.msn.click-url.com/go/onm00200471ave/direct/01/