From: "Herbert Euler" <herberteuler@hotmail.com>
Subject: Add log bug
Date: Tue, 26 Dec 2006 09:29:12 +0800 [thread overview]
Message-ID: <BAY112-F13272ED8B993521BC09F4ADAC10@phx.gbl> (raw)
There is a bug in add-log.el, in the function
`add-log-current-defun'. There was a fix; but it is not complete.
The old description of the bug can be found at
http://lists.gnu.org/archive/html/emacs-devel/2006-09/msg00857.html
The problem exists yet now. If you put point in the body of the C++
function below:
void
web_slim::slim_dirent::clear ()
{
for (slim_dirent_seq::iterator i = sub.begin (); i != sub.end (); ++i)
i->clear ();
sub.clear ();
}
`add-change-log-entry-other-window' would try to add a log entry for
function `slim_dirent::clear', rather than the desired
`web_slim::slim_dirent::clear'.
The old fix changed `forward-word' into `forward-sexp', but the latter
one only moves one sexp. So the point is put before `slim_dirent' in
the above example. A complete fix could be:
*** add-log.el.~1.146.2.22.~ Mon Nov 13 10:58:16 2006
--- add-log.el Wed Dec 20 10:13:47 2006
*************** (defun add-log-current-defun ()
*** 916,922 ****
;; Include certain keywords if they
;; precede the name.
(setq middle (point))
! (forward-sexp -1)
;; Is this C++ method?
(when (and (< 2 middle)
(string= (buffer-substring (-
middle 2)
--- 916,923 ----
;; Include certain keywords if they
;; precede the name.
(setq middle (point))
! (while (not (looking-back "\\(^\\|
\\|\t\\)"))
! (forward-sexp -1))
;; Is this C++ method?
(when (and (< 2 middle)
(string= (buffer-substring (-
middle 2)
This is not a big problem; but it is still a bug. Since it will take
long between two releases, I think it could be good of fixing it
before this release.
Regards,
Guanpeng Xu
_________________________________________________________________
Express yourself instantly with MSN Messenger! Download today it's FREE!
http://messenger.msn.click-url.com/go/onm00200471ave/direct/01/
next reply other threads:[~2006-12-26 1:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-26 1:29 Herbert Euler [this message]
2006-12-26 2:06 ` Add log bug Masatake YAMATO
2006-12-26 2:37 ` Herbert Euler
2006-12-26 3:56 ` Masatake YAMATO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BAY112-F13272ED8B993521BC09F4ADAC10@phx.gbl \
--to=herberteuler@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).