Quoted while loop on calccomp.el

Quoted while loop on calccomp.el

[Juanma Barranquero]

In this bit from lisp/calc/calccomp.el, at lines 1284-1290:

		   (if (> mrg 12)  ; indenting too far, go back to far left
		       (let ((j i) (new (if calc-line-numbering 5 1)))
			 '(while (<= j math-comp-level)
			   (aset math-comp-buf-margin j
				 (+ (aref math-comp-buf-margin j) (- new mrg)))
			   (setq j (1+ j)))
			 (setq mrg new)))

it is the '(while stuff an ugly, but intended way to comment out the
while loop, or a mistake? Seems like the the latter, but if so, it's
been there since the initial import of Calc 2.02f on revno:40770
(2001-11-06), which makes that code suspiciously unneeded...

    Juanma

Re: Quoted while loop on calccomp.el

[Jay Belanger]

Juanma Barranquero <lekktu@gmail.com> writes:
...
> it is the '(while stuff an ugly, but intended way to comment out the
> while loop, or a mistake? Seems like the the latter, but if so, it's
> been there since the initial import of Calc 2.02f on revno:40770
> (2001-11-06), which makes that code suspiciously unneeded...

It's been there longer than that.  It's in calc-comp.el from Calc 2.02,
which goes back to 1991 or so.  (The quoted "while" may well be older than
that, but that's the earliest version of Calc I can find.)  At this
point, I suppose replacing the "if" with something simpler is in order.

Jay

Re: Quoted while loop on calccomp.el

[Juanma Barranquero]

On Sun, Apr 17, 2011 at 05:01, Jay Belanger <jay.p.belanger@gmail.com> wrote:

> At this
> point, I suppose replacing the "if" with something simpler is in order.

Well, what the "if" has been doing all these years is just

		   (if (> mrg 12)  ; indenting too far, go back to far left
                       (setq mrg (if calc-line-numbering 5 1)))

so let's change it so.

    Juanma