From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ben Key Newsgroups: gmane.emacs.devel Subject: Re: Supporting parameters that include the = character in configure.bat Date: Thu, 14 Apr 2011 19:56:03 -0500 Message-ID: References: <83lizirrli.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=0015174c0bdebdc27d04a0ea82f2 X-Trace: dough.gmane.org 1302828994 31244 80.91.229.12 (15 Apr 2011 00:56:34 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 15 Apr 2011 00:56:34 +0000 (UTC) Cc: Eli Zaretskii , Emacs-devel@gnu.org To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 15 02:56:30 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QAXKo-0004fl-6s for ged-emacs-devel@m.gmane.org; Fri, 15 Apr 2011 02:56:30 +0200 Original-Received: from localhost ([::1]:41520 helo=lists2.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QAXKn-0007r0-Ru for ged-emacs-devel@m.gmane.org; Thu, 14 Apr 2011 20:56:29 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:41293) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QAXKl-0007qv-DL for Emacs-devel@gnu.org; Thu, 14 Apr 2011 20:56:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QAXKk-0000m8-K2 for Emacs-devel@gnu.org; Thu, 14 Apr 2011 20:56:27 -0400 Original-Received: from mail-bw0-f41.google.com ([209.85.214.41]:48983) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QAXKj-0000ls-2Q; Thu, 14 Apr 2011 20:56:25 -0400 Original-Received: by bwz17 with SMTP id 17so2243080bwz.0 for ; Thu, 14 Apr 2011 17:56:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=tel42di8L+39rahzfj7xFv/LwZcvJiq6H7PiY8nxVac=; b=uWK46kOazhETWQkH5ryrgShiqySBCOz+HNf87LmyjEevsd8dYaLY5+twKu8iZRreEr iY5omhcus5okJDbJDK3nnSSmVIPBHT8WuNQfDtCShpGBYThmwtpPVOzXlTH7MdUbr6VW 93hQEv7PE4gwalFC+exHIRTQJ3NcQBNNhRKng= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=boCcqJM32qyXP7u0lAYQ5bCGM2AENLCOOpzthVPy5D6mppffTGD5D43Io9Z6vTpdc5 UW2TZoDelXSHYZFeM65jBT/H15dRbzr0jh7tZEV00dgrRghxUZajVwIoR5lMFuRdn9lA y54HDcrn2Ki7fMYEUL/d8l6Yep0h8SCHDykg4= Original-Received: by 10.204.139.199 with SMTP id f7mr1211451bku.23.1302828983107; Thu, 14 Apr 2011 17:56:23 -0700 (PDT) Original-Received: by 10.204.118.203 with HTTP; Thu, 14 Apr 2011 17:56:03 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.214.41 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:138488 Archived-At: --0015174c0bdebdc27d04a0ea82f2 Content-Type: multipart/alternative; boundary=0015174c0bdebdc26f04a0ea82f0 --0015174c0bdebdc26f04a0ea82f0 Content-Type: text/plain; charset=ISO-8859-1 Hello, I have attached to this message a patch that modifies the code in configure.bat that parses the --cflags and --ldflags options to support parameters that include the = character. Note that this functionality depends on command extensions. Configure.bat now attempts to enable command extensions and displays a warning message if they could not be enabled. If configure.bat could not enable command extensions the old parsing code is used that does not support parameters that include the = character. Note that the technique I used requires that any --cflags or --ldflags parameter that includes the = character be enclosed in quotes to prevent the = character from being interpreted as a separator. The quotes are striped when the parameter is processed. Note the the parameter does not need to be enclosed in quotes if it does not include the = character. This patch includes changes to the nt/INSTALL file provided by Eli Zaretskii. I tested these changes on Windows 2000, Windows XP, and Windows 7. I also tested in the case in which command extensions are disabled via the registry on Windows XP. Note that in the case in which command extensions are disabled the setlocal command successfully enabled them. I do not know of a case in which configure.bat will fall back to the old parsing code (perhaps Windows NT, I do not know because I do not have a PC running Windows NT to use for testing). --0015174c0bdebdc26f04a0ea82f0 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hello,

I have attached to this message a patch that= modifies the code in configure.bat that parses the --cflags and --ldflags = options to support parameters that include the =3D = character.=A0 Note that this functionality depends on command extensions.= =A0 Configure.bat now attempts to enable command ex= tensions and displays a warning message if they could not be enabled.=A0 If= configure.bat could not en= able command extensions the old parsing code is used that does not <= font size=3D"4">support parameters that include the =3D character.

Note that the technique I used requires that any --cflags or --ldflags parameter that includes the =3D character be enclo= sed in quotes to prevent the =3D character from being interpreted as a sepa= rator.=A0 The quotes are striped when the parameter is processed.=A0 Note t= he the parameter does not need to be enclosed in quotes if it does not incl= ude the =3D character.

This patch includes changes to the nt/INSTALL file provided by Eli Zare= tskii.

I tested these changes on Windows 2000, Windows XP, and Windo= ws 7.=A0 I also tested in the case in which command extensions are disabled= via the registry on Windows XP.=A0 Note that in the case in which <= font size=3D"4">command extensions are disabled the setlocal command succes= sfully enabled them.=A0 I do not know of a case in which configure.bat will= fall back to the old parsing code (perhaps Windows NT, I do not know becau= se I do not have a PC running Windows NT to use for testing).

 --0015174c0bdebdc26f04a0ea82f0-- --0015174c0bdebdc27d04a0ea82f2 Content-Type: application/octet-stream; name="emacs-nt-configure.patch" Content-Disposition: attachment; filename="emacs-nt-configure.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gmidhj6t0 PT09IG1vZGlmaWVkIGZpbGUgJ250L0lOU1RBTEwnCi0tLSBudC9JTlNUQUxMCTIwMTEtMDEtMjYg MDg6MzY6MzkgKzAwMDAKKysrIG50L0lOU1RBTEwJMjAxMS0wNC0xNCAxNzozNDowNSArMDAwMApA QCAtMjIwLDEzICsyMjAsMjMgQEAKICAgYWJzb2x1dGVseSBzdXJlIHRoZSBwcm9kdWNlZCBiaW5h cmllcyB3aWxsIG5ldmVyIG5lZWQgdG8gYmUgcnVuIHVuZGVyCiAgIGEgZGVidWdnZXIuCiAKLSAg QmVjYXVzZSBvZiBsaW1pdGF0aW9ucyBvZiB0aGUgc3RvY2sgV2luZG93cyBjb21tYW5kIHNoZWxs LCBjZXJ0YWluCi0gIGNoYXJhY3RlcnMgKHF1b3RlcywgYmFja3NsYXNoZXMgYW5kIGVxdWFsIHNp Z25zKSBjYW4gYmUgcHJvYmxlbWF0aWMKLSAgYW5kIHNob3VsZCBub3QgYmUgdXNlZCBpbiBhcmd1 bWVudHMgdG8gY29uZmlndXJlLiAgVGhhdCBtZWFucyB0aGF0Ci0gIGZvcndhcmQgc2xhc2hlcyBt dXN0IGJlIHVzZWQgaW4gcGF0aHMgcGFzc2VkIHRvIHRoZSBjb21waWxlciBhbmQKLSAgbGlua2Vy IHZpYSB0aGUgLS1jZmxhZ3MgYW5kIC0tbGRmbGFncyBvcHRpb25zLCBhbmQgdGhhdCBpdCBpcwot ICBjdXJyZW50bHkgbm90IHBvc3NpYmxlIHRvIHBhc3MgYSBtYWNybyBsaWtlIC1ERk9PPUJBUiAo dGhvdWdoIC1ERk9PCi0gIGlzIHBlcmZlY3RseSB2YWxpZCkuCisgIEJlY2F1c2Ugb2YgbGltaXRh dGlvbnMgb2YgdGhlIHN0b2NrIFdpbmRvd3MgY29tbWFuZCBzaGVsbHMsIHNwZWNpYWwKKyAgY2Fy ZSBpcyBuZWVkZWQgdG8gcGFzcyBzb21lIGNoYXJhY3RlcnMgaW4gdGhlIGFyZ3VtZW50cyBvZiB0 aGUKKyAgLS1jZmxhZ3MgYW5kIC0tbGRmbGFncyBvcHRpb25zLiAgQmFja3NsYXNoZXMgc2hvdWxk IG5vdCBiZSB1c2VkIGluCisgIGZpbGUgbmFtZXMgcGFzc2VkIHRvIHRoZSBjb21waWxlciBhbmQg bGlua2VyIHZpYSB0aGVzZSBvcHRpb25zLiAgVXNlCisgIGZvcndhcmQgc2xhc2hlcyBpbnN0ZWFk LiAgSWYgdGhlIGFyZ3VtZW50cyB0byB0aGVzZSB0d28gb3B0aW9ucworICBpbmNsdWRlIHRoZSBg PScgY2hhcmFjdGVyLCBsaWtlIHdoZW4gcGFzc2luZyBhIC1ERk9PPWJhciBwcmVwcm9jZXNzb3IK KyAgb3B0aW9uLCB0aGUgYXJndW1lbnQgd2l0aCB0aGUgYD0nIGNoYXJhY3RlciBzaG91bGQgYmUg ZW5jbG9zZWQgaW4KKyAgcXVvdGVzLCBsaWtlIHRoaXM6CisKKyAgICBjb25maWd1cmUgLS1jZmxh Z3MgIi1ERk9PPWJhciIKKworICBTdXBwb3J0IGZvciBvcHRpb25zIHRoYXQgaW5jbHVkZSB0aGUg YD0nIGNoYXJhY3RlciByZXF1aXJlICJjb21tYW5kCisgIGV4dGVuc2lvbnMiIHRvIGJlIGVuYWJs ZWQuICAoVGhleSBhcmUgZW5hYmxlZCBieSBkZWZhdWx0LCBidXQgeW91cgorICBzeXN0ZW0gYWRt aW5pc3RyYXRvciBjb3VsZCBoYXZlIGNoYW5nZWQgdGhhdC4gIFNlZSAiY21kIC8/IiBmb3IKKyAg ZGV0YWlscy4pICBJZiBjb21tYW5kIGV4dGVuc2lvbnMgYXJlIGRpc2FibGVkLCBhIHdhcm5pbmcg bWVzc2FnZSBtaWdodAorICBiZSBkaXNwbGF5ZWQgaW5mb3JtaW5nIHlvdSB0aGF0ICJ1c2luZyBw YXJhbWV0ZXJzIHRoYXQgaW5jbHVkZSB0aGUgPQorICBjaGFyYWN0ZXIgYnkgZW5jbG9zaW5nIHRo ZW0gaW4gcXVvdGVzIHdpbGwgbm90IGJlIHN1cHBvcnRlZC4iCiAKICAgTi5CLiAgSXQgaXMgbm9y bWFsIHRvIHNlZSBhIGZldyBlcnJvciBtZXNzYWdlcyBvdXRwdXQgd2hpbGUgY29uZmlndXJlCiAg IGlzIHJ1bm5pbmcsIHdoZW4gZ2NjIHN1cHBvcnQgaXMgYmVpbmcgdGVzdGVkLiAgVGhlc2UgY2Fu bm90IGJlCgo9PT0gbW9kaWZpZWQgZmlsZSAnbnQvY29uZmlndXJlLmJhdCcKLS0tIG50L2NvbmZp Z3VyZS5iYXQJMjAxMS0wMS0yOSAxMjozNjoxMSArMDAwMAorKysgbnQvY29uZmlndXJlLmJhdAky MDExLTA0LTE0IDE3OjM1OjE1ICswMDAwCkBAIC03NSw2ICs3NSwxOSBAQAogDQogOnN0YXJ0DQog cmVtIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0NCityZW0gICBBdHRlbXB0IHRvIGVuYWJsZSBjb21tYW5kIGV4dGVu c2lvbnMuICBTZXQgdXNlX2V4dGVuc2lvbnMgdG8gMSBpZg0KK3JlbSAgIHRoZXkgYXJlIGF2YWls YWJsZSBhbmQgMCBpZiB0aGV5IGFyZSBub3QgYXZhaWxhYmxlLg0KK3NldCB1c2VfZXh0ZW5zaW9u cz0xDQorc2V0bG9jYWwgRU5BQkxFRVhURU5TSU9OUw0KK2lmICIlQ01ERVhUVkVSU0lPTiUiID09 ICIiIHNldCB1c2VfZXh0ZW5zaW9ucz0wDQoraWYgIiV1c2VfZXh0ZW5zaW9ucyUiID09ICIxIiBn b3RvIGFmdGVyZXh0DQorDQorZWNoby4gQ29tbWFuZCBleHRlbnNpb25zIGFyZSBub3QgYXZhaWxh YmxlLiAgVXNpbmcgcGFyYW1ldGVycyB0aGF0IGluY2x1ZGUgdGhlID0NCitlY2hvLiBjaGFyYWN0 ZXIgYnkgZW5jbG9zaW5nIHRoZW0gaW4gcXVvdGVzIHdpbGwgbm90IGJlIHN1cHBvcnRlZC4NCisN Cis6YWZ0ZXJleHQNCisNCityZW0gLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KIHJlbSAgIERlZmF1bHQgc2V0dGlu Z3MuDQogc2V0IHByZWZpeD0NCiBzZXQgbm9kZWJ1Zz1ODQpAQCAtMTM2LDYgKzE0OSwyMCBAQAog ZWNoby4gICAtLXdpdGhvdXQteHBtICAgICAgICAgICBkbyBub3QgdXNlIFhQTSBsaWJyYXJ5IGV2 ZW4gaWYgaXQgaXMgaW5zdGFsbGVkDQogZWNoby4gICAtLXdpdGgtc3ZnICAgICAgICAgICAgICB1 c2UgdGhlIFJTVkcgbGlicmFyeSAoZXhwZXJpbWVudGFsKQ0KIGVjaG8uICAgLS1kaXN0ZmlsZXMg ICAgICAgICAgICAgcGF0aCB0byBmaWxlcyBmb3IgbWFrZSBkaXN0LCBlLmcuIGxpYlhwbS5kbGwN CitpZiAiJXVzZV9leHRlbnNpb25zJSIgPT0gIjAiIGdvdG8gZW5kDQorZWNoby4NCitlY2hvLiBU aGUgY2ZsYWdzIGFuZCBsZGZsYWdzIGFyZ3VtZW50cyBzdXBwb3J0IHBhcmFtZXRlcnMgdGhhdCBp bmNsdWRlIHRoZSA9DQorZWNoby4gY2hhcmFjdGVyLiAgSG93ZXZlciwgc2luY2UgdGhlID0gY2hh cmFjdGVyIGlzIG5vcm1hbGx5IHRyZWF0ZWQgYXMgYQ0KK2VjaG8uIHNlcGFyYXRvciBjaGFyYWN0 ZXIgeW91IHdpbGwgbmVlZCB0byBlbmNsb3NlIGFueSBwYXJhbWV0ZXIgdGhhdCBpbmNsdWRlcw0K K2VjaG8uIHRoZSA9IGNoYXJhY3RlciBpbiBxdW90ZXMuICBGb3IgZXhhbXBsZSwgdG8gaW5jbHVk ZQ0KK2VjaG8uIC1EU0lURUxPQURfUFVSRVNJWkVfRVhUUkE9MTAwMDAwIGFzIG9uZSBvZiB0aGUg Y2ZsYWdzIHlvdSB3b3VsZCBydW4NCitlY2hvLiBjb25maWd1cmUuYmF0IGFzIGZvbGxvd3M6DQor ZWNoby4gY29uZmlndXJlLmJhdCAtLWNmbGFncyAiLURTSVRFTE9BRF9QVVJFU0laRV9FWFRSQT0x MDAwMDAiDQorZWNoby4NCitlY2hvLiBOb3RlIHRoYXQgdGhpcyBjYXBhYmlsaXR5IG9mIHByb2Nl c3NpbmcgcGFyYW1ldGVycyB0aGF0IGluY2x1ZGUgdGhlID0NCitlY2hvLiBjaGFyYWN0ZXIgZGVw ZW5kcyBvbiBjb21tYW5kIGV4dGVuc2lvbnMuICBUaGlzIGJhdGNoIGZpbGUgYXR0ZW1wdHMgdG8N CitlY2hvLiBlbmFibGUgY29tbWFuZCBleHRlbnNpb25zLiAgSWYgY29tbWFuZCBleHRlbnNpb25z IGNhbm5vdCBiZSBlbmFibGVkLCBhDQorZWNoby4gd2FybmluZyBtZXNzYWdlIHdpbGwgYmUgZGlz cGxheWVkLg0KIGdvdG8gZW5kDQogDQogcmVtIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NCkBAIC0xOTgsNiArMjI1 LDE3IEBACiByZW0gLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KIA0KIDp1c2VyY2ZsYWdzDQoraWYgIiV1c2VfZXh0 ZW5zaW9ucyUiID09ICIxIiBnb3RvIHVjZmxhZ2V4DQorZ290byB1Y2ZsYWduZQ0KKw0KKzp1Y2Zs YWdleA0KK3NoaWZ0DQorc2V0IHVzZXJjZmxhZ3M9JXVzZXJjZmxhZ3MlJXNlcDElJX4xDQorc2V0 IHNlcDE9ICVub3RoaW5nJQ0KK3NoaWZ0DQorZ290byBhZ2Fpbg0KKw0KKzp1Y2ZsYWduZQ0KIHNo aWZ0DQogc2V0IHVzZXJjZmxhZ3M9JXVzZXJjZmxhZ3MlJXNlcDElJTENCiBzZXQgc2VwMT0gJW5v dGhpbmclDQpAQCAtMjA3LDYgKzI0NSwxNyBAQAogcmVtIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NCiANCiA6dXNl cmxkZmxhZ3MNCitpZiAiJXVzZV9leHRlbnNpb25zJSIgPT0gIjEiIGdvdG8gdWxmbGFnZXgNCitn b3RvIHVsZmxhZ25lDQorDQorOnVsZmxhZ2V4DQorc2hpZnQNCitzZXQgdXNlcmxkZmxhZ3M9JXVz ZXJsZGZsYWdzJSVzZXAyJSV+MQ0KK3NldCBzZXAyPSAlbm90aGluZyUNCitzaGlmdA0KK2dvdG8g YWdhaW4NCisNCis6dWxmbGFnbmUNCiBzaGlmdA0KIHNldCB1c2VybGRmbGFncz0ldXNlcmxkZmxh Z3MlJXNlcDIlJTENCiBzZXQgc2VwMj0gJW5vdGhpbmclDQoK --0015174c0bdebdc27d04a0ea82f2--