From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r103913: Improve C-level modularity by making more things 'static'. Date: Fri, 15 Apr 2011 03:28:41 +0200 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1302830971 7076 80.91.229.12 (15 Apr 2011 01:29:31 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 15 Apr 2011 01:29:31 +0000 (UTC) Cc: Emacs developers To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 15 03:29:27 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QAXqg-000102-KQ for ged-emacs-devel@m.gmane.org; Fri, 15 Apr 2011 03:29:26 +0200 Original-Received: from localhost ([::1]:38900 helo=lists2.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QAXqf-00033r-VJ for ged-emacs-devel@m.gmane.org; Thu, 14 Apr 2011 21:29:25 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:36220) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QAXqd-00033j-PE for emacs-devel@gnu.org; Thu, 14 Apr 2011 21:29:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QAXqc-0006cE-P7 for emacs-devel@gnu.org; Thu, 14 Apr 2011 21:29:23 -0400 Original-Received: from mail-gx0-f169.google.com ([209.85.161.169]:51655) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QAXqc-0006c6-ME for emacs-devel@gnu.org; Thu, 14 Apr 2011 21:29:22 -0400 Original-Received: by gxk23 with SMTP id 23so1275000gxk.0 for ; Thu, 14 Apr 2011 18:29:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type:content-transfer-encoding; bh=5+urN/rzgBN/0EiarSfQ4bloe6nna/MpHwwfctDIHLU=; b=hFPRd/jjpW+EdatHpIplkfCeGwVozuLst7Z1zF3a9PODYGJkr9dwVCNvIoNOltLgWZ J5FYfvA4XnPyfRizlRTCIyXevnw//khfqtkPsR9tDi9+gmNgRbz4FZtXLgarNQ+UQwWy PSHgw9mlEm/QxU1FFtV5yw9ra8gcy5e2NqObA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=dbp01XRQr482kmoNjZgvhZ2CkX5mnW7070YcP0rsuZ59zHslYsVh/rP/9CDo/GDiYo h8unX7B8x9fGPov4BeTdVIQxbWdZZ3NtDsBCHKPS0+MAl7jVJ/CE7zG1VYJ3cnTdgGEs 1akMPUObC/RBWBK/1+LXPrRBgd8M7awTx3puQ= Original-Received: by 10.146.54.7 with SMTP id c7mr213274yaa.22.1302830961371; Thu, 14 Apr 2011 18:29:21 -0700 (PDT) Original-Received: by 10.147.182.17 with HTTP; Thu, 14 Apr 2011 18:28:41 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.161.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:138489 Archived-At: On Fri, Apr 15, 2011 at 01:19, Paul Eggert wrote: > -Lisp_Object Qopentype; > +static Lisp_Object Qopentype; This breaks compilation on Windows, because Qopentype is used from w32uniscribe, so I have reverted this bit. I've opted not to add Qopentype to font.h and remove the external declaration from w32uniscribe.c because it is its only use; feel free to change it to suit your tastes. =C2=A0 =C2=A0 Juanma