From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] GnuTLS support on Woe32 Date: Tue, 3 May 2011 12:01:17 +0200 Message-ID: References: <87ipvwl1nx.wl%claudio.bley@gmail.com> <87wrjquacf.fsf@lifelogs.com> <87lj05svwh.fsf@lifelogs.com> <87bp11imgb.wl%claudio.bley@gmail.com> <8739mc5nes.fsf@lifelogs.com> <87ipuubao6.fsf@lifelogs.com> <87fwpjfkkz.fsf@lifelogs.com> <87bp072fb1.fsf@lifelogs.com> <874o5vimm5.fsf@lifelogs.com> <87zknjmcyk.fsf@lifelogs.com> <87sjta2zvp.fsf@lifelogs.com> <87liyzglkh.fsf@lifelogs.com> <4DB77682.1070605@gmail.com> <8762q04ba1.fsf@lifelogs.com> <87hb9dufao.fsf@lifelogs.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1304416935 25903 80.91.229.12 (3 May 2011 10:02:15 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 3 May 2011 10:02:15 +0000 (UTC) Cc: tzz@lifelogs.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 03 12:02:11 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QHCQg-00073m-DS for ged-emacs-devel@m.gmane.org; Tue, 03 May 2011 12:02:06 +0200 Original-Received: from localhost ([::1]:40483 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QHCQf-00071I-Nn for ged-emacs-devel@m.gmane.org; Tue, 03 May 2011 06:02:05 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:42793) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QHCQc-00070y-8c for emacs-devel@gnu.org; Tue, 03 May 2011 06:02:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QHCQZ-0002Mx-U0 for emacs-devel@gnu.org; Tue, 03 May 2011 06:02:02 -0400 Original-Received: from mail-gx0-f169.google.com ([209.85.161.169]:54838) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QHCQX-0002MZ-TP; Tue, 03 May 2011 06:01:58 -0400 Original-Received: by gxk23 with SMTP id 23so2762111gxk.0 for ; Tue, 03 May 2011 03:01:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type:content-transfer-encoding; bh=7aUrHRnxJrzJ4La/XtFJ8l6mUhUPUDUdRAAYHIcPh80=; b=fWOXnJ2wGv7LiKzujJsP0/WC6rjmAg1hh8zRsh+yP2h0aW6HMQMpeyLvJ+3YTnlwJY CWlP74wW35VmamfN/JTV/8DIQqvEf1Q7Js/MAj0BgUCqt70Nqu2YFclommjhJzVLWbO4 V5qF/zX7MMMom835Teh4wZDyQSQMYC+zEScmE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=m+mWgG7rnGCCNQQWMGzQGuiA/B522m7XtHpXlU2lJd6z06XhlWO/fwnxjOeUkm3DGH tE1KPS6Ym6XFixiTsLFW8k3xe/gYcCGSQbD3JvU0rYEzsXpfhg3b2So11o2yEyIUNxE5 s9iXVBGkSAjXp7e4YXM5Ox3qxL9cmBXa+XqmE= Original-Received: by 10.146.8.34 with SMTP id 34mr5405841yah.28.1304416917090; Tue, 03 May 2011 03:01:57 -0700 (PDT) Original-Received: by 10.147.182.5 with HTTP; Tue, 3 May 2011 03:01:17 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.161.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:139047 Archived-At: On Tue, May 3, 2011 at 06:19, Eli Zaretskii wrote: > However, this: > >> +#include "lisp.h" > > is bad: lisp.h is already included in too many places. =C2=A0Why did you > need this? Because of Lisp_Object. The alternative would be to put Vlibrary_cache and w32_delayed_load in another module. >> +/* The argument LIBRARIES is usually the variable >> + =C2=A0 `dynamic-library-alist', which associates a symbol, identifying >> + =C2=A0 an external DLL library, to a list of possible filenames. >> + =C2=A0 The function returns NULL if no library could be loaded for >> + =C2=A0 the given symbol, or if the library was previously loaded; >> + =C2=A0 else the handle of the DLL. =C2=A0*/ >> +HMODULE >> +w32_delayed_load (Lisp_Object libraries, Lisp_Object library_id) > > has a couple of problems in the commentary: > > =C2=A0. it should describe the structure of the LIBRARIES alist explicitl= y, > =C2=A0 like you'd do in a doc string, not just refer to > =C2=A0 `dynamic-library-alist' > > . it says nothing about the second argument (and IIUC what it means, > the "_id" part of the variable name is misleading) IIRC, I just moved the code from image.c to here and renamed the variables. I'll try to fix it. > Btw, why is it a good idea to return NULL if the library is already > loaded? =C2=A0Why not return its handle instead? Honestly, I asked myself the same question. That was in the image.c version (written almost seven years ago) and I don't remember why I thought it was a good idea in the first place. But I was concentrating in getting GnuTLS loading to work, not on improvements. I'll check. Thanks for your comments, =C2=A0 =C2=A0 Juanma