From: "Drew Adams" <drew.adams@oracle.com>
To: "'Dan Nicolaescu'" <dann@ics.uci.edu>, <emacs-devel@gnu.org>
Subject: RE: show whitespace problems by default in diff-mode
Date: Thu, 16 Jul 2009 15:33:58 -0700 [thread overview]
Message-ID: <B83328ABE34746D49744327BA848D919@us.oracle.com> (raw)
In-Reply-To: <200907162214.n6GMEo5o025706@godzilla.ics.uci.edu>
> diff-mode is set up to show trailing whitespace problems, but it's not
> doing it by default, to enable this one has to do:
>
> (add-hook 'diff-mode-hook 'whitespace-mode)
>
> Vinicius also posted a patch to edit files to clean the trailing
> whitespace problems based on the diff.
>
> Why not turn on whitespace-mode by default in diff-mode? It makes
> spotting whitespace problems very easy, and will make it also easy to
> fix.
Perhaps for the same reason that whitespace diffs are ignored by default by
`diff' - because whitespace differences (including trailing whitespace) are
often _not_ so interesting.
What's the problem with setting `diff' switches and adding `whitespace-mode' to
the hook the way you want? Why should the default value change? When you "make
spotting whitespace problems very easy" you also make ignoring whitespace
problems more difficult.
I don't have a particular axe to grind, here. It's just not clear that most
people will want to show whitespace diffs (or even trailing whitespace) most of
the time. If you can support that claim, then sure, go for it.
next prev parent reply other threads:[~2009-07-16 22:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-16 22:14 show whitespace problems by default in diff-mode Dan Nicolaescu
2009-07-16 22:33 ` Drew Adams [this message]
2009-07-16 22:53 ` Dan Nicolaescu
2009-07-16 23:06 ` Drew Adams
2009-07-16 23:19 ` Dan Nicolaescu
2009-07-16 23:38 ` Miles Bader
2009-07-17 1:35 ` Dan Nicolaescu
2009-07-17 1:45 ` Miles Bader
2009-07-17 2:29 ` Óscar Fuentes
2009-07-17 3:24 ` Miles Bader
2009-07-17 3:36 ` Dan Nicolaescu
2009-07-17 4:15 ` Óscar Fuentes
2009-07-17 4:26 ` Miles Bader
2009-07-17 6:39 ` Dan Nicolaescu
2009-07-17 7:49 ` Miles Bader
2009-07-17 0:03 ` Óscar Fuentes
2009-07-17 1:37 ` Dan Nicolaescu
2009-07-17 3:14 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B83328ABE34746D49744327BA848D919@us.oracle.com \
--to=drew.adams@oracle.com \
--cc=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).