From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: Tree-sitter integration on feature/tree-sitter Date: Fri, 17 Jun 2022 17:28:49 -0700 Message-ID: References: <2c2746e5f2558a87e8eab6f0914264a020173a9d.camel@pm.me> <27630AA3-8026-4E24-8852-ACCD9325B99D@gmail.com> <0E9E702B-B07C-4794-8498-29B9320E14CC@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11446"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs Devel , Yoav Marco To: jostein@kjonigsen.net Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jun 18 02:31:59 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o2MNa-0002oD-Px for ged-emacs-devel@m.gmane-mx.org; Sat, 18 Jun 2022 02:31:58 +0200 Original-Received: from localhost ([::1]:48422 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o2MNZ-0006IB-Fl for ged-emacs-devel@m.gmane-mx.org; Fri, 17 Jun 2022 20:31:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39860) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2MKb-0005Jw-LD for emacs-devel@gnu.org; Fri, 17 Jun 2022 20:28:53 -0400 Original-Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]:43773) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o2MKa-0006cO-AL for emacs-devel@gnu.org; Fri, 17 Jun 2022 20:28:53 -0400 Original-Received: by mail-pg1-x536.google.com with SMTP id s135so5301646pgs.10 for ; Fri, 17 Jun 2022 17:28:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=IM51eQC2pPRVkH8ydyb+nv2DoOGbhURx3UXOWEuymW8=; b=UdxlWQfgdK0Sigif9xWcfEd0jktx+KioeCwhuMjVQlfdboJJmam0DjaBkZhn3CneOt CD9wL+AElsZ7cVWX3qgRpLWz77YRiASMDJGyem/1M8diRZ64EQrhxI0nm+TbOhRl0B75 RE8ieCPXN6yCZuTy7oE3Js0G7LPpbss1vvXXsh6ezsLzPjtpSx9tfcrzp/87oIacbR+3 I6jE1IRRdKpBJUAFIbvcLW0EO2LlBTfK0g4JzSWuvzk3TiRiEcQ7GtWc0XtBAtlitkQs owDxzyafLo7u0CQmCPDNmuTh6O1q+gHK+OZvR4xZGsenx0a17LZItLh+BOlXQWuqex/w NdNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=IM51eQC2pPRVkH8ydyb+nv2DoOGbhURx3UXOWEuymW8=; b=An11PKq6JdxX0GKv5NfYWOG4W620LTxJEpbSF0U/r0i8N+do55yOIf4zE2rXeIPU3s VpEGGwm2u1SIvdEyYkum4TlQiy6s0yy0bs8hC5rmercOouIMnAqREj8581E3ApPTm1A+ uFgjTtBHWawixED+ueDC5YGLHZiFfdn6r21xu3yh2+t686f/YrPIogITuyqjiLwrAUto Eoz7WPALP9Gjwsnt0ZOzkW3ZqN1eKv8fX5AA/9UMuZSLayZ3+uasOWvRKEVq2XKiiuL6 3czyfdaWcAm6U36wjLbVI7Ttdbb3MTktoh96pijohz5bsS0HD++njgQNQthZbfrBfZw6 KUew== X-Gm-Message-State: AJIora/vwLnd/ZlL4GXpVkHywEd0asIN9Ktz8bG5wV4CGu8feQ3GNljS 2m8Y3BqqKKs5tiFdpRrwkIY= X-Google-Smtp-Source: AGRyM1u83Sv5yLf+m7c7b2aRrNkVyGnivkL6eKT7HK+7+e2pl0pAfnLkGhccSzeMqmuITOtExjMLMg== X-Received: by 2002:a63:ea06:0:b0:3fd:a385:a856 with SMTP id c6-20020a63ea06000000b003fda385a856mr11064298pgi.393.1655512130856; Fri, 17 Jun 2022 17:28:50 -0700 (PDT) Original-Received: from smtpclient.apple ([2600:1700:2ec7:8c90:c15:33ec:172b:f758]) by smtp.gmail.com with ESMTPSA id jj9-20020a170903048900b0016a100c9a2esm273640plb.112.2022.06.17.17.28.50 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Jun 2022 17:28:50 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3696.100.31) Received-SPF: pass client-ip=2607:f8b0:4864:20::536; envelope-from=casouri@gmail.com; helo=mail-pg1-x536.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:291324 Archived-At: > I tried to run the benchmarks again real quick, and ran into a = segfault. > It occurs in the call to ts_query_delete in cleanup_vector when > garbage collecting. >=20 > I'll try to gather more info tomorrow, going to bed now. >=20 > Yoav >=20 > Nice update! Good work! >=20 > Trying latest source from emacs feature/tree-sitter branch though, and = updating my code to use treesite-parser-create rather than = treesit-get-parser-create... I have emacs segfaulting because of a = double-free. I=E2=80=99ve figure out the problem. It is due to my misunderstanding of = how gc works. I=E2=80=99ve pushed a fix. On a separate note, I also pushed the change that makes = treesit-parser-list a function (rather than a variable). Yuan=