unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: JD Smith <jdtsmith@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Popup-menu signals quit when Aborted
Date: Sat, 1 Feb 2020 16:58:53 -0500	[thread overview]
Message-ID: <B5783DAA-7D1E-4341-9A0C-D0E5B2C2CD1D@gmail.com> (raw)
In-Reply-To: <83r1zei78j.fsf@gnu.org>

Not my code, just investigating a possible bug on request of its author.  

> On Feb 1, 2020, at 11:48 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> 
>> From: JD Smith <jdtsmith@gmail.com>
>> Date: Sat, 1 Feb 2020 11:41:40 -0500
>> 
>> I'm glad you find it so, because I can't figure out the underlying logic
>> of this oddity.  Can you explain why you think it's sensible?
>> 
>> It seems sensible to me that if a mouse-event generates a popup menu, and it is “gotten rid of” by the user by
>> clicking off the menu, that this should NOT signal a quit and ring the bell as if some kind of error has
>> occurred.  This is what `x-popup-menu` appears to implement, but its higher-level interface `popup-menu`
>> inhibits this sensible feature by “normalizing” positions.  
>> 
>> I encountered this using minions mode.  Its popup menu for minor modes is very useful, but sometimes you
>> just want to take a quick look at what modes are set, and not alter anything. But clicking off the menu to get rid
>> of it signals ‘quit and rings the bell.  Reading the note above in `x-popup-menu` I considered passing a mouse
>> event would be a reliable fix.  But since `popup-menu` strips event information, the only remaining possibility is
>> to trap the quit:
> 
> Any reason why you didn't use x-popup-menu?




      reply	other threads:[~2020-02-01 21:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-01 14:51 Popup-menu signals quit when Aborted JD Smith
2020-02-01 15:14 ` Eli Zaretskii
2020-02-01 15:55 ` Stefan Monnier
2020-02-01 16:41   ` JD Smith
2020-02-01 16:47     ` Stefan Monnier
2020-02-01 21:58       ` JD Smith
2020-02-01 16:48     ` Eli Zaretskii
2020-02-01 21:58       ` JD Smith [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B5783DAA-7D1E-4341-9A0C-D0E5B2C2CD1D@gmail.com \
    --to=jdtsmith@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).