Re: [Emacs-diffs] master fd54102: * lisp/files.el (file-size-function): New defcustom

["Mattias Engdegård" <mattiase@acm.org>]

[-- Attachment #1: Type: text/plain, Size: 1004 bytes --]

20 juli 2019 kl. 20.50 skrev Basil L. Contovounesios <contovob@tcd.ie>:
> 
> New user options in central places like files.el (as opposed to some
> specialised package) usually warrant a RFC so as to establish which need
> they are addressing, whether this need masks some other issue, and
> whether the proposed change covers this need sufficiently well.
> 
> Internal variables can come and go, but user options are user-facing
> contracts that are harder to change or get rid of.

Agreed, and this defcustom (file-size-function) has a much more general-sounding name and description than merited by its effects (which are limited to the "available disk space" number in Dired and that's it).

Attached is a minimal clean-up which remedies some of the flaws, but perhaps we should instead roll back the defcustom and all related changes entirely until a cohesive proposal is forthcoming, as per your and Eli's comments. Fighting it out in the source isn't really going to be productive.


[-- Attachment #2: 0001-Clean-up-file-size-function-with-better-default-valu.patch --]
[-- Type: application/octet-stream, Size: 1675 bytes --]

From e48fd413e4bb70829c4a5783198facdb6422a2b2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mattias=20Engdeg=C3=A5rd?= <mattiase@acm.org>
Date: Mon, 22 Jul 2019 17:10:37 +0200
Subject: [PATCH] Clean up file-size-function, with better default value

* lisp/files.el (size-human-readable-iec): New.
(file-size-function): Better default value.  Eliminate lambda.
Better default for custom choice.  Put in group `dired'.
---
 lisp/files.el | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/lisp/files.el b/lisp/files.el
index 70865ebcdf..868e23f0d1 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -6698,13 +6698,17 @@ directory-free-space-args
 			"ignored, as Emacs uses `file-system-info' instead"
 			"27.1")
 
-(defcustom file-size-function #'file-size-human-readable
+(defun size-human-readable-iec (size)
+  "Human-readable string for SIZE bytes, using IEC prefixes."
+  (file-size-human-readable size 'iec " "))
+
+(defcustom file-size-function #'size-human-readable-iec
   "Function that transforms the number of bytes into a human-readable string."
   :type `(radio
-          (function-item :tag "Default" file-size-human-readable)
-          (function-item :tag "IEC"
-                         ,(lambda (size) (file-size-human-readable size 'iec " ")))
-          (function :tag "Custom function"))
+          (function-item :tag "IEC" size-human-readable-iec)
+          (function-item :tag "Traditional" file-size-human-readable)
+          (function :tag "Custom function" number-to-string))
+  :group 'dired
   :version "27.1")
 
 (defun get-free-disk-space (dir)
-- 
2.20.1 (Apple Git-117)


[-- Attachment #3: Type: text/plain, Size: 2 bytes --]