From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: master 9f464cc: Stop using calc for ntlm time computation Date: Mon, 26 Oct 2020 22:57:48 +0100 Message-ID: References: <20200816091703.7193.11125@vcs0.savannah.gnu.org> <20200816091705.318C0209AC@vcs0.savannah.gnu.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5482"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Thomas Fitzsimmons Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 26 23:07:04 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kXAds-0001M5-I7 for ged-emacs-devel@m.gmane-mx.org; Mon, 26 Oct 2020 23:07:04 +0100 Original-Received: from localhost ([::1]:41422 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXAdr-0008MC-G2 for ged-emacs-devel@m.gmane-mx.org; Mon, 26 Oct 2020 18:07:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37136) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXAV9-0000ij-QX for emacs-devel@gnu.org; Mon, 26 Oct 2020 17:58:05 -0400 Original-Received: from mail172c50.megamailservers.eu ([91.136.10.182]:35810 helo=mail33c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXAV5-0004Fz-8U for emacs-devel@gnu.org; Mon, 26 Oct 2020 17:58:01 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1603749472; bh=Aze498dKWXzu0B4o8H0DANALniQa7mFG1VD7oU3jeMo=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=E80K6L5RkZkcglgujF3RG+AmwkBysu6XNYfvKHaEMkwLAigdJqNV/BqySjgXgql/9 XdVYMsZwv3MDnDvy9/qjpPcCSJdX9OpvsYsyE6oLHRPmhNWBdVcvGHoP1E6mX+lubq gRgd8jKoY8so6xR+pBrtnEmCgBTRhX8SWMuO0nXc= Feedback-ID: mattiase@acm.or Original-Received: from stanniol.lan (c-304ee655.032-75-73746f71.bbcust.telenor.se [85.230.78.48]) (authenticated bits=0) by mail33c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 09QLvmTv017370; Mon, 26 Oct 2020 21:57:50 +0000 In-Reply-To: X-Mailer: Apple Mail (2.3445.104.17) X-CTCH-RefID: str=0001.0A782F19.5F97465F.0044:SCFSTAT76743386, ss=1, re=-4.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: -4.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=eaJDgIMH c=1 sm=1 tr=0 a=63Z2wlQ1NB3xHpgKFKE71g==:117 a=63Z2wlQ1NB3xHpgKFKE71g==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=3rqLRVTUAAAA:8 a=zSuU_8qUMvT9r_7JyIEA:9 a=CjuIK1q_8ugA:10 a=QMBpobIPesxPUnXlahKo:22 X-Origin-Country: SE Received-SPF: softfail client-ip=91.136.10.182; envelope-from=mattiase@acm.org; helo=mail33c50.megamailservers.eu X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/26 17:57:54 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x (no timestamps) [generic] X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258484 Archived-At: 26 okt. 2020 kl. 22.19 skrev Thomas Fitzsimmons : > ntlm.el goes into GNU ELPA so I'd like to keep it working on older > versions of Emacs. I usually try to keep it working at least back to > Emacs 24.1, the first version to support packages via package.el. Sorry, I had no idea! > The new code definitely makes sense for Emacs versions that have = bignum > support. However I'd like to know before I bump the ntlm.el version > (and thus make these updates available to GNU ELPA users), are there > configurations anyone knows of where the new code will fail, but the > "calc" version would work? Yes, the new code certainly won't work with Emacs versions older than = 27.1 that use 31-bit fixnums, which should be most 32-bit platforms. > I seem to remember I wrote the strange calc version to avoid integer > overflow, but I don't remember the characteristics of the system on > which I developed it; maybe it had a 32-bit word size. Admittedly > though, I recently tried the new calculation code on Emacs 24.1, = running > on an x86-64 system, and it works. Yes, it will work on 64-bit systems; they have 63-bit fixnums which = should be enough. > Still, if these types of calculations are known to overflow on 32-bit > Emacs builds then my inclination would be to conditionalize them. The change was partly made in order to remove the dependency on Calc so = rather than bringing it back, I'd prefer dealing with the problem = locally in ntlm.el -- either with some domain-specific cleverness or = just by implementing a few basic arithmetic primitives (poor man's = bignum). However, I don't have access to any 32-bit Emacs, so I would need help = for testing it.