From: "Herring, Davis" <herring@lanl.gov>
To: Thien-Thi Nguyen <ttn@gnuvola.org>, Chong Yidong <cyd@gnu.org>
Cc: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: RE: Security flaw in enable-local-eval; new release plan
Date: Mon, 13 Aug 2012 12:45:33 +0000 [thread overview]
Message-ID: <B393F5AD12955C48A84FFB08032CD04F0970CFEC@ECS-EXG-P-MB01.win.lanl.gov> (raw)
In-Reply-To: <87r4rbjo86.fsf@zigzag.favinet>
> (let ((safe (or (hack-one-local-variable-eval-safep
> (eval (quote val)))
> ;; In case previously marked safe (bug#5636).
> (safe-local-variable-p var val))))
> [...]
> It seems control reaches ‘eval’ before reaching the ‘:safe’ check, thus
> defeating the check. Am i missing something?
The `eval' is of a `quote', so I don't know why it's not just `val'. Meanwhile, calling `safe-local-variable-p' for the `eval' pseudo-variable seems wrong to me, even though by default nothing is safe for it (and it would be insane to put an entry, nominally for `eval''s value as a variable, in `safe-local-variable-values').
Davis
next prev parent reply other threads:[~2012-08-13 12:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 3:10 Security flaw in enable-local-eval; new release plan Chong Yidong
2012-08-13 6:32 ` Thien-Thi Nguyen
2012-08-13 12:45 ` Herring, Davis [this message]
2012-08-13 6:49 ` Glenn Morris
2012-08-13 8:06 ` Ulrich Mueller
2012-08-14 4:07 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B393F5AD12955C48A84FFB08032CD04F0970CFEC@ECS-EXG-P-MB01.win.lanl.gov \
--to=herring@lanl.gov \
--cc=cyd@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=ttn@gnuvola.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).