From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Jan D." Newsgroups: gmane.emacs.devel Subject: Re: GTK patches part 2 Date: Wed, 11 Dec 2002 18:48:04 +0100 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <16731.1039555439@remus.pretzelnet.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 (Apple Message framework v482) Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Trace: main.gmane.org 1039631971 30991 80.91.224.249 (11 Dec 2002 18:39:31 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Wed, 11 Dec 2002 18:39:31 +0000 (UTC) Cc: emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18MBla-00083j-00 for ; Wed, 11 Dec 2002 19:39:30 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18MBwk-0007Xq-00 for ; Wed, 11 Dec 2002 19:51:02 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18MBBh-0002CY-02 for emacs-devel@quimby.gnus.org; Wed, 11 Dec 2002 13:02:25 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18MBBM-0002CA-00 for emacs-devel@gnu.org; Wed, 11 Dec 2002 13:02:04 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18MBBJ-0002BP-00 for emacs-devel@gnu.org; Wed, 11 Dec 2002 13:02:03 -0500 Original-Received: from stubby.bodenonline.com ([193.201.16.94]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18MBBI-0002A9-00 for emacs-devel@gnu.org; Wed, 11 Dec 2002 13:02:01 -0500 Original-Received: from accessno42.bodenonline.com (IDENT:root@accessno42.bodenonline.com [193.201.16.44]) gBBHgv16002807; Wed, 11 Dec 2002 18:42:58 +0100 Original-To: Eric Gillespie In-Reply-To: <16731.1039555439@remus.pretzelnet.org> X-Mailer: Apple Mail (2.482) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:10062 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:10062 > "Jan D." writes: >> For example, stdlib.h is included by config.h, so it is clearly > > Whoops. When i noticed the stderr problem also noticed malloc > being called with no stdlib.h. As i said, my preferred style > would be to go ahead and explicitly include stdlib.h in gtkutil.c > itself. But i don't get to make such decisions for emacs, nor do > i want to; it works and that's all that matters to me. I'm not sure what the Emacs policy is. The GNU coding standards don't say much on the issue. It has a passage that discusses the advantage of not declaring system functions at all rather than declaring them yourself, but I don't think that applies. > Just out of curiosity, which header included stdio.h for you on > your system? s/gnu-linux.h in Emacs does actually. Jan D.