From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?iso-8859-1?Q?Jan_Dj=E4rv?= Newsgroups: gmane.emacs.devel,gmane.comp.gnome.gtk+.general Subject: Re: Emacs --with-x-toolkit=gtk3 - iconify, move mouse over icon -> crash Date: Sun, 30 Oct 2011 19:09:01 +0100 Message-ID: References: <87obxmicsg.fsf@topper.koldfront.dk> <87zkh62c4e.fsf@topper.koldfront.dk> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v1251.1) Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1319998153 8525 80.91.229.12 (30 Oct 2011 18:09:13 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 30 Oct 2011 18:09:13 +0000 (UTC) Cc: gtk-list@gnome.org, emacs-devel@gnu.org To: =?iso-8859-1?Q?Adam_Sj=F8gren?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 30 19:09:09 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RKZoi-00010Z-Tv for ged-emacs-devel@m.gmane.org; Sun, 30 Oct 2011 19:09:09 +0100 Original-Received: from localhost ([::1]:45939 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKZoi-0006Is-5C for ged-emacs-devel@m.gmane.org; Sun, 30 Oct 2011 14:09:08 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:34192) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKZoe-0006Ic-Pw for emacs-devel@gnu.org; Sun, 30 Oct 2011 14:09:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RKZoc-0004Dv-J4 for emacs-devel@gnu.org; Sun, 30 Oct 2011 14:09:04 -0400 Original-Received: from mail-bw0-f41.google.com ([209.85.214.41]:47078) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKZoc-0004B5-Ch for emacs-devel@gnu.org; Sun, 30 Oct 2011 14:09:02 -0400 Original-Received: by bkbzv15 with SMTP id zv15so695476bkb.0 for ; Sun, 30 Oct 2011 11:09:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer; bh=xhi30nsW3fMnHt0SWkesyN0hl41dq8i++h5KUOs0jA4=; b=XwD9oVG2HassmhSYVTycvzdK092nHHa/nX7N9Sh4d9wu82QaclzdUG5g6SypNAtIUz aR9W7ghUPy6tt4qjRUYVSqgfIe1GubaSItp85J/K7Oh0RDbwtVed9Ka2f5sZAQuo2CMM GAg9wHHDZmwVlaA27raifunJVVgbobBsiOxww= Original-Received: by 10.204.34.75 with SMTP id k11mr8337146bkd.68.1319998141380; Sun, 30 Oct 2011 11:09:01 -0700 (PDT) Original-Received: from [172.20.199.13] (c-c92de155.25-1-64736c10.cust.bredbandsbolaget.se. [85.225.45.201]) by mx.google.com with ESMTPS id k6sm14443820bkv.8.2011.10.30.11.09.00 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 30 Oct 2011 11:09:01 -0700 (PDT) In-Reply-To: <87zkh62c4e.fsf@topper.koldfront.dk> X-Mailer: Apple Mail (2.1251.1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.214.41 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:145803 gmane.comp.gnome.gtk+.general:24119 Archived-At: Hello. I installed the patch with tiny modifications. Jan D. 12 okt 2011 kl. 22:22 skrev Adam Sj=F8gren: > On Wed, 12 Oct 2011 15:01:51 +0200, I wrote: >=20 >> When I compile emacs with gtk3 I get a crash if I iconify the Emacs >> window and move the mouse over the icon. > [...] >=20 > The attached trivial patch avoids the crash for me. I wonder if gtk3 > should be catching those X errors as gtk2 seemed to, if Emacs should > handle them itself, or something else? >=20 > diff --git a/src/xterm.c b/src/xterm.c > index 4d3b572..c8b6771 100644 > --- a/src/xterm.c > +++ b/src/xterm.c > @@ -93,6 +93,9 @@ along with GNU Emacs. If not, see = . */ >=20 > #ifdef USE_GTK > #include "gtkutil.h" > +#ifdef HAVE_GTK3 > +#include > +#endif > #endif >=20 > #ifdef USE_LUCID > @@ -7848,6 +7851,13 @@ static void x_error_quitter (Display *, = XErrorEvent *); > static int > x_error_handler (Display *display, XErrorEvent *event) > { > +#ifdef HAVE_GTK3 > + if (event->error_code =3D=3D BadMatch && event->request_code =3D=3D = X_SetInputFocus && event->minor_code =3D=3D 0) { > + fprintf(stderr, "Ignoring XErrorEvent(BadMatch X_SetInputFocus) = serial: %ul\n", event->serial); > + return 0; > + } > +#endif > + > if (x_error_message) > x_error_catcher (display, event); > else >=20 >=20 > Best regards, >=20 > Adam >=20 > --=20 > "Gav Adam = Sj=F8gren > Strik" = asjo@koldfront.dk >=20