From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Reitter Newsgroups: gmane.emacs.devel Subject: Re: tool-bar (Carbon port): labels under icons Date: Sat, 5 Apr 2008 23:27:39 +0100 Message-ID: References: <1B41BDB3-EFEC-4CFC-8006-2233F8D90024@inf.ed.ac.uk> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v919.2) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1207434535 4377 80.91.229.12 (5 Apr 2008 22:28:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 5 Apr 2008 22:28:55 +0000 (UTC) Cc: emacs- devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 06 00:29:28 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JiGt4-0005yw-GT for ged-emacs-devel@m.gmane.org; Sun, 06 Apr 2008 00:29:26 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JiGsR-0000wV-LK for ged-emacs-devel@m.gmane.org; Sat, 05 Apr 2008 18:28:47 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JiGrU-0008AK-HR for emacs-devel@gnu.org; Sat, 05 Apr 2008 18:27:48 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JiGrT-00088n-Dn for emacs-devel@gnu.org; Sat, 05 Apr 2008 18:27:47 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JiGrT-00088a-3Q for emacs-devel@gnu.org; Sat, 05 Apr 2008 18:27:47 -0400 Original-Received: from mu-out-0910.google.com ([209.85.134.187]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JiGrS-0007n5-Qf for emacs-devel@gnu.org; Sat, 05 Apr 2008 18:27:47 -0400 Original-Received: by mu-out-0910.google.com with SMTP id g7so1140132muf.0 for ; Sat, 05 Apr 2008 15:27:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:cc:message-id:from:to:in-reply-to:content-type:content-transfer-encoding:mime-version:subject:date:references:x-mailer:sender; bh=KLz/n8RUJmC45fW6HGtAyOGfcx2gpEPe96SBsDf2jBU=; b=YiawO2YsE0TyI5dEzn3vS6t5AeG4QzHcdkCan6og86r75xfWG6X5athAFeWcDFCX7oLWtCBg1BRVtEXR48qO5jWB3bFKUUb8fatXw+o4YGGK9n3ad7Mqwgq7RHzD8mP4EEQuf6DEI2DciFGspJJJm4omnKkRWY3ht9XCnZEafpI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=cc:message-id:from:to:in-reply-to:content-type:content-transfer-encoding:mime-version:subject:date:references:x-mailer:sender; b=TX5OvNLDnQBYB6PI2gC5pKwqOJoXk3/mZ6OhnDlxU0fxmd/qNZ5FPfKUxvHJxU1q1hrvln8l6YVAz0HUAN4pb3+vxYdUu5x2eFhed9J26SU5zh0/SKx+eNiqW3Uf4lFYZVSahdkGU53tPl6juPCSbxUyG666m3QM4027RyD+8FM= Original-Received: by 10.78.134.7 with SMTP id h7mr2441283hud.114.1207434465687; Sat, 05 Apr 2008 15:27:45 -0700 (PDT) Original-Received: from scarlett.lan ( [89.241.128.168]) by mx.google.com with ESMTPS id k5sm10789486nfd.23.2008.04.05.15.27.44 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 05 Apr 2008 15:27:44 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.919.2) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:94452 Archived-At: On 5 Apr 2008, at 16:40, Stefan Monnier wrote: >> >> * tool-bar.el (tool-bar-local-item): Accept string for KEY >> as icon label. > > We should add a :caption property to menu-items instead. Using > strings > for keys may work, but it's a hack. In the last patch that I posted here, I've changed that now to use the `item-name' element in an menu-item structure of the form (menu-item item-name real-binding . item-property-list) which is usually a string. tool-bar.el now as a backwards-compatible interface to set the labels. One can use a :caption property if using the menu item string is inappropriate for some reason. This works nicely now in the Carbon (the new native tool bar code by Yamamoto Mitsuharu is really nice and allows for high-quality tool bar interactions, especially when PNGs are used for icons). Someone who understands GTK could probably try out switching labels on there, too.