From: David Reitter <dreitter@inf.ed.ac.uk>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs- devel <emacs-devel@gnu.org>
Subject: Re: tool-bar (Carbon port): labels under icons
Date: Sat, 5 Apr 2008 23:27:39 +0100 [thread overview]
Message-ID: <B23E6148-470B-4130-BFB7-92497B4829BD@inf.ed.ac.uk> (raw)
In-Reply-To: <jwvprt4z515.fsf-monnier+emacs@gnu.org>
On 5 Apr 2008, at 16:40, Stefan Monnier wrote:
>>
>> * tool-bar.el (tool-bar-local-item): Accept string for KEY
>> as icon label.
>
> We should add a :caption property to menu-items instead. Using
> strings
> for keys may work, but it's a hack.
In the last patch that I posted here, I've changed that now to use the
`item-name' element in an menu-item structure of the form
(menu-item item-name real-binding . item-property-list)
which is usually a string. tool-bar.el now as a backwards-compatible
interface to set the labels. One can use a :caption property if using
the menu item string is inappropriate for some reason.
This works nicely now in the Carbon (the new native tool bar code by
Yamamoto Mitsuharu is really nice and allows for high-quality tool bar
interactions, especially when PNGs are used for icons). Someone who
understands GTK could probably try out switching labels on there, too.
next prev parent reply other threads:[~2008-04-05 22:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-05 7:50 tool-bar (Carbon port): labels under icons David Reitter
2008-04-05 8:10 ` Jan Djärv
2008-04-05 8:42 ` YAMAMOTO Mitsuharu
2008-04-05 8:40 ` YAMAMOTO Mitsuharu
2008-04-05 11:48 ` David Reitter
2008-04-05 12:33 ` YAMAMOTO Mitsuharu
2008-04-05 13:36 ` David Reitter
2008-04-05 15:40 ` Stefan Monnier
2008-04-05 22:27 ` David Reitter [this message]
2008-04-06 1:53 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B23E6148-470B-4130-BFB7-92497B4829BD@inf.ed.ac.uk \
--to=dreitter@inf.ed.ac.uk \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).