From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chad Brown Newsgroups: gmane.emacs.devel Subject: Re: recent commit broke src/dired.c on OSX Date: Sun, 25 Jul 2010 13:12:26 -0700 Message-ID: References: <86iq4379w0.fsf@red.stonehenge.com> <86eier7942.fsf@red.stonehenge.com> <86aapf78af.fsf@red.stonehenge.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v1081) Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1280088765 29645 80.91.229.12 (25 Jul 2010 20:12:45 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 25 Jul 2010 20:12:45 +0000 (UTC) Cc: emacs-devel@gnu.org, "Randal L. Schwartz" To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 25 22:12:42 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Od7Yv-0004mj-Ft for ged-emacs-devel@m.gmane.org; Sun, 25 Jul 2010 22:12:41 +0200 Original-Received: from localhost ([127.0.0.1]:41391 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Od7Yu-0008KK-OI for ged-emacs-devel@m.gmane.org; Sun, 25 Jul 2010 16:12:40 -0400 Original-Received: from [140.186.70.92] (port=55732 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Od7Ym-0008J2-3A for emacs-devel@gnu.org; Sun, 25 Jul 2010 16:12:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Od7Yl-00028y-24 for emacs-devel@gnu.org; Sun, 25 Jul 2010 16:12:31 -0400 Original-Received: from dmz-mailsec-scanner-7.mit.edu ([18.7.68.36]:59206) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Od7Yk-00028p-Tk for emacs-devel@gnu.org; Sun, 25 Jul 2010 16:12:31 -0400 X-AuditID: 12074424-b7c35ae000000a07-dd-4c4c9ab0d997 Original-Received: from mailhub-auth-3.mit.edu (MAILHUB-AUTH-3.MIT.EDU [18.9.21.43]) by dmz-mailsec-scanner-7.mit.edu (Symantec Brightmail Gateway) with SMTP id B7.FA.02567.0BA9C4C4; Sun, 25 Jul 2010 16:12:32 -0400 (EDT) Original-Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id o6PKCU79010378; Sun, 25 Jul 2010 16:12:30 -0400 Original-Received: from [10.0.1.5] (c-98-247-149-76.hsd1.wa.comcast.net [98.247.149.76]) (authenticated bits=0) (User authenticated as yandros@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id o6PKCQrT004280 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Sun, 25 Jul 2010 16:12:28 -0400 (EDT) In-Reply-To: X-Mailer: Apple Mail (2.1081) X-Brightmail-Tracker: AAAAAA== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:127790 Archived-At: I think Randal was on to something before; on my system, it's necessary = to remove the declaration of opendir() from dired.c (it conflicts with = the definition in ). The resulting build gives warnings: dired.c: In function =91Ffile_attributes=92: dired.c:1016: warning: comparison is always false due to limited range = of data type dired.c:1016: warning: comparison is always false due to limited range = of data type dired.c:1020: warning: comparison is always false due to limited range = of data type dired.c:1020: warning: comparison is always false due to limited range = of data type dired.c:1068: warning: comparison is always false due to limited range = of data type dired.c:1068: warning: comparison is always false due to limited range = of data type but seems to run. I haven't had a chance to test it extensively yet. It seems that Darwin's dirent.h prototype is: DIR *opendir(const char *) which conflicts with dired.c's unconditional (ifndef MSDOS) declaration: extern DIR *opendir(char *) I have to run of now and help a friend move, but I can try to dig into = this a little more when I return this evening, if it will help. Thanks, *Chad=