From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] espresso-mode breaks on JSON input Date: Fri, 11 Sep 2009 19:25:51 -0400 Message-ID: References: <7b501d5c0909111619y192b2dccv79a2181c82438913@mail.gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1252711577 29847 80.91.229.12 (11 Sep 2009 23:26:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 11 Sep 2009 23:26:17 +0000 (UTC) Cc: Emacs-Devel devel To: Deniz Dogan Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 12 01:26:10 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MmFVJ-0007ul-4v for ged-emacs-devel@m.gmane.org; Sat, 12 Sep 2009 01:26:09 +0200 Original-Received: from localhost ([127.0.0.1]:54704 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MmFVH-0002Dr-QY for ged-emacs-devel@m.gmane.org; Fri, 11 Sep 2009 19:26:07 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MmFVB-0002C0-QZ for emacs-devel@gnu.org; Fri, 11 Sep 2009 19:26:01 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MmFV7-0002AB-55 for emacs-devel@gnu.org; Fri, 11 Sep 2009 19:26:01 -0400 Original-Received: from [199.232.76.173] (port=42486 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MmFV7-0002A8-0m for emacs-devel@gnu.org; Fri, 11 Sep 2009 19:25:57 -0400 Original-Received: from mail-qy0-f181.google.com ([209.85.221.181]:46781) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MmFV6-0003tf-Om for emacs-devel@gnu.org; Fri, 11 Sep 2009 19:25:56 -0400 Original-Received: by qyk11 with SMTP id 11so1367061qyk.1 for ; Fri, 11 Sep 2009 16:25:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:cc:message-id:from:to :in-reply-to:content-type:content-transfer-encoding:mime-version :subject:date:references:x-pgp-agent:x-mailer; bh=Sr1HgFd5BzkYTsUwrasiG9WXAJiOQfo+Mum19LOQ71E=; b=YNRWH2ZzlASFvvSg+YWysBOuDxtYXk0nkNdE9tROjyb17yUuvlp7sJOihutpKWxbi8 sSr0j5e54nbPFAoYfN9H+YyTK4s1Rl2wt2Ejarg8VS7qIl5Pu9fZlBuioGM1DU/cmovd Nd31fE4JvEAOSnWlaxcK3gk5fVDh/QB57O7IA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=cc:message-id:from:to:in-reply-to:content-type :content-transfer-encoding:mime-version:subject:date:references :x-pgp-agent:x-mailer; b=Q5q9saJEFx59+RafTPQ87dn6piJ7eO9eHGuOWFJ1ZbmNibWqAJGACng1h3qLercuEK 81gTrN6s1DOVUGfbaMLyB46iyZTJDx5G8+QWkPuttckg92hWFIxgNTVvVViMpE1TNB86 D8ZDh6sFFDz3DSiVFKio1JUuuzePKxLCM+Tjw= Original-Received: by 10.224.36.91 with SMTP id s27mr3124324qad.136.1252711555812; Fri, 11 Sep 2009 16:25:55 -0700 (PDT) Original-Received: from ?192.168.1.104? (cpe-67-246-181-235.buffalo.res.rr.com [67.246.181.235]) by mx.google.com with ESMTPS id 21sm1081073qyk.0.2009.09.11.16.25.54 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 11 Sep 2009 16:25:55 -0700 (PDT) In-Reply-To: <7b501d5c0909111619y192b2dccv79a2181c82438913@mail.gmail.com> X-Pgp-Agent: GPGMail 1.2.0 (v56) X-Mailer: Apple Mail (2.936) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:115208 Archived-At: -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Good catch! Thanks. On Sep 11, 2009, at 7:19 PM, Deniz Dogan wrote: > Attached is the patch. I'm not sure about the format, but I hope it =20= > can be used. Just FYI, patch(1) can cope with emails that include a patch at the =20 end. It's usually better to include a patch inline than to attach it. =20= Doing it that way makes patches easier to discuss. This patch does the same thing yours does, but more concisely. Index: js.el =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D - --- js.el (revision 213) +++ js.el (working copy) @@ -1808,7 +1808,7 @@ (if (looking-at "[({[]\\s-*\\(/[/*]\\|$\\)") (progn (skip-syntax-backward " ") - - (when (=3D (char-before) ?\)) (backward-list)) + (when (eq (char-before) ?\)) (backward-list)) (back-to-indentation) (cond (same-indent-p (current-column)) -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Darwin) iEYEARECAAYFAkqq3H8ACgkQ17c2LVA10VualQCg43C6Egs9ie9P7CE5uVbdxG1q 2WIAoIWS3JqwJ4hes24+3jcq8r0C13M1 =3D+s+8 -----END PGP SIGNATURE-----