unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Daniel Colascione <dan.colascione@gmail.com>
To: Deniz Dogan <deniz.a.m.dogan@gmail.com>
Cc: Emacs-Devel devel <emacs-devel@gnu.org>
Subject: Re: [PATCH] espresso-mode breaks on JSON input
Date: Fri, 11 Sep 2009 19:25:51 -0400	[thread overview]
Message-ID: <B192F4C9-87FB-4FC0-B443-584B14E13839@gmail.com> (raw)
In-Reply-To: <7b501d5c0909111619y192b2dccv79a2181c82438913@mail.gmail.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Good catch! Thanks.

On Sep 11, 2009, at 7:19 PM, Deniz Dogan wrote:
> Attached is the patch. I'm not sure about the format, but I hope it  
> can be used.

Just FYI, patch(1) can cope with emails that include a patch at the  
end. It's usually better to include a patch inline than to attach it.  
Doing it that way makes patches easier to discuss.

This patch does the same thing yours does, but more concisely.

Index: js.el
===================================================================
- --- js.el	(revision 213)
+++ js.el	(working copy)
@@ -1808,7 +1808,7 @@
               (if (looking-at "[({[]\\s-*\\(/[/*]\\|$\\)")
                   (progn
                     (skip-syntax-backward " ")
- -                   (when (= (char-before) ?\)) (backward-list))
+                   (when (eq (char-before) ?\)) (backward-list))
                     (back-to-indentation)
                     (cond (same-indent-p
                            (current-column))

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Darwin)

iEYEARECAAYFAkqq3H8ACgkQ17c2LVA10VualQCg43C6Egs9ie9P7CE5uVbdxG1q
2WIAoIWS3JqwJ4hes24+3jcq8r0C13M1
=+s+8
-----END PGP SIGNATURE-----




  reply	other threads:[~2009-09-11 23:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-11 23:19 [PATCH] espresso-mode breaks on JSON input Deniz Dogan
2009-09-11 23:25 ` Daniel Colascione [this message]
2009-09-12  0:00   ` Chong Yidong
2009-09-12  4:18   ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B192F4C9-87FB-4FC0-B443-584B14E13839@gmail.com \
    --to=dan.colascione@gmail.com \
    --cc=deniz.a.m.dogan@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).