* Re: master 70477be3e3: Add treesit-sentence-type-regexp
[not found] ` <20230115211924.B4D26C00A7F@vcs2.savannah.gnu.org>
@ 2023-01-15 23:11 ` Dmitry Gutov
2023-01-16 6:04 ` Theodor Thornhill
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Gutov @ 2023-01-15 23:11 UTC (permalink / raw)
To: emacs-devel, Theodor Thornhill
On 15/01/2023 23:19, Theodor Thornhill via Mailing list for Emacs
changes wrote:
> +(defvar js--treesit-sentence-type-regexp
If the variable is called -regexp, the value should already be put
through the 'regexp-opt' call, rather than have it called inside the
major mode body.
Or we could call the vars differently.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: master 70477be3e3: Add treesit-sentence-type-regexp
2023-01-15 23:11 ` master 70477be3e3: Add treesit-sentence-type-regexp Dmitry Gutov
@ 2023-01-16 6:04 ` Theodor Thornhill
2023-01-16 11:30 ` Dmitry Gutov
0 siblings, 1 reply; 3+ messages in thread
From: Theodor Thornhill @ 2023-01-16 6:04 UTC (permalink / raw)
To: Dmitry Gutov, emacs-devel
On 16 January 2023 00:11:45 CET, Dmitry Gutov <dgutov@yandex.ru> wrote:
>On 15/01/2023 23:19, Theodor Thornhill via Mailing list for Emacs changes wrote:
>> +(defvar js--treesit-sentence-type-regexp
>
>If the variable is called -regexp, the value should already be put through the 'regexp-opt' call, rather than have it called inside the major mode body.
>
>Or we could call the vars differently.
You're right - I'll fix that. js--treesit-sentence-type-nodes?
Theo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 70477be3e3: Add treesit-sentence-type-regexp
2023-01-16 6:04 ` Theodor Thornhill
@ 2023-01-16 11:30 ` Dmitry Gutov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Gutov @ 2023-01-16 11:30 UTC (permalink / raw)
To: Theodor Thornhill, emacs-devel
On 16/01/2023 08:04, Theodor Thornhill wrote:
>
> On 16 January 2023 00:11:45 CET, Dmitry Gutov<dgutov@yandex.ru> wrote:
>> On 15/01/2023 23:19, Theodor Thornhill via Mailing list for Emacs changes wrote:
>>> +(defvar js--treesit-sentence-type-regexp
>> If the variable is called -regexp, the value should already be put through the 'regexp-opt' call, rather than have it called inside the major mode body.
>>
>> Or we could call the vars differently.
> You're right - I'll fix that. js--treesit-sentence-type-nodes?
Or js--treesit-sentence-node-types.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-16 11:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <167381756429.3910.17256789883608704168@vcs2.savannah.gnu.org>
[not found] ` <20230115211924.B4D26C00A7F@vcs2.savannah.gnu.org>
2023-01-15 23:11 ` master 70477be3e3: Add treesit-sentence-type-regexp Dmitry Gutov
2023-01-16 6:04 ` Theodor Thornhill
2023-01-16 11:30 ` Dmitry Gutov
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).