From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?Windows-1252?Q?Vincent_Bela=EFche?= Newsgroups: gmane.emacs.devel Subject: RE: SES case insensitive ses-jump git-pushed Date: Tue, 5 Apr 2022 11:53:23 +0000 Message-ID: References: <86ee2ckxux.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="_000_AS8P193MB2367EDBB00D842C9EB8FEC1D84E49AS8P193MB2367EURP_" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3809"; mail-complaints-to="usenet@ciao.gmane.io" Cc: =?Windows-1252?Q?andr=E9s_ram=EDrez?= , emacs-devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 05 13:56:01 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nbhmx-0000iE-Dn for ged-emacs-devel@m.gmane-mx.org; Tue, 05 Apr 2022 13:55:59 +0200 Original-Received: from localhost ([::1]:55518 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nbhmw-00081P-2H for ged-emacs-devel@m.gmane-mx.org; Tue, 05 Apr 2022 07:55:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49594) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbhkY-0005Nl-Jb for emacs-devel@gnu.org; Tue, 05 Apr 2022 07:53:30 -0400 Original-Received: from mail-db8eur05olkn2082.outbound.protection.outlook.com ([40.92.89.82]:55168 helo=EUR05-DB8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbhkW-0007nz-Gn for emacs-devel@gnu.org; Tue, 05 Apr 2022 07:53:30 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XQ3l9JwyFN/D+k9Id66L6oIwJsdVIm39vsgEtm6dgUqQ9m1PIjBqOz0ZhRM43Tloilr/JCHOE6sOi4gpL3KnflCoMoSIdbpFHWRCLmJ60vbGQfBcHv5+ZYws7ca1MwtPhVldVnrpKTkhVLlGbBdVuEucKRYu4qQopz4VeP/12q9jEyTApggBjwRvpiwl+HZR4STcOeqrDOIs5WHcAPb/zACvpnOg5zPzPItNJSX1a/+C0H7xq2COe7M5Enlx6gp4uP+/ARaBxsoM9HkUooXvo1InZxDcpUozxBzZ36qqxbonW7v+aQX5RPNeGdgVQf2jy5FNqNh8dDYdVjJV1CP7ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rcfdxBqHM2/Gn+kQBqgdKus52bjeTgrnvrtmV1Vp6Ko=; b=c5MLvWNNO8IjPsTTe10RQU5jm9d2quQHTZPlSSJ1aaOoN5WodG1iDjoL9yyfJfP2LMCHhmJQ3lbqyEI93sllf6ZHNuNxYawMdgqN7TQvQSqKaE4WoUHzzP6Mv71YEEyO8CAwnjtBgunUR4jISINDst8bVsQbNKrR0YN/2FlB+bEjGpujlgyM5il52c4X5d4gXnxXP3orDeVXK6e9YyE+IOaNI0LQ9Wu3ChUuwusGcBWUr0Z9q0D+4tQFEGEo9vfyYZmoT3yVCXcG4vwXt9hmJ9LS+udtTwGcUKwuzikHh8HJZUfWjAMWbtOV0rc1xFuvebpC9nClaELaI2MUwQR7sA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Original-Received: from AS8P193MB2367.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:44c::7) by AM8P193MB0929.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:1e3::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Tue, 5 Apr 2022 11:53:25 +0000 Original-Received: from AS8P193MB2367.EURP193.PROD.OUTLOOK.COM ([fe80::80c3:66b8:7ed3:e09e]) by AS8P193MB2367.EURP193.PROD.OUTLOOK.COM ([fe80::80c3:66b8:7ed3:e09e%3]) with mapi id 15.20.5123.031; Tue, 5 Apr 2022 11:53:23 +0000 Thread-Topic: SES case insensitive ses-jump git-pushed Thread-Index: AQHYSEwd1MrcbnoP3EqzwX1DC26RvazgIW4SgACJ3gCAAIhD+oAAAMorgAABKdc= In-Reply-To: Accept-Language: fr-FR, en-US Content-Language: fr-FR suggested_attachment_session_id: c12c6c78-d9aa-03ca-ce7b-cbc8adfee60c x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [vduWFM80H5UzPmK10rC+gb4VKqyhxS63] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d80fe3c1-68cd-4574-501f-08da16fae371 x-ms-traffictypediagnostic: AM8P193MB0929:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eBt2fGBWpz3GoU1rYVxUkCUFsZDB1cPMxEE1VARooUGx7ja3nvrdHLekjX+ABnju0YVJBiqpSHxZhXBxF0ddedB9RlTD2u366sS+nolNedpEdPECCp3CTQQiNLFecHLrFJaMBEnNRfZ7D6sVQaRymRdhuhMo+ijgZGNXdv1ICdEglUxaM9tCa7LRb3gJr1cqes+nz3lIzFDPi61fno+/3h5DTyY1RLlkopvUPdmxoStnC7aXuC9svMLIv2Lssh3KLTTPc7OWlHg4ZXFG/psFXEfsRf6FTWnEEcyp8aVKPbWCyYc/9GLPh18dV9E8HF3CKERFqmn6frNn1Y9D2InJ1m9xOS9rU3A4rv5eTkS9TykBfA1d3yLnIb/EHRxuRdP/7rU7dakJEqe66g08sLjjQApNgDyOOLD5m91+GAJc1Hgr8DlUtZsTUy335X3bcRWEHMFPPBdEXjRnPlrgSjEThFqeTcw5YwOseweglV3ypzv6mETz/XOzc79+D2DF01Y5/fi1/tjpqB/m9lwnvA/+VYftYWxkOBbm9aX+hzPZ7wZLdIBYmW5q/v9zJ593LUhT9HKO2b8CRj36MAXiwSomXA== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?sL0uv0ChYQfBixz9VdUzepzQKXoCylr4j2QrVSsp8cIe74jFC8uoZcwP?= =?Windows-1252?Q?iHxBeCSxMoN+0MAjKGovhN454Szb3SDWBz7wj54ZIHDmzyWHRtI0vgo+?= =?Windows-1252?Q?fjKHMCbR2Yd3rS2RJxXj4Oj1MhnGk3x4hBamwd7ar5YPWgOPbCilhjZ9?= =?Windows-1252?Q?iXlHcGMpBhynMJd6tLIVy+89Nh5fpe94HpztOh7zkeu7lfKABcaTtZUA?= =?Windows-1252?Q?Pype88QHS4ipu5G7WlmU6UoCAvgEvtD1Ej2DwkwcJDGtS0EQyBjkYnEE?= =?Windows-1252?Q?TVO+EGxqO5vgY5ehZGU1vVOtTcVCi1ySu5o6702Q2Mz8oUAhpdD16mAV?= =?Windows-1252?Q?/CSNhCTlj8C1CuZ5QY7Ylh9rwFHObmHaSa9HP7IVN9Rpiataauc0tS4j?= =?Windows-1252?Q?tIPLaa6Gfali4XaGTCDg+TUyNDjmiV86FIVMBeAZxj0U4IPoaT8Y2/8U?= =?Windows-1252?Q?46hp6OJXvQ6DHE1jQrBf+TXrkd88IUpu6gC0gMXAdG4wh8BSMGs+90Pw?= =?Windows-1252?Q?O3QDMYquo6NdRS6j2VqluNuDw1P/rYq0RQKi3g/g/qDMJFh34ufFg+Qs?= =?Windows-1252?Q?U4yYJM+IuUFboByIMwVmAaoq3s5FSTUjQNyVE9rLmx+1I0f3DVh//tCW?= =?Windows-1252? X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-80ceb.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS8P193MB2367.EURP193.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: d80fe3c1-68cd-4574-501f-08da16fae371 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Apr 2022 11:53:23.9523 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P193MB0929 Received-SPF: pass client-ip=40.92.89.82; envelope-from=vincent.b.1@hotmail.fr; helo=EUR05-DB8-obe.outbound.protection.outlook.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287810 Archived-At: --_000_AS8P193MB2367EDBB00D842C9EB8FEC1D84E49AS8P193MB2367EURP_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable The problem might be due to this that I have several (defvar =85) in the ses-test.el, I probably added this in order to avoid some bytecompile errors, plus somebody has added the cookie -*- lexical-binding: t; -*- to the ses-test.el file. SES uses buffer local variables for the cell symbols, so the interned symbols referring to cells are per se dynamically / not lexically, bound. I suspect that the addition of the -*- lexical-binding: t; -*- cookies is the root cause of the test being erroneous. If we need that cooky, then I need another way to declare the cell symbols, maybe declaring them in an encapsulating (let (=85) =85) statement and removing the (defvar =85) wo= uld solve the issue. V. ________________________________ De : Vincent Bela=EFche Envoy=E9 : mardi 5 avril 2022 13:46 =C0 : Stefan Monnier Cc : emacs-devel ; andr=E9s ram=EDrez Objet : RE: SES case insensitive ses-jump git-pushed To be fully honest, if I M-x ert-run-tests-interactively a second time, then I get this: --------8<-----------8<-----------8<-----------8<-----------8<------- Selector: t Passed: 11 Failed: 2 (2 unexpected) Skipped: 0 Total: 13/13 Started at: 2022-04-05 13:44:31+0200 Finished. Finished at: 2022-04-05 13:44:31+0200 ..........FF. F ses-tests-renamed-cell-after-setting Check that setting A1 to 1 and A2 to (1+ A1), and then (ert-test-failed ((should (eq (bound-and-true-p A2) 2)) :form (eq *error* 2) :value nil)) F ses-tests-renamed-cells-row-insertion Check that setting A1 to 1 and A2 to (1+ A1), and then renaming A1 to = =91ses--foo=92 and A2 to =91ses--bar=92 jumping (ert-test-failed ((should (eq ses--bar 2)) :form (eq *error* 2) :value nil)) --------8<-----------8<-----------8<-----------8<-----------8<------- It seems that the new tests are maybe not to blame, but that my existing tests were wrong, as if there is some border effect remaining after the tests have run, and spoiling a new test run. V. ________________________________ De : Vincent Bela=EFche Envoy=E9 : mardi 5 avril 2022 13:43 =C0 : Stefan Monnier Cc : emacs-devel ; andr=E9s ram=EDrez Objet : RE: SES case insensitive ses-jump git-pushed Salut Stefan, When I eval-buffer on ses-test.el, and then when I do M-x ert-run-tests-interactively I get no error, the output in *ert* buffer is as follows: --------8<-----------8<-----------8<-----------8<-----------8<------- Selector: t Passed: 13 Failed: 0 Skipped: 0 Total: 13/13 Started at: 2022-04-05 13:41:09+0200 Finished. Finished at: 2022-04-05 13:41:09+0200 ............. --------8<-----------8<-----------8<-----------8<-----------8<------- V. ________________________________ De : andr=E9s ram=EDrez Envoy=E9 : mardi 5 avril 2022 05:33 =C0 : Stefan Monnier Cc : Vincent Bela=EFche ; emacs-devel Objet : Re: SES case insensitive ses-jump git-pushed >>>>> "Stefan" =3D=3D Stefan Monnier writes: [...] Stefan> I also see an error when I run `make test/lisp/ses-tests`. --_000_AS8P193MB2367EDBB00D842C9EB8FEC1D84E49AS8P193MB2367EURP_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable
The problem might be due to this that I have several (defvar =85) in the
ses-test.el, I probably added this in order to avoid some bytecompile<= /div>
errors, plus somebody has added the cookie -*- lexical-binding: t; -*-=
to the ses-test.el file.

SES uses buffer local variables for the cell symbols, so the interned<= /div>
symbols referring to cells are per se dynamically / not lexically,
bound.

I suspect that the addition of the -*- lexical-binding: t; -*- cookies= is
the root cause of the test being erroneous. If we need that cooky, the= n
I need another way to declare the cell symbols, maybe declaring them i= n
an encapsulating (let (=85) =85) statement and removing the (defvar = =85) would
solve the issue.

  V.
De : Vincent Bela=EFche <= ;vincent.b.1@hotmail.fr>
Envoy=E9 : mardi 5 avril 2022 13:46
=C0 : Stefan Monnier <monnier@iro.umontreal.ca>
Cc : emacs-devel <emacs-devel@gnu.org>; andr=E9s ram=EDre= z <rrandresf@gmail.com>
Objet : RE: SES case insensitive ses-jump git-pushed
 
To be fully honest, if I M-x ert-run-tests-interactively a second time,
then I get this:

--------8<-----------8<-----------8<-----------8<---------= --8<-------
Selector: t
Passed:  11
Failed:  2 (2 unexpected)
Skipped: 0
Total:   13/13

Started at:   2022-04-05 13:44:31+0200
Finished.
Finished at:  2022-04-05 13:44:31+0200

..........FF.

F ses-tests-renamed-cell-after-setting
    Check that setting A1 to 1 and A2 to (1+ A1), and then
    (ert-test-failed
     ((should
       (eq
(bound-and-true-p A2)
2))
      :form
      (eq *error* 2)
      :value nil))

F ses-tests-renamed-cells-row-insertion
    Check that setting A1 to 1 and A2 to (1+ A1), and then r= enaming A1 to =91ses--foo=92 and A2 to =91ses--bar=92 jumping
    (ert-test-failed
     ((should
       (eq ses--bar 2))
      :form
      (eq *error* 2)
      :value nil))
--------8<-----------8<-----------8<-----------8<---------= --8<-------

It seems that the new tests are maybe not to blame, but that my existi= ng
tests were wrong, as if there is some border effect remaining after th= e
tests have run, and spoiling a new test run.

  V.
De : Vincent Bela=EFche &= lt;vincent.b.1@hotmail.fr>
Envoy=E9 : mardi 5 avril 2022 13:43
=C0 : Stefan Monnier <monnier@iro.umontreal.ca>
Cc : emacs-devel <emacs-devel@gnu.org>; andr=E9s ram=EDre= z <rrandresf@gmail.com>
Objet : RE: SES case insensitive ses-jump git-pushed
 
Salut Stefan,

When I eval-buffer on ses-test.el, and then when I do M-x
ert-run-tests-interactively I get no error, the output in *ert* buffer=
is as follows:

--------8<-----------8<-----------8<-----------8<---------= --8<-------
Selector: t
Passed:  13
Failed:  0
Skipped: 0
Total:   13/13

Started at:   2022-04-05 13:41:09+0200
Finished.
Finished at:  2022-04-05 13:41:09+0200

.............
--------8<-----------8<-----------8<-----------8<---------= --8<-------

  V.
De : andr=E9s ram=EDrez= <rrandresf@gmail.com>
Envoy=E9 : mardi 5 avril 2022 05:33
=C0 : Stefan Monnier <monnier@iro.umontreal.ca>
Cc : Vincent Bela=EFche <vincent.b.1@hotmail.fr>; emacs-d= evel <emacs-devel@gnu.org>
Objet : Re: SES case insensitive ses-jump git-pushed
 
>>>>> "Stefan" =3D=3D= Stefan Monnier <monnier@iro.umontreal.ca> writes:


[...]


    Stefan> I also see an error when I run `make test/lis= p/ses-tests`.
   
--_000_AS8P193MB2367EDBB00D842C9EB8FEC1D84E49AS8P193MB2367EURP_--