From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Cyril Arnould Newsgroups: gmane.emacs.devel Subject: AW: AW: emacs-29 a2d4cd06f45: Improve VHDL mode highlighting Date: Tue, 9 May 2023 15:48:35 +0000 Message-ID: References: <168326553347.14898.7329669431232347477@vcs2.savannah.gnu.org> <20230505054533.D680AC1BECD@vcs2.savannah.gnu.org> <87mt2e9c0e.fsf@gmx.de> <83h6slc438.fsf@gnu.org> <8c364116-0eb7-daef-536e-ae992071464d@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="_000_AS4PR10MB61103F21CB2E835E1181F66DE3769AS4PR10MB6110EURP_" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35348"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "emacs-devel@gnu.org" To: Reto Zimmermann , Eli Zaretskii , Michael Albinus , =?iso-8859-1?Q?Mattias_Engdeg=E5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 09 18:05:37 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pwPqJ-0008tr-FP for ged-emacs-devel@m.gmane-mx.org; Tue, 09 May 2023 18:05:35 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pwPpe-0001qF-HA; Tue, 09 May 2023 12:04:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwPa0-0002iA-5Z for emacs-devel@gnu.org; Tue, 09 May 2023 11:48:44 -0400 Original-Received: from mail-vi1eur05olkn2058.outbound.protection.outlook.com ([40.92.90.58] helo=EUR05-VI1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwPZx-0006e0-18; Tue, 09 May 2023 11:48:43 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cNVcSzT9OOS3sCVfDWwd8taCtjYIlBttEqBHmrssDhK2DBo/g1eJvQ7UG+N0ieg2bEJgYu4CW3yhb6OKvPJVFN7eupDJQE8arj6J7gjujkewYu16KnVsyPL1QhMaTwvpci0dOZe8/O8crDTAwiMiuu7vprFgBJ0gV6L2rynw4zT+UdTugPKfKNfLdDIZ6cOPaaKyq/xa6cFIfEDZXCDQc7F3CmvwUqX9GzJTmFA0db/VA4zDryn9cAZ8r1327gDI6S81Zb5N4Xg8MvxjZ0t5tM7vhoTWjW48KR9YKOeTyCHSugz2dr07ynKpV49rfq4fLPYGN6IY+nAcVIcCmTUSsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7RawZvC6iAeXni9vF9Em5le8e3Us2OoHsalLtBfm+p4=; b=U/7bzVMRInJ3M8diry+D8tozZudnyYjvJ703BzzHgvNNbd4w3mOhq2z1DVuAEBhK1jVzTPsaQmfWlMIoQ9XyqTQmWscdCR0aAeixmo0fyQ0N/6CEHl21mw9TCTFjfwQZUs68Q5gtIhuu2ynpKKnnOFFxexaCQxnSMmkJaKcj23XKqff2UyWtznM66ZLHJtyJGR/ITCRNfOAKbP6MtpkXT6cRJ5xtTwEyN5vdYPmvnDzcLVxgCQ1nBqZePxWB3EEtczKkKvbgHd38SvXWFgUllTNqRNLXSz58MYz0df9yMv9F7X1AbWAZFMCIdqPwCeRVNjUpHxFLYrvaJSoJ5UkkvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7RawZvC6iAeXni9vF9Em5le8e3Us2OoHsalLtBfm+p4=; b=vOy2A9G7A59fNYduIy46VwcJ/fG6+BvmFVJ3XPU9Fvy2/H+yVPSRcCq7glqsdK9leHKwHjoxpqyDJfNh6wGn8yIvJMkoMC4SiiwMJzyoC9W49XPRFPs0Sfxg+EzoTRtLpLYUVDVff7xHYF5fSYpvaUo20AMmgUTJdSi5W35i5ZzoOU4q5VwY7VtmDyEK/luDe9ILbRFoFwgtLZWccasnKi3Cq/sMUS+Nc5Kencv+3FU0QMx6sm7vtfnC7bjZbFE30OUGyV9fWReEmon6fWBaZlPEpno3XLW5GH3UEhSrCxSTaZ0ANHsbXc5wm54anYFiP6WEJUxB4LLW1IdK6nSpFg== Original-Received: from AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:582::17) by DU0PR10MB6559.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:404::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Tue, 9 May 2023 15:48:35 +0000 Original-Received: from AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM ([fe80::18ab:4656:4a13:e7e1]) by AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM ([fe80::18ab:4656:4a13:e7e1%7]) with mapi id 15.20.6363.033; Tue, 9 May 2023 15:48:35 +0000 Thread-Topic: AW: emacs-29 a2d4cd06f45: Improve VHDL mode highlighting Thread-Index: AQHZgktVd1JJAYcKTUGvrY2L9gaaYK9RmDjygAA1s3SAADUpAIAAERKU In-Reply-To: <8c364116-0eb7-daef-536e-ae992071464d@gnu.org> Accept-Language: de-CH, en-US Content-Language: de-CH x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [7O7pSGgshxnMWxKU7RSW+fux+tnEj6bF] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AS4PR10MB6110:EE_|DU0PR10MB6559:EE_ x-ms-office365-filtering-correlation-id: 87489bcb-d177-4548-e1ee-08db50a4d92d x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SxcqsecZ44hpBwovJgAy2SDYB21ZfTuFl5Qy9JxsxcDAjcDEwbx8n1uc/xdvms/X+1eFoJtyWs+3MGp9Sz5q1SrTaL6n4RjQoq5BiJXX+xcyFeKPzlDyDogfqRqTc8Lts1a00VIBJTMPJYDOuaL3FKt0h3dahbcTMHSyC+I4rH9z1dyYOkQQc2NxskMqjwK3ITRRnqtgVKNbyVrB01XWDhZtj74FdkGVs0k0O6VcWgCxIagDeZNEIX40YAx01OUSyoL7Q3Qj0qsv05EJgwumwVUVUKgcgC2T4SwZ2Nu7I21hUafQuUP7ZJap/YjnGD9ETYyLHxxPi7hkSX05RcwmTtth2e93eXe5UKy9M0bgx/sGxfJZlv9KNjPL0UG342qYJBrln8Yi+H4i8B3eolWNenP6MsvGRnH8otwt4QFs9hBJV5R3zyTK+vI6NsIWalwTHpN7MJE7nN+Ie3X8rsOqZJoa4abjEoL/j9ndkTymy8z3gnR7GyKPLesWe0WlKIYCxA3SVruoQ36aj5pTDZd2ilZYXaF000ytqZq39snlkuSahUgseVxpOseh9zDB3Ilm x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?JW4ElkjvJPtcad0Dy2Xj6oBwh10ZFqDOfOGfi0NCXzY2ebKehCfhygN0N9?= =?iso-8859-1?Q?M5nZKtpmpIZXRLmpbUbrDRglUFEoh5IvKWVj286e9OmbLYighe9RujS9bl?= =?iso-8859-1?Q?OnAo1zGckbWjILmQ8JKy7/5qqxG49mp/oIL4vzMtI12kAGSkEGtRSHVvir?= =?iso-8859-1?Q?s2EvCtW1J7m48ZFWm/uU6JGTGMnNvQaigkhY2OqUHU5u0iZbbh1zrljCFH?= =?iso-8859-1?Q?bpsiOC5QNDlGzWuCJfDZDljPlBNHFyedARAw+IqAzwMcDMlWqtIeMeD/Nf?= =?iso-8859-1?Q?axyzPay5U+xOAFpWs3j1m0dku7a2bvg2krR9H4X6U4nCHrHcyBN6jsgUGE?= =?iso-8859-1?Q?vriS6wF+QDJAsjLiyJJsK0xxsZN5pU7RzOXQuApCvVrWE4X69BdHqp9AaH?= =?iso-8859-1?Q?rkM1iLlr25hY/8oKdqOmVkOlwjjW9wwddgIKpQpupmCg6cHUMl6QPavwzB?= =?iso-8859-1?Q?cubZSRld/YT76XO8J/I2bEt9qGxtPQieCSchB+46Ab+NZdj/KO14Bw1i54?= =?iso-8859-1?Q?OKBGL2K/3Z/dUGH307nfTaCFc8+eFpy0wEAntAJIQtMT17XXqkGQbwHbpX?= =?iso-8859-1?Q?1LMQqHVS5EJYhDgJLfnUfcSpjKbX3xiIjsKamkpyVPWhJnDYJqFeGRaxto?= =?iso-8859-1?Q? X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 87489bcb-d177-4548-e1ee-08db50a4d92d X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2023 15:48:35.1385 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR10MB6559 Received-SPF: pass client-ip=40.92.90.58; envelope-from=cyril.arnould@outlook.com; helo=EUR05-VI1-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 09 May 2023 12:04:52 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306008 Archived-At: --_000_AS4PR10MB61103F21CB2E835E1181F66DE3769AS4PR10MB6110EURP_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable > So I would suggest to release your changes under 3.38.5. Will do. > I'm not sure why backwards compatibility code is needed here. I hadn't considered that. If we define Error to be 2 in the type, the compatibility code *is* needed not to break the customization menu with previously saved customizations. If we define it as nil though, saved customizations appear normal in the menu. So I will update the patch with Error to be nil exclusively and forego the backwards compatibility code. Thanks! Von: Reto Zimmermann Gesendet: Dienstag, 9. Mai 2023 16:38 An: Cyril Arnould; Eli Zaretskii; Michael Albinus; Mattias Engde= g=E5rd Cc: emacs-devel@gnu.org Betreff: Re: AW: emacs-29 a2d4cd06f45: Improve VHDL mode highlighting On 2023-05-09 13:51, Cyril Arnould wrote: > Cyril, are you done discussing this, or do I need to wait some more? I was actually hoping to get Reto's and/or your input on two points, the first one being: > Since this introduces changes in the vhdl-compiler type, I guess > it would be appropriate to increment the vhdl-version number? I've seen that on Reto's website, the latest vhdl-version number is 3.38.4, while in the emacs repository it's at 3.38.1. I'm not sure if this is intentional or if it simply hasn't been tracked in emacs. If development is not intended to diverge, we could skip ahead to 3.38.5 or 3.39.1. Development has already diverged. I have in the meantime fixed numerous in= dentation bugs and added support for VHDL'18, among other changes. I know = this is not ideal, but I was not able to approve of all the changes that ha= ve been made on Emacs side some time ago, without sufficient testing. I'm = in the process of integrating most of these changes in my code though. I w= ill also release 3.39.1 myself soon. So I would suggest to release your changes under 3.38.5. The second point is that we now have two solutions for backwards compatibility code. There's my original solution which is a slight modification of already established backwards compatibility code. Alternatively, there's the solution elaborated with Mattias which should be safer but is less tested. If using a more "experimental" solution is no problem then we can go ahead with the new approach. I'm not sure why backwards compatibility code is needed here. The only cha= nge here is that an additional element (cons) is added to a sub-list, which= however can be nil when no warning/info syntax is present. On my side it = works without compatibility code. Reto --_000_AS4PR10MB61103F21CB2E835E1181F66DE3769AS4PR10MB6110EURP_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable

> So I would suggest to release your changes unde= r 3.38.5.

 

Will do.

 

> I'm not sure why backwards compatibility code i= s needed here.

 

I hadn't considered that. If we define Error to be 2= in the type,

the compatibility code *is* needed not to break the = customization

menu with previously saved customizations. If we def= ine it as nil

though, saved customizations appear normal in the me= nu. So I will

update the patch with Error to be nil exclusively an= d forego the

backwards compatibility code. Thanks!

 

 

Von: Reto Zimmermann
Gesendet: Dienstag, 9. Mai 2023 16:38
An: Cyril Arnould; = Eli Zaretskii; Michael Albinu= s; Mattias Engdeg=E5rd
Cc: emacs-devel@gnu.org Betreff: Re: AW: emacs-29 a2d4cd06f45: Improve VHDL mode highlightin= g

 

On 2023-05-09 13:51, Cyril Arnould wrote:

> Cyril, are you done discussing this, or do I ne= ed to wait some more?

 

I was actually hoping to get Reto's and/or your inpu= t on two

points, the first one being:

 

> Since this introduces changes in the vhdl-compi= ler type, I guess

> it would be appropriate to increment the vhdl-v= ersion number?

 

I've seen that on Reto's website, the latest vhdl-ve= rsion number

is 3.38.4, while in the emacs repository it's at 3.3= 8.1. I'm not

sure if this is intentional or if it simply hasn't b= een tracked

in emacs. If development is not intended to diverge,= we could

skip ahead to 3.38.5 or 3.39.1.


Development has already diverged.  I have in the meantime fixed numero= us indentation bugs and added support for VHDL'18, among other changes.&nbs= p; I know this is not ideal, but I was not able to approve of all the chang= es that have been made on Emacs side some time ago, without sufficient testing.  I'm in the process of integrat= ing most of these changes in my code though.  I will also release 3.39= .1 myself soon.

So I would suggest to release your changes under 3.38.5.


The second point is that we now have two solutions f= or backwards

compatibility code. There's my original solution whi= ch is a

slight modification of already established backwards=

compatibility code. Alternatively, there's the solut= ion

elaborated with Mattias which should be safer but is= less

tested. If using a more "experimental" sol= ution is no problem

then we can go ahead with the new approach.


I'm not sure why backwards compatibility code is needed here.  The onl= y change here is that an additional element (cons) is added to a sub-list, = which however can be nil when no warning/info syntax is present.  On m= y side it works without compatibility code.

Reto

 =

--_000_AS4PR10MB61103F21CB2E835E1181F66DE3769AS4PR10MB6110EURP_--