Andrea Corallo writes: > Arthur Miller writes: > >> Andrea Corallo writes: >> >>> Eli Zaretskii writes: >>> >>>>> From: Andrea Corallo >>>>> Cc: Arthur Miller , emacs-devel@gnu.org >>>>> Date: Mon, 30 Aug 2021 12:59:45 +0000 >>>>> >>>>> I think this "defined (WINDOWSNT)" should be there so that compiling on >>>>> Windows the check over "gcc_jit_context_add_command_line_option" it is >>>>> always compiled even in case the libgccjit.h provided at compile time >>>>> does not define >>>>> 'LIBGCCJIT_HAVE_gcc_jit_context_add_command_line_option'. >>>>> >>>>> A newer version of the shared library including the entry point might be >>>>> provided later on and will be used at runtime. >>>> >>>> You cannot use a libgccjit.dll of a version for which Emacs was not >>>> compiled, unless it is binary-compatible. If Emacs was linked against >>>> libgccjit.dll that didn't support >>>> gcc_jit_context_add_command_line_option, then it would not work to >>>> install a newer version of the DLL that does. >>> >>> Okay, I thought on Windows worked differently and we could handle the >>> case of a symbol not available at compile time but at runtime. In the >>> light of this we can probably perform some more clean-up. >> >> So does that mean that windows check is not needed in add_driver_options as well? > > AFAIR that was the reason for that check so yes. > > Andrea Ok, I have made those changes. I have removed double checks from both add_driver_options () and add_compiler_options (). If it is not OK, I can made another one and revert back this change in add_driver_options. I have also renamed native-comp-driver-options to native-comp-backend-options. I forgott to ask, which Changelog are we talking about? Changelo.3 in top Emacs dir or some other file?