From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Arthur Miller Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Lazy wdired preprocessing Date: Fri, 26 Mar 2021 13:21:53 +0100 Message-ID: References: <87wntuzv7m.fsf@web.de> <87h7kyh9w7.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30070"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Michael Heerdegen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 26 13:23:39 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lPlV5-0007kA-2H for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Mar 2021 13:23:39 +0100 Original-Received: from localhost ([::1]:47728 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPlV4-0003mn-49 for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Mar 2021 08:23:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53452) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPlTX-0003F7-Hs for emacs-devel@gnu.org; Fri, 26 Mar 2021 08:22:04 -0400 Original-Received: from mail-oln040092074056.outbound.protection.outlook.com ([40.92.74.56]:46309 helo=EUR04-DB3-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPlTR-00046w-F8 for emacs-devel@gnu.org; Fri, 26 Mar 2021 08:22:02 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PZf+c1SsghL/f2MEaMbJex3ob6JJ8tmyfXWHLy9B+qQ6x6VmMnakD7hTGCZhO6LQe+pZYUCH/TE7sJKaBD2TmC//5byuAc/sL2VF1MH6NAisddXzMAmBJUWokJMV0UOnsyZ8wxXIx5wpLy4FE0GsktH9crOEdJkYBc3JatZolWm7SpJJ7WspGMOGrkQppwJiGV5XF/eXB0bHQuv7vS2/0y2Aayj7UMxQVeLBaoN+KIQ/kGn2qWsPUPIcYxOUDKGy6QdepW13NvN0vjtBTwAhqEMBgXL7OyUd+X1NzuUkr7793nD3zu2lOi9McQNxmFSjtnuoKkw6CVdWS1W8FaWZvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FQ+5/M1Kd1YI7GwSFou0Hfg2XhMenoRBNn5DsOC6t90=; b=Vrm1v125EUs6WJLuQdXuvnog8lWUWxf9iV5HxU97x+aBhjt8wGNjfB3cQ5WTY44QI7BUKxOWy3wiWNhBMS+tzts9gMjjXx1jnYwg46uKBN6s2FMauyT4IOaZutCG0gJmcejqmQQd1VZJ5zW/UVqflFFZR7usRlZM7f/0OBa280y0HybbkUMO9PvGPrXgxKSKcwzEIVfsLtItIBogPbqrnBBJM9LBiR+4QonwjZs9Lau0c8HKqseFfRJii/qGpCbpxJH1hTOf0gHU6yEJpwRV/8vH3UqUawS0t4qrYCAmDJhFwiTlyGY3ipIOgFkKF+jL6itvft+3tMB3DtpjSYLJBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FQ+5/M1Kd1YI7GwSFou0Hfg2XhMenoRBNn5DsOC6t90=; b=MrxhP+qAdb6RNm3hRgsxRwQdRowvuKZS/ovsaxniu191CI/u4hwTR5gztLAVLr2ukffFSULQAhcm+BvcgqwZk1gmik93QYFZKALlqprPfGMT45/rHo6hGRDGmESsloddtjiupu85EuWurVprzJVXttr8GHCh2uxWTaHXOEQIPc6voNTZsOR9K0vDzmvwO6Zi8sAPojZLyNcsO1FG707xTA1CTcxhOe4DnAKO9kpNeFuZNCTE7rzybc4LU2rvohiQiLYBI5U42D376gPORkzSTkuuL1jkkZAHsDpGfM41MRNWUijnbd45sAIOAWWRQobw70jAdpGfm4411YqZmKCajQ== Original-Received: from VI1EUR04FT005.eop-eur04.prod.protection.outlook.com (2a01:111:e400:7e0e::46) by VI1EUR04HT175.eop-eur04.prod.protection.outlook.com (2a01:111:e400:7e0e::335) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.29; Fri, 26 Mar 2021 12:21:54 +0000 Original-Received: from AM9PR09MB4977.eurprd09.prod.outlook.com (2a01:111:e400:7e0e::4c) by VI1EUR04FT005.mail.protection.outlook.com (2a01:111:e400:7e0e::65) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25 via Frontend Transport; Fri, 26 Mar 2021 12:21:54 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:B567BC4FEF652B10F31C5D8D3D174250A1517C1CECB0CCBC24A562E8D24216F0; UpperCasedChecksum:8EA141F6CA748DA46BE217A1D86E51734B16C015ED89451B45A0F284EE3CC955; SizeAsReceived:7560; Count:46 Original-Received: from AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::2103:e705:bc0c:5a8b]) by AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::2103:e705:bc0c:5a8b%6]) with mapi id 15.20.3977.025; Fri, 26 Mar 2021 12:21:53 +0000 In-Reply-To: <87h7kyh9w7.fsf@web.de> (Michael Heerdegen's message of "Fri, 26 Mar 2021 04:27:36 +0100") X-TMN: [lKVUQWfkVtxuIgdIU6LPOKQk22E0E4Kv] X-ClientProxiedBy: AM6P193CA0090.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:88::31) To AM9PR09MB4977.eurprd09.prod.outlook.com (2603:10a6:20b:304::20) X-Microsoft-Original-Message-ID: <87sg4iksv2.fsf@live.com> X-MS-Exchange-MessageSentRepresentingType: 1 Original-Received: from pascal.homepc (90.230.29.56) by AM6P193CA0090.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:88::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25 via Frontend Transport; Fri, 26 Mar 2021 12:21:53 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 46 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 8015c266-a09d-4ec1-0d48-08d8f051bd93 X-MS-TrafficTypeDiagnostic: VI1EUR04HT175: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WW653AtJDP6QMrNI4rri5JIO8nqKu6+IYRReJ+A1LmCWd6EO1LNn6qQ6c06k+gQo2lwEKmYq8ftA6TB8yayZHHzpi/xpZEvRWxmb5Ww6oTAZ7Vg5BveUQ4TMJR10kC6yH58bk4J7+u2q33a9e8ncJHC/gCSnR27lAtOP2skC0SdWCQB/zLbQkCSTjlDMx7RsukwkQit2jBM+ClphmiI4tcFMLSoOf19dxJtGgnu03ZHaLp1h/KIlBvWhMumgUnlGgZPm6mj9olw2oOsOYGeiVIXDbPR6shbWKIZU0+dlwXuMUPRNvSxaP96R0Qrh7njR5DBxP9KzaBfW5KPv+7A9Mmu3CygG+6de5Tl9xctIBpo4xxSkSeaCBdCNulpjcerxNzJXmPcqBx0ku/5ADQDCaA== X-MS-Exchange-AntiSpam-MessageData: cqdDf+ICXkCpzE7YZPSlhTZBR8wt8W9GF/bqUfigMV0+BRJJlTHn3hmsqn/Y884rlKwnpgQ6VgmNxkjHyBjvn30E0yJY4FBKX1bRy7EEPvVsLCoC036EU119jjAhsGptJEes1dHLiwFJSaPjoz2+yg== X-OriginatorOrg: live.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8015c266-a09d-4ec1-0d48-08d8f051bd93 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2021 12:21:53.8862 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: VI1EUR04FT005.eop-eur04.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1EUR04HT175 Received-SPF: pass client-ip=40.92.74.56; envelope-from=arthur.miller@live.com; helo=EUR04-DB3-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267066 Archived-At: Michael Heerdegen writes: > Arthur Miller writes: > >> This was re-implementation of parts of wdired to make it more efficient >> and faster to enter the wdired mode. > > Ok, thanks for the elaboration. Didn't try it yet, but I welcome this > change. So far I have one question: > > + ;; find one column with permissions and set permision text boundaries > + (save-excursion > + (goto-char (point-min)) > + (unless (re-search-forward dired-re-perms nil t 1) > + (wdired-abort-changes) > + (error "No files to be renamed - Exiting to Dired mode.")) > + (goto-char (match-beginning 0)) > + (setq-local wdired-perm-beg (current-column)) > + (goto-char (match-end 0)) > + (setq-local wdired-perm-end (current-column))) > > Did you check that this works when `dired-hide-details-mode' is enabled? > I ask because AFAIK `current-column' doesn't count invisible characters. > [It might be better to just count characters from the line's beginning, > but I see that the existing code also uses `current-column'.] I just tested bit more. Once wdired is entered with hidden details, one can not switch deatils on normally since dired-hide-details-mode checks if it is in dired-mode.