From: Arthur Miller <arthur.miller@live.com>
To: Juri Linkov <juri@linkov.net>
Cc: emacs-devel@gnu.org
Subject: Re: Info-mode patch
Date: Mon, 26 Jun 2023 22:17:26 +0200 [thread overview]
Message-ID: <AM9PR09MB497770FC5320657A85BCB70A9626A@AM9PR09MB4977.eurprd09.prod.outlook.com> (raw)
In-Reply-To: <86fs6ertto.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 26 Jun 2023 20:56:19 +0300")
Juri Linkov <juri@linkov.net> writes:
>> -(defun Info-directory ()
>> +(defun Info-directory (&optional window)
>> "Go to the Info directory node."
>> (interactive)
>> - (Info-find-node "dir" "top"))
>> + (with-selected-window (or window (info-window))
>> + (Info-find-node "dir" "top")))
>
> I wonder why you modified a lot of commands instead of implementing
> a non-intrusive approach of creating standard wrapper commands like
>
> (defun Info-directory-other-window (&optional window)
> "Go to the Info directory node in another window."
> (interactive)
> (with-selected-window (or window (info-window))
> (Info-directory)))
Can you control on which frame the input goes when prompted by original
function with a wrapper approach? I changed quite few prompts a wrapped stuff
with both with-current-buffer, and with-selected-frame to achive that. I don't
think I could do that if I wrapped stuff. But what do I know, perhaps there is
some way?
Also I didn't wanted to change API. Not that I believe that there are many 3rd
party packages for Info and Help modes, and that people actually customize
those, but anyway. Wrappers would be a new API, which all require at least some
documentation etc.
next prev parent reply other threads:[~2023-06-26 20:17 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 16:09 Info-mode patch Arthur Miller
2023-06-26 17:56 ` Juri Linkov
2023-06-26 20:17 ` Arthur Miller [this message]
2023-06-27 6:32 ` Juri Linkov
2023-06-27 7:54 ` Arthur Miller
2023-06-27 18:11 ` Juri Linkov
2023-06-27 23:09 ` Arthur Miller
2023-06-28 6:50 ` Juri Linkov
2023-06-28 21:52 ` Arthur Miller
2023-06-29 6:44 ` Juri Linkov
2023-06-29 12:42 ` Arthur Miller
2023-06-29 15:00 ` [External] : " Drew Adams
2023-06-29 16:24 ` Arthur Miller
2023-06-29 17:44 ` Juri Linkov
2023-06-29 22:28 ` Arthur Miller
2023-06-30 7:13 ` Juri Linkov
2023-06-30 8:41 ` Arthur Miller
2023-06-30 17:57 ` Juri Linkov
2023-07-01 9:11 ` Arthur Miller
2023-07-02 17:53 ` Juri Linkov
2023-07-02 18:39 ` Eli Zaretskii
2023-07-02 22:43 ` Arthur Miller
2023-07-03 11:46 ` Eli Zaretskii
2023-07-03 12:57 ` Arthur Miller
2023-07-03 13:17 ` Eli Zaretskii
2023-07-03 18:40 ` Juri Linkov
2023-07-03 18:57 ` Eli Zaretskii
2023-07-04 6:50 ` easy-menu-define keys for key-valid-p (was: Info-mode patch) Juri Linkov
2023-07-04 11:33 ` Eli Zaretskii
2023-07-03 21:07 ` Info-mode patch Arthur Miller
2023-07-04 7:59 ` Andreas Schwab
2023-07-04 8:44 ` Arthur Miller
2023-07-03 17:07 ` Eli Zaretskii
2023-07-04 23:58 ` Stefan Monnier
2023-07-08 8:14 ` Eli Zaretskii
2023-07-02 22:05 ` Arthur Miller
2023-07-03 18:45 ` Juri Linkov
2023-07-03 22:24 ` Arthur Miller
2023-07-04 6:54 ` Juri Linkov
2023-07-04 9:43 ` Arthur Miller
2023-07-04 17:51 ` Juri Linkov
2023-07-04 21:40 ` Arthur Miller
2023-07-05 6:17 ` Juri Linkov
2023-07-05 14:25 ` Arthur Miller
2023-07-01 9:59 ` Getting Gnus to highlight citations in long mails (was: Info-mode patch) Kévin Le Gouguec
2023-07-01 12:40 ` Getting Gnus to highlight citations in long mails Arthur Miller
2023-07-02 17:56 ` Juri Linkov
2023-06-27 11:45 ` Info-mode patch Eli Zaretskii
2023-06-27 12:15 ` Arthur Miller
2023-06-27 12:42 ` Eli Zaretskii
2023-06-27 15:28 ` Arthur Miller
2023-06-27 16:03 ` Eli Zaretskii
2023-06-27 16:33 ` Arthur Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM9PR09MB497770FC5320657A85BCB70A9626A@AM9PR09MB4977.eurprd09.prod.outlook.com \
--to=arthur.miller@live.com \
--cc=emacs-devel@gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).