From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Arthur Miller Newsgroups: gmane.emacs.devel Subject: Re: Info-mode patch Date: Mon, 03 Jul 2023 23:07:06 +0200 Message-ID: References: <867cropyh3.fsf@mail.linkov.net> <86mt0kulli.fsf@mail.linkov.net> <86wmzmzs1s.fsf@mail.linkov.net> <86edluyxhl.fsf@mail.linkov.net> <86bkgxfm34.fsf@mail.linkov.net> <86zg4gddtf.fsf@mail.linkov.net> <86v8f2xkr4.fsf@mail.linkov.net> <835y72noo4.fsf@gnu.org> <83zg4dmd4k.fsf@gnu.org> <83pm59m8vs.fsf@gnu.org> <86sfa46e1l.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18158"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 04 04:25:16 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qGVj9-0004UF-QH for ged-emacs-devel@m.gmane-mx.org; Tue, 04 Jul 2023 04:25:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qGViH-00046i-H1; Mon, 03 Jul 2023 22:24:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGQlO-0000Iv-2f for emacs-devel@gnu.org; Mon, 03 Jul 2023 17:07:14 -0400 Original-Received: from mail-he1eur04olkn2057.outbound.protection.outlook.com ([40.92.73.57] helo=EUR04-HE1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGQlL-0001Z2-TE; Mon, 03 Jul 2023 17:07:13 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A32Csc2Mqi+U2nd9VF47U2Pfb9jbSbRVTGqCf6P8hcQSIn+3Ok2p7sfa1LNTMOdFPgL4w+8v5LaMM5/N2tlwuJ8wK3DyRUzx8rnhLzVI7wYPUxuuuUSXx4oGP3G9RYQq6gUluaoERYeMVxFfiRvPmsL1YnKjn+PsIJLrxzpvIU3UhkJKQcQCUVbSdlbE6dXh0dySd1LGWGG3nxzoQYBX4pt1nOqI/F9u+DLh7GT4iIUfnCsjc2LLlaR0gC1TnzUVl+7AIlkg1sqdwD1uvbnUzDrh7JCV/Ghd7Owl6jwFEbqvZJJ0GGWehhymihsrEvvB2TTrWN3mWFCwx1tnBQU9NQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PQmS6nMOeGoTCW5A1hW8QpaCVbFmTFmgYDVt6zIZ0GQ=; b=XTxu5c/Ak6vCMvk9GM6trOfj9c7RSDRRDo3s2W0plGXTB92H3lPc9DeZ4Fb8XOVFWHQWUf7OswiO3R0K1wfbVirtrxna1592g8kz9Vo+VUH4/lR9qi/9KmVyVk5P6mB9unZ63pNkICL5uM1EzQyUjTlpM24ngf1YJ0muevqbakx3a5w88tYgr83j37vWK1DO+BltUmPDmR0tL70gQfJ967Q8xqwUejvVBWM+TtuNr7AzAFRCPvEp0moDGHpeymQ8NN2Z8u5aYJJnblhUj2m6/2DHIiuozQ8PGkfknK6IJY8YE7IXBKSI/vHj2/1HUBBUIboxsFvHXKEWkEryZxrv3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PQmS6nMOeGoTCW5A1hW8QpaCVbFmTFmgYDVt6zIZ0GQ=; b=JL0K0A32mn310XWCDAI5AVUi+SFvuZulwueQX8H03oNxMd3mVWpbR9N+LOaNT3Wr3JAVya6KaGZgn8v1mJWy4mUk/0ixd5Ngx7GHL5hzzX83ha1Ztxg8YXxEcyb4H22hEdhAbkTv1qxSWYjL2GcSnBgCp+R5qtdP0Lzl9N0O6LHwBIU7JvUI6KeDFPUe5LRNPvvUkIaYBLSlqYJ65ul392u1HpmLRVd8f9I6idgieVAzStgNV/395eEtyfzt5VUjl0cQ6XMzFse4mK1QB75wIdL+EGHDN3+CMT2x8Eb2vhL2cM3EwVeDr0yrdeAWT7Jeokzqeb4IodUBrsD56IPE5w== Original-Received: from AM9PR09MB4977.eurprd09.prod.outlook.com (2603:10a6:20b:304::20) by AS4PR09MB6517.eurprd09.prod.outlook.com (2603:10a6:20b:4f9::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Mon, 3 Jul 2023 21:07:08 +0000 Original-Received: from AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::4a5f:42f9:d78f:2021]) by AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::4a5f:42f9:d78f:2021%4]) with mapi id 15.20.6544.024; Mon, 3 Jul 2023 21:07:08 +0000 In-Reply-To: <86sfa46e1l.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 03 Jul 2023 21:40:10 +0300") X-TMN: [x2vzHRe4Qz7AiP6mo/BMdYoC0/FlN6U0] X-ClientProxiedBy: BE1P281CA0325.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:87::14) To AM9PR09MB4977.eurprd09.prod.outlook.com (2603:10a6:20b:304::20) X-Microsoft-Original-Message-ID: <82sfa4r9fp.fsf@live.com> X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM9PR09MB4977:EE_|AS4PR09MB6517:EE_ X-MS-Office365-Filtering-Correlation-Id: a9cb9af2-5e36-478f-d8de-08db7c09762e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4/dthyNp5PUCzSWUBnd9uluijDHaZ4R4fI8CRZu3rBiUqKpo4LAelffyiMqWPlbX0FLbgCNrwBgdAyBNKzKsOyLqatXAr4NvYKmfj9Hri3sO+2YZfJyDvoXZmZoVspR4zNrE3hM2hU1rZmaqiaxCcPQGS+bAAInEJJTWZ4+tBEioCNhkbCChjO4pnAMdAnt7QpmY3Cgy8ZwB7Eu3HmA2CBhhcXlHs+mylzey1IeCeUNPEqDiYzUs9Pk4jwaA+gNUjYHGCvfqm4jeC15sUygRIfv5glj1+1v3QcCFK1S1eVu1PNZBzDj+3J0WIayTcFtHfeSB6sxdZb0F6JHpOAFWAIdotNZ/kNqMHSlLIw7c0BGRLcB4jLoXeG1JhA1HxC/F63/qO0YWP9qMwQVmx+GSd8EAsGuq1kz2qstnVSr1rFdUXd0GTRUkIrcwfr3SKpwJta43TM720HeWRwqbmrtHNPn94qan01VYqJZnB2O4S4nU0B50bU1pmU1hHwRTwOMai50YSvDYYbGA3+3CqE5tyJNXS7lz6bVpYmByjextBjA= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wecBn0Kr/tIKNfKjZ0eL4Bl9t/N3DutfcFPnq0orWduSVCy+SwoKsqzjHAVm?= =?us-ascii?Q?ImWR4GjoUV84sRs1xcdPYVoDZbZGeXaT+szOh5ztDB93eQ/IJqyLR++rOswa?= =?us-ascii?Q?/v5AGITp/+LYZvMXe7g4NS9yPgW10F46jSrp/4vfBPeJd82h4Luesk9SxxgQ?= =?us-ascii?Q?0/32F/LE6axgBybiHFOioYZ1wZ++G2YeeuY9dE4FdyVRsOF4HO0EpYXI/Gqj?= =?us-ascii?Q?WnoMVdO/DUES21UFq0soB0pt/1WkcFEQfDHKzgZ2Hxv7sJ/z7B1R8SEqz0cN?= =?us-ascii?Q?DJCvQFqALbjsFNURaRcgQzrHLCTC1iYuF1ls5EvKkxdd6byYx2I3nnIwR+rt?= =?us-ascii?Q?+ihCrqvnuHLfLbsqVgo0tWUAlEIGyCtPDM8vduj6Un0QWA8Y8fpdukDQFG+u?= =?us-ascii?Q?FIc3PfkpPlG6jtehD3QbaXG1prjYfQZgEUx3jWeqZJMzcWOTfJ87tZkYkxaf?= =?us-ascii?Q?GzzKAX0Bh8JwyKCKFY47FHtvUhRuuMXVgW2d0nfOE985yiBfU+TQOCzWROxi?= =?us-ascii?Q?S8hETos+N9hMhYqzcJMzv+U4oBZYtil1GKdNM+adcz1/pMH0WD1hLLIm4sB8?= =?us-ascii?Q?oUZjmcoyMg78ReQFcNwzqStyx95wMCDuNZ/11A/jpUizk4EwNRapvZzMQCti?= =?us-ascii?Q?g3 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-64da6.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: a9cb9af2-5e36-478f-d8de-08db7c09762e X-MS-Exchange-CrossTenant-AuthSource: AM9PR09MB4977.eurprd09.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2023 21:07:08.8186 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR09MB6517 Received-SPF: pass client-ip=40.92.73.57; envelope-from=arthur.miller@live.com; helo=EUR04-HE1-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 03 Jul 2023 22:24:18 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:307396 Archived-At: Juri Linkov writes: >>> >> >> It seems you found a bug in 'key-valid-p'! >>> >> >> And indeed it returns nil: >>> >> >> >>> >> >> (key-valid-p " ") >>> >> > >>> >> > Why is it a bug? " " has no meaning, >>> >> > since it isn't a mouse event. >>> >> >>> >> Is "remap" a mouse event? >>> > >>> > Why is "remap" relevant to the issue at hand? >>> >>> I converted from "old idiom" in info.el to new defvar-keymap. When >>> seeing "remap" (a dummy event) works, I just expected defvar-keymap was >>> done the way that it is possible to use all keys, fake-kyes, events, >>> and whatnot the same way. Similar as I expected 'frame to have same >>> meaning everywhere for the uniformity. >>> >>> Would look more tidy if it was possible to keep all key definitions in >>> the same place as in the old code. >> >> Do you mean that we had a binding like [tool-bar C-Back\ in\ history] >> somewhere? It is in info.el since version 27: (defvar Info-mode-map (let ((map (make-keymap))) (suppress-keymap map) (define-key map "." 'beginning-of-buffer) (define-key map " " 'Info-scroll-up) (define-key map [?\S-\ ] 'Info-scroll-down) (define-key map "\C-m" 'Info-follow-nearest-node) (define-key map "\t" 'Info-next-reference) (define-key map "\e\t" 'Info-prev-reference) (define-key map [backtab] 'Info-prev-reference) (define-key map "1" 'Info-nth-menu-item) (define-key map "2" 'Info-nth-menu-item) (define-key map "3" 'Info-nth-menu-item) (define-key map "4" 'Info-nth-menu-item) (define-key map "5" 'Info-nth-menu-item) (define-key map "6" 'Info-nth-menu-item) (define-key map "7" 'Info-nth-menu-item) (define-key map "8" 'Info-nth-menu-item) (define-key map "9" 'Info-nth-menu-item) (define-key map "0" 'undefined) (define-key map "?" 'Info-summary) (define-key map "]" 'Info-forward-node) (define-key map "[" 'Info-backward-node) (define-key map "<" 'Info-top-node) (define-key map ">" 'Info-final-node) (define-key map "b" 'beginning-of-buffer) (put 'beginning-of-buffer :advertised-binding "b") (define-key map "d" 'Info-directory) (define-key map "e" 'end-of-buffer) (define-key map "f" 'Info-follow-reference) (define-key map "g" 'Info-goto-node) (define-key map "G" 'Info-goto-node-web) (define-key map "h" 'Info-help) ;; This is for compatibility with standalone info (>~ version 5.2). ;; Though for some time, standalone info had H and h reversed. ;; See . (define-key map "H" 'describe-mode) (define-key map "i" 'Info-index) (define-key map "I" 'Info-virtual-index) (define-key map "l" 'Info-history-back) (define-key map "L" 'Info-history) (define-key map "m" 'Info-menu) (define-key map "n" 'Info-next) (define-key map "p" 'Info-prev) (define-key map "q" 'quit-window) (define-key map "r" 'Info-history-forward) (define-key map "s" 'Info-search) (define-key map "S" 'Info-search-case-sensitively) (define-key map "\M-n" 'clone-buffer) (define-key map "t" 'Info-top-node) (define-key map "T" 'Info-toc) (define-key map "u" 'Info-up) ;; `w' for consistency with `dired-copy-filename-as-kill'. (define-key map "w" 'Info-copy-current-node-name) (define-key map "c" 'Info-copy-current-node-name) ;; `^' for consistency with `dired-up-directory'. (define-key map "^" 'Info-up) (define-key map "," 'Info-index-next) (define-key map "\177" 'Info-scroll-down) (define-key map [remap goto-line] 'goto-line-relative) (define-key map [mouse-2] 'Info-mouse-follow-nearest-node) (define-key map [follow-link] 'mouse-face) (define-key map [XF86Back] 'Info-history-back) (define-key map [XF86Forward] 'Info-history-forward) (define-key map [tool-bar C-Back\ in\ history] 'Info-history-back-menu) (define-key map [tool-bar C-Forward\ in\ history] 'Info-history-forward-menu) map) "Keymap containing Info commands.") > This symbol is generated automatically by 'easy-menu-define' > from the menu item "Back in History" with spaces inside. Since menus in Emacs are implemented as keymaps, I thought toolbar is "sort of a menu" and probably implemented as a keymap too, and that tool-bar was some "special event".