From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Arthur Miller Newsgroups: gmane.emacs.devel Subject: Re: Path & Demo: Source View in Help Buffers Date: Wed, 22 Sep 2021 18:50:35 +0200 Message-ID: References: <87o88kj2oz.fsf@gnu.org> <87k0j8j0v3.fsf@gnu.org> <878rzo1ypa.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16451"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 22 18:53:33 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mT5Uw-000435-Vj for ged-emacs-devel@m.gmane-mx.org; Wed, 22 Sep 2021 18:53:32 +0200 Original-Received: from localhost ([::1]:59644 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mT5Uu-0000cZ-JQ for ged-emacs-devel@m.gmane-mx.org; Wed, 22 Sep 2021 12:53:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53340) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mT5SH-0006h8-88 for emacs-devel@gnu.org; Wed, 22 Sep 2021 12:50:45 -0400 Original-Received: from mail-oln040092068092.outbound.protection.outlook.com ([40.92.68.92]:54402 helo=EUR02-HE1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mT5SC-0000oB-MY; Wed, 22 Sep 2021 12:50:44 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cMAd2GIKaFdWVdqi7vs4Wvz920Vuybu/A2W1j+BCdzbZOqO71B7ZSK3um+e2ZnzxDAu81SZc18AugK7dAjkg0/K1HkCc0tkd1q7+CzX0M9cHAUfdi+JWkQZAsS5tqAEthP5cYVNOGIbgIezXOrXxL7Cj8aXN3upAxPYUVg/bzZ+aatwzqvMdrhnQ0ZD0I+d7oJ2q9jfVS5FJWjZyC/TzRREssIeBnOqTukPQZeviWsh/jSIwVm9qgW+bigDIIsBEc3LxADBDExMCitAVboSdG9A3RNilPfKamfUL+Tv0knwzhkQGkx0BqjBhq4Mg+COAO4LG7f2+Xh91fp+nWA2+Ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=dygcEK351TP4fngkBbsEfJY57Mat+ATdnsi4sMzIS28=; b=SCLDAAP5TVMB5RHw9StGBKFbaMXcjK6ckqz+9lsCDtv2G4Yj+I+xEoSj5ZaJdQjMOVfsp3yLwInJtMjUGr/u2V5c0ELjST5u2FiUGrxtCH20zUAGtCMzpwtW7pjUCVGzpeo2Lxwd7mGPY+fFHeTbiaZaHC52ah6x0RsjUuUhXMs2RSGUQFsU3NYZ/z13Hi64OX0L5YZMRFhWhJDSs/VjoHxOYFLvsp22rUiweox4WIDxgmEXGM++mtcN4iKGQ+WDG38wNhjcK6i9eUJ2WkK4yMaEauEM0esMInH8mth/EMcCYKMPxMLJ8z3mBupP/B6NcTWXFJSa/TAF10I7Q1F+Iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dygcEK351TP4fngkBbsEfJY57Mat+ATdnsi4sMzIS28=; b=JWywI35wCEAJGNFFxeGG7sB73iT6myhQ1OD678mPOBJ5mqOo2EaMFGSUp3eyeik18D6Eliha+2apQ59raoDg+rxHc1SVj/1xLoafp6d2ICICdcA3WEKu8tRW0a3shJIUBtZGHlNQ51ppGFGydCRPoe67LzNxQm1Y01D0zDpBIEgAX6QjaTjjwTaBdS/tUk7gw6hesw5QecQbT7K49efyHeXlK/SuaTvD+I1SuqulCb3OE2u2UD4t/BKNMDJMWs+bH7EMIKHp/w+WBYfwQnK+Y0swYlFIE3T8mMOos4u0kBcoiQSgUqZLPo6lX8OTQRDwPLsNnPGOjSnrGjefu1TWbQ== Original-Received: from AM9PR09MB4977.eurprd09.prod.outlook.com (2603:10a6:20b:304::20) by AM0PR09MB2964.eurprd09.prod.outlook.com (2603:10a6:208:130::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.15; Wed, 22 Sep 2021 16:50:37 +0000 Original-Received: from AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::c55c:ece5:bed2:a9dc]) by AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::c55c:ece5:bed2:a9dc%8]) with mapi id 15.20.4544.013; Wed, 22 Sep 2021 16:50:37 +0000 In-Reply-To: <878rzo1ypa.fsf@gnu.org> (Tassilo Horn's message of "Wed, 22 Sep 2021 16:08:36 +0200") X-TMN: [9q/Y0DX7aP7e4RKg7FYZMVIyxsg+bSiS] X-ClientProxiedBy: HE1PR05CA0169.eurprd05.prod.outlook.com (2603:10a6:3:f8::17) To AM9PR09MB4977.eurprd09.prod.outlook.com (2603:10a6:20b:304::20) X-Microsoft-Original-Message-ID: <87ilysv9k4.fsf@live.com> X-MS-Exchange-MessageSentRepresentingType: 1 Original-Received: from pascal.homepc (81.232.177.30) by HE1PR05CA0169.eurprd05.prod.outlook.com (2603:10a6:3:f8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.14 via Frontend Transport; Wed, 22 Sep 2021 16:50:36 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d443b29c-13bf-49f9-87ad-08d97de919e6 X-MS-TrafficTypeDiagnostic: AM0PR09MB2964: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8oQXylUJmqgdR2JRXfSJug9R5LFRWV21r1JY/4zPFCmgpdnwWaCJjcq+LlPtdyyJn0aifQC4eSN0opeb8y2bll5CzCpGUMhQXH8frfnwvf/JZjY40pmKajJ6QlLbOWGVzo5kC9UuLNan5tjFlR3KbKUHs4HewI/Q7gTwaLo0HRyeMk9wI0bYUlPmx3X+4d7/Y3UtMZuoY3hadXdKBKajFoq/ThGdszfKt7BxRaNgaSa5TKzcD8heAs7L7Jwn4EXpMOQkh78MvzK9Jla4LCh3l7IvdFHfIpOfxYgbx7dkqN/6w/+yta/KrLNQHiFxSu2H5gpMisaAqBXLwAbghJVbkGXnWG92+OIB8CuyFL/67v6HMmmK5JqBxJE4EX3QIxz/TCKF/4Fmt7e7gBYL16FKSipJZNeoCWGacv+UFCxnvLJQrC5u7LHXQj/rWtW1hnbd X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: X3cUXu8Z7kavWnR8Cae3Ot9M2mQkuwu4iF0MKpsUDvqCYRXpX7gDabS1T7XktS4YICttW862umNgEP1aG0Qkoaf8hKfYb6uMdrp1Cd0San3Y35e4JDZ6Dg7MClYeiHJT2OhUefG2n8kj1m+A01fO9w== X-OriginatorOrg: sct-15-20-3174-20-msonline-outlook-72e6e.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: d443b29c-13bf-49f9-87ad-08d97de919e6 X-MS-Exchange-CrossTenant-AuthSource: AM9PR09MB4977.eurprd09.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2021 16:50:36.9566 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR09MB2964 Received-SPF: pass client-ip=40.92.68.92; envelope-from=arthur.miller@live.com; helo=EUR02-HE1-obe.outbound.protection.outlook.com X-Spam_score_int: -1 X-Spam_score: -0.2 X-Spam_bar: / X-Spam_report: (-0.2 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275324 Archived-At: Tassilo Horn writes: > Arthur Miller writes: > >>> I think that's a common check for 3rd-party packages which want to keep >>> supporting emacs 24. But since you are hacking emacs core, there's no >>> need for that unless the function/variable is only defined if some >>> configure option is given or some lib is available. But none of the >>> latter applies to font-lock.el. >> >> Yes, I have tested now, it works fine. I did even som minor >> refactoring. >> >> Don't know if anyone else cares at all, > > I don't know either. :-) > >> anyway here is updated patch. > > +(defun help--insert-source () > + "Fnd and insert source for the current symbol into the help-mode > +buffer." > > Nitpick: There's an "i" missing in "F[i]nd" and checkdoc wants the first > sentence on the first line. :-) Haha, thanks. Yes, I didn't notice it spilled over to next line. Will try to reword it. It is just internal function, and function name should be enough self-documenting for most people. > Aside from that, I think it would be useful if one could jump from the > shown inlined code into the source file, too. Then one doesn't have to > navigate back to the filename.{c,el} link. Maybe it could even jump to > the line corresponding to the location of point in the inlined code? At > least the lines offset is easy to calculate. I know; I was thinking of that one, but it will have to be at some other time if at all. It is not difficult to do at all, but I don't want to spend more time on the patch if it's not interesting to include it.