Re: Path & Demo: Source View in Help Buffers

[Arthur Miller <arthur.miller@live.com>]

Tassilo Horn <tsdh@gnu.org> writes:

> Arthur Miller <arthur.miller@live.com> writes:
>
>>> I think that's a common check for 3rd-party packages which want to keep
>>> supporting emacs 24.  But since you are hacking emacs core, there's no
>>> need for that unless the function/variable is only defined if some
>>> configure option is given or some lib is available.  But none of the
>>> latter applies to font-lock.el.
>>
>> Yes, I have tested now, it works fine. I did even som minor
>> refactoring.
>>
>> Don't know if anyone else cares at all,
>
> I don't know either. :-)
>
>> anyway here is updated patch.
>
> +(defun help--insert-source ()
> +  "Fnd and insert source for the current symbol into the help-mode
> +buffer."
>
> Nitpick: There's an "i" missing in "F[i]nd" and checkdoc wants the first
> sentence on the first line.
:-) Haha, thanks. Yes, I didn't notice it spilled over to next line. Will try to
reword it. It is just internal function, and function name should be enough
self-documenting for most people.

> Aside from that, I think it would be useful if one could jump from the
> shown inlined code into the source file, too.  Then one doesn't have to
> navigate back to the filename.{c,el} link.  Maybe it could even jump to
> the line corresponding to the location of point in the inlined code?  At
> least the lines offset is easy to calculate.

I know; I was thinking of that one, but it will have to be at some other time if
at all. It is not difficult to do at all, but I don't want to spend more time on
the patch if it's not interesting to include it.