From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Arthur Miller Newsgroups: gmane.emacs.devel Subject: Re: Native compiler - passing command line options to C compiler Date: Mon, 30 Aug 2021 15:56:03 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21067"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Andrea Corallo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 30 15:57:17 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mKhml-0005FI-Sn for ged-emacs-devel@m.gmane-mx.org; Mon, 30 Aug 2021 15:57:17 +0200 Original-Received: from localhost ([::1]:48206 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mKhmk-0003Tf-Hf for ged-emacs-devel@m.gmane-mx.org; Mon, 30 Aug 2021 09:57:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44956) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKhll-0002nc-Bs for emacs-devel@gnu.org; Mon, 30 Aug 2021 09:56:13 -0400 Original-Received: from mail-vi1eur05olkn2088.outbound.protection.outlook.com ([40.92.90.88]:1664 helo=EUR05-VI1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKhlh-0003qL-2T for emacs-devel@gnu.org; Mon, 30 Aug 2021 09:56:13 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tm7hVaMbQnQ/GH20ksBucCatmu2T+bsTAc5JdaiwXE89Jqv5r4DeEeWHnotzS/HvUNeSHvjJJ3Q28LaYvXLa+znzSuRDoSc5SVXwtUp7sP698cG3DjTJdg8aWxZGWjVCL8oCNX8wp3rYuobGpLKhn8N5VwxgiiQfSCNg0+EysDIHWCY3A7HZrQnn9EzNxU5HHYcL6hNgK2d/2d+4q+wKN0xsNxce89yY5BZ6shXbZgcQB5aBFQSY5B3MKO/ClXBLSOnFJ0GFm5mltsfa23On4TuCrwARGTawN43AqB3vtUVJdsLfNBZorZd6mVWIi9NaNoLrHmP+3+9cs7Q2mqKidw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YkEba1SorE6ABOFrksx4MZ/x/md1tv/ufpU8tkqrNSY=; b=FrK2J2P+bfRTQnXoOAl+Bbj1uaYsvKgsx+PAJHquMNNsMuENQyMvXH0mjDPunUqq3WokOs7dhjLnbcKR+8D8s2FlOwCjologcq9FciUS5lmJvH3rvmKagaND9ep2n9X5xWHWonHS6PJZEKrfjJ3qI9SdaX8aaBHR//cs4su3pjzhC2gTxwlPcif64DCAdrG87/7xxs34seJmNE8OVrBnOY2VjvVmb3F+CnAeqF95ptnuCDNwc3hkKukt61ttlMWDF0fSLLgECmOdA9XfjdRU46A2/6qosyZLNUvyYY2oeSrtglhBu+S6BTAdAm+KqH6w2skvnOgd119QwCXw7RHLow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YkEba1SorE6ABOFrksx4MZ/x/md1tv/ufpU8tkqrNSY=; b=cDWesQ1ebFtRVc9xxbgQJojxyRs2vUcXWixDsmz40pVTJKZ2gVxd1ncrkR109WTp/LYD2UwtmEoZWULpmnU6q+X8PQ/l2iUQ+0dHVmtpLRcDpoUq6+C3JBpUUHy5JYf4dKuh44K+LfULhOA/NKtMNg89kJYiHpLNNa9AOUa+xhVhovz4kHLMguB+VktstOYwZfIAQcRRAyYxSSOgQcIXA+qypaImNiQ1MuosvAaO2UbkY4/RMohXOswhxcSCSgfUj8sNKX99ibwRwOZK+EW/0p3LJMindZsFCfBrUE+uWzCIgr7p/eOwrBiSHKZkF9FySGhnL2HWZe8TA5g52lxu6w== Original-Received: from DB8EUR05FT058.eop-eur05.prod.protection.outlook.com (2a01:111:e400:fc0f::45) by DB8EUR05HT226.eop-eur05.prod.protection.outlook.com (2a01:111:e400:fc0f::372) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17; Mon, 30 Aug 2021 13:56:05 +0000 Original-Received: from AM9PR09MB4977.eurprd09.prod.outlook.com (2a01:111:e400:fc0f::45) by DB8EUR05FT058.mail.protection.outlook.com (2a01:111:e400:fc0f::164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17 via Frontend Transport; Mon, 30 Aug 2021 13:56:05 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:0D8AF3C33B239A54918B6E22930F9299A441CFCFB27A444B2B50BB9B6FDE54E9; UpperCasedChecksum:845E8E3FA2EEF7301269FD558338932D446C6EBC46C949D309679134F21EC7C2; SizeAsReceived:7473; Count:46 Original-Received: from AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::35f2:ac79:ee50:c46c]) by AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::35f2:ac79:ee50:c46c%8]) with mapi id 15.20.4457.024; Mon, 30 Aug 2021 13:56:05 +0000 In-Reply-To: (Andrea Corallo's message of "Mon, 30 Aug 2021 09:36:09 +0000") X-TMN: [71vO9VgvYruuxS5zxRCZmZwNw8i3aOLp] X-ClientProxiedBy: AM6P192CA0103.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:8d::44) To AM9PR09MB4977.eurprd09.prod.outlook.com (2603:10a6:20b:304::20) X-Microsoft-Original-Message-ID: <87r1eb9guk.fsf@live.com> X-MS-Exchange-MessageSentRepresentingType: 1 Original-Received: from pascal.homepc (81.232.177.30) by AM6P192CA0103.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:8d::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17 via Frontend Transport; Mon, 30 Aug 2021 13:56:04 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 46 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 0ae5b609-f1a5-44cf-8cdb-08d96bbde8a0 X-MS-TrafficTypeDiagnostic: DB8EUR05HT226: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZYsvhHj2WYgHrlfsrHrk8+z5e8oIPbwyQRFMLGdG32dIUvNCiAYOh2AFPM82I2Qh4irUWCZYEzrblSN5PxwAq/qtVqfr15laRcofCGSp4PZiMz0GousNXDt+WyOO7cDaKwBXDf/icJwGX5ldZ3qUE0vnluu90QAqH+l0u8ZU68LXsdspWj3FmZNERY1Ip4SdAzeYe4hpb4tI2onplzNkFUsTAS+1qxVZNLqwcMzbAa2EBEbWE1RKZUO/XA3t9Xj4T5XSQUENLI8iwxo5vUjTJgZUWsVRXhZ7Ko4v5/u5vVoH+oYv6JH1ughzf6c5NODXRYVAe6Y1z6I6haigHfuKL8pMQB0/1iUooivS4Lg7kbyFdMFtLQg3W89LaIqBDwmDhR3whM3d8a3ISVbpUvWwRER5+03YHaWbAfnQztuOJY36RsIITzW6QKXlYpnKaEQX X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: XPIg7ugfDym16qqpvRN8+fGiIgprlhk6d1vHsboEwJzEcWg/1eyUz8yJYZAL8Lp31siMwfAECgyYYPQg7p7L+V7/oxeKS4kW1+TCImORqVnF26bq1gLFU3+1+fYGuDrRR7B7KsDiCZKIru8kvdqH2g== X-OriginatorOrg: live.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0ae5b609-f1a5-44cf-8cdb-08d96bbde8a0 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2021 13:56:05.0062 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: DB8EUR05FT058.eop-eur05.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8EUR05HT226 Received-SPF: pass client-ip=40.92.90.88; envelope-from=arthur.miller@live.com; helo=EUR05-VI1-obe.outbound.protection.outlook.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, FREEMAIL_FROM=0.001, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:273494 Archived-At: Andrea Corallo writes: > Arthur Miller writes: > >> Hi again, >> >> after the few mails the other day, I wasn't really sure if Andrea is going to >> implement it and when. > > Sure I was going to implent it as I said so, but thanks for taking the > task :) I just wanted to test it myself, and it looked like an easy thing to do so it felt like I can do it, so you have time to do something more important, like grab a beer, get on a date, or implement some more optimizations? :-) >> I thought it was rather a tedious manual labour and maybe >> not so important, so I took me a liberty to implement this myself in my own, so >> called, personal copy of Eamcs sources. >> >> I am not sure if I have done it correctly though, I appreciate if Andrea have >> time to take a look; > > I just have a small suggestion. > >> Mark set >> >> diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el >> index 80a1da5ad8..58d361cf46 100644 >> --- a/lisp/emacs-lisp/comp.el >> +++ b/lisp/emacs-lisp/comp.el >> @@ -166,6 +166,16 @@ native-comp-async-query-on-exit >> :type 'boolean >> :version "28.1") >> >> +(defcustom native-comp-compiler-options nil >> + "Options passed verbatim to the native compiler's c driver. > > I'd just say "passed to the compiler" or "passed to GCC" as there's no C > involed. Yes, I'll change it. I didn't know really what to say that to be honest. >> +#endif >> + if (CONSP (options)) >> + xsignal1 (Qnative_compiler_error, >> + build_string ("Customizing native compiler options" >> + " via `comp-native-compiler-options' is" >> + " only available on libgccjit version 9" >> + " and above.")); >> + >> + /* Captured `comp-native-driver-options' because file-local. */ > ^^^ > native-comp-compiler-options ? > No idea, but I can change it :-). > Other that that the patch LGTM. Could you provide it with its > Changelog? Yes, will do later tonight. Do you want me to also rename the 'native-comp-driver-options' to 'native-comp-backend-options' when I am anyway at it? I can do it in the same patch if you want.