From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Arthur Miller Newsgroups: gmane.emacs.devel Subject: Re: Patch proposal: display symbol source code in help buffers Date: Tue, 21 Sep 2021 01:45:49 +0200 Message-ID: References: <875yuvlrz3.fsf@gnus.org> <87r1djixiw.fsf@gnus.org> <878rzrzpfz.fsf@localhost> <87zgs7y5wc.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35504"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , Stefan Kangas , emacs-devel@gnu.org To: Ihor Radchenko Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 21 01:47:16 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mST0F-00090B-7e for ged-emacs-devel@m.gmane-mx.org; Tue, 21 Sep 2021 01:47:16 +0200 Original-Received: from localhost ([::1]:54342 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mST0D-0001Wp-Rb for ged-emacs-devel@m.gmane-mx.org; Mon, 20 Sep 2021 19:47:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53846) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSSyx-0000hL-57 for emacs-devel@gnu.org; Mon, 20 Sep 2021 19:45:56 -0400 Original-Received: from mail-oln040092073079.outbound.protection.outlook.com ([40.92.73.79]:3477 helo=EUR04-HE1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSSyu-0008AW-Sm for emacs-devel@gnu.org; Mon, 20 Sep 2021 19:45:54 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OGbJu2xn/LjsV+lt71dAikPmvwwgUCCOL+F9z6+Om1q2wbwCttHjwnoDWZVeSWKmFO0H0ZPTFNm5B/gEy2XSM4eu35Nb3065Lqt9i/o3oa1iLfQvctEyLPykpDr8I9uto40ioAzaycxtnMTG7/IrHBPN1bXfB0iVBCGUkhmco+LPWR+v3oIEfz3eUr3Vyr1HRbm60JDtYlBevro2SKh+JTjGMMtf4jwqzfnaOlpAO1FqsCk3NVaCFHa8Uo1+mk5FRXMzBrAvfthcHPJGcyHDFkJjfMx2wtd8Fpa/BXvCovOIlC+eQUEZkdw0PlULQVDvD/Ie1tj1b2Zu9vhnq7hhsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=g8co98HWLi0psI0RDmrh+rGoTajh/Y+3N92FXbcc7eM=; b=Skh0LsCakOgIkfVd5saHz6cphDK5IPXHQiu/diOWOCvTf4Hj7qgnGPgNBTsYj6QACOeHWm6vOgHdgc954kfynC8g6BksOHNqMj1rg8CFC0M8WO3SIhQdRVhF+KyttB7dxbCsRwmSb+/9ap18HmNmDZ1H5JSysk4pjyZC7MCOqpr5SwRWQIjbG9JP+f6p9FskJQ9mpABjIblvQaZtVilPcFyAjMf8Utkk78ym4p6mUrBkvm+pa1D3Pmj8y6dKi0tcsn7hQ2Chswoj9QA5EZW6STt60iTLWF7GAjpJrwPnct9RiHKvNYRTTrRk1cWxetBeQrtsYoFuIQXRt12eV5umnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g8co98HWLi0psI0RDmrh+rGoTajh/Y+3N92FXbcc7eM=; b=c4cMRc4GgKZxgjS5l7R9Oab99BNB3pQHRjNef5gDI9Y/wE1p9bTLmSCG05gx3bbcvu2GZPuPUTUZKXegrqzzZX/1MlqflzI1e/kZlPfiJIyRIcTbmvlVTmVLGDJKD8b6q5Qzs7H+6zAuencfXTmvSxqaq7LMGQD+VnBqx9v5hMzV0Q6AqSuhMvOBgNj95UH2k4IEGXhUR039hopb7dawZLY1dO1B+ZiZyGT8Ws2Ioiapxxe8vYCmCS86YOlI0tu+QejscdrpwpxXZgd5At33drYRq4Mg3b4Yb1VL8YPHFkrt2EiP2AZo/OHrVNlLdMascEbPBto0tYFiZMcyhc+fPg== Original-Received: from AM9PR09MB4977.eurprd09.prod.outlook.com (2603:10a6:20b:304::20) by AM0PR09MB3633.eurprd09.prod.outlook.com (2603:10a6:208:17d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Mon, 20 Sep 2021 23:45:50 +0000 Original-Received: from AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::c55c:ece5:bed2:a9dc]) by AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::c55c:ece5:bed2:a9dc%9]) with mapi id 15.20.4523.018; Mon, 20 Sep 2021 23:45:50 +0000 In-Reply-To: <87zgs7y5wc.fsf@localhost> (Ihor Radchenko's message of "Mon, 20 Sep 2021 17:04:35 +0800") X-TMN: [7/KuC6zhcW6oyFUUPMHuPCtmYhlw3VvO] X-ClientProxiedBy: AS8PR04CA0065.eurprd04.prod.outlook.com (2603:10a6:20b:313::10) To AM9PR09MB4977.eurprd09.prod.outlook.com (2603:10a6:20b:304::20) X-Microsoft-Original-Message-ID: <87bl4mq09e.fsf@live.com> X-MS-Exchange-MessageSentRepresentingType: 1 Original-Received: from pascal.homepc (81.232.177.30) by AS8PR04CA0065.eurprd04.prod.outlook.com (2603:10a6:20b:313::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Mon, 20 Sep 2021 23:45:49 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1b33a721-1e4a-4c56-f3e8-08d97c90c683 X-MS-TrafficTypeDiagnostic: AM0PR09MB3633: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OcLbeYUc6ChrcytgIhvugldchoCbu37HAP9ZzLrYEeMp5AN62fHY7TiFcKZHepC8lCyyPQR3h5c0SibQqh2PRjIZJoediem+A/1jRQ55NFC+RWT41mdv8HgNM6LHi2BlMIo4o2wRQb6nV0Gy4ZN6n5/AqWRoTuA0JRnjR3bihkLdztu8Y6XhlCh+YpYoN2SPdoEjbtsa8uNnNOptJxwCOLWwPSwR9DcATjQp/yJtYhGa/q/UG+Fxol89QuOMxQxkEK83TIXXYMp7eJK5uxBIGEzlBQ7U4tntrsTFurg7RbMaBR8tXViE2EqqpHWIDSatw7kB6OFZ/Pl9/TIYI++1zhie6Ly8KI7agYLwmHXjhymMGxkIycWynleU+aUevk+/a9b1nEKAepoD1WJyXzRtkHpOJu8exU5AfkT5g3uiKYqyjmJIPosIMKl2g+rb1tqm X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: YNw5ehGhMPapIPkS/AcDUsjnew8pjzJ/9+xoT7lob1pzDz6rSgtj5Kt0TEulBMhwIqg5pKu8QVxuIW9Dg5g+/D5tcw45z5oTgOy4eah7sBIweUqbKVam5V8Ik/qzy/NwxaWIGlnUVOamx936P8Cpkg== X-OriginatorOrg: sct-15-20-3174-20-msonline-outlook-72e6e.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 1b33a721-1e4a-4c56-f3e8-08d97c90c683 X-MS-Exchange-CrossTenant-AuthSource: AM9PR09MB4977.eurprd09.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2021 23:45:50.1438 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR09MB3633 Received-SPF: pass client-ip=40.92.73.79; envelope-from=arthur.miller@live.com; helo=EUR04-HE1-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275178 Archived-At: Ihor Radchenko writes: > Stefan Kangas writes: > >>> Opening help buffer for B is easy - f with point at the B's >>> call. However, without source code being shown in the help buffer, if I >>> try to hit s, the narrowing is removed and the point is moved to a >>> function definition. Not convenient. >> >> I'm not arguing against the new feature here, but is the above a bug? > > My comment was to resolve your puzzled state about usefulness of the new > feature ;) Yes. Thank you very much :). I realized that later. It seems like I was reading thread upside-down. Just me being goofy after nights of baby feeding and 3 hours cycle living. >> It seems to me that `help-view-source' should respect the users >> narrowing, for example by querying to open a new indirect buffer or >> something in that case. > > That would make sense. Yet, even without narrowing, I personally do not > like that the point moves from the defun I am working on to other > function definition. > > Also, a subtle difference between showing the source code in help buffer > and jumping to the defun is how much text is shown. In the help buffer, > source code is effectively "narrowed" to defun - no surrounding code is > shown. > > Best, > Ihor