From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Arthur Miller Newsgroups: gmane.emacs.devel Subject: Re: bug#36767: 26.1; request: add more quick keys to the *Help* buffer Date: Sun, 26 Sep 2021 18:11:31 +0200 Message-ID: References: <83y27nvnb4.fsf@gnu.org> <83ilyrvgda.fsf@gnu.org> <83h7ebv39d.fsf@gnu.org> <838rznusle.fsf@gnu.org> <87a6k2nlr6.fsf@mail.linkov.net> <83mto2rlyz.fsf@gnu.org> <83bl4hrxtu.fsf@gnu.org> <837df4r99m.fsf@gnu.org> <83wnn4pqo5.fsf@gnu.org> <5c5bc55d-13d2-af16-52d6-6fb2406b01ab@gmx.at> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35992"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org, larsi@gnus.org, juri@linkov.net To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 26 18:12:24 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mUWlK-0009AI-0e for ged-emacs-devel@m.gmane-mx.org; Sun, 26 Sep 2021 18:12:24 +0200 Original-Received: from localhost ([::1]:39354 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUWlI-000831-VT for ged-emacs-devel@m.gmane-mx.org; Sun, 26 Sep 2021 12:12:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41896) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUWkc-0007N6-TH for emacs-devel@gnu.org; Sun, 26 Sep 2021 12:11:38 -0400 Original-Received: from mail-oln040092071018.outbound.protection.outlook.com ([40.92.71.18]:29417 helo=EUR03-DB5-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUWkZ-0004Ca-Os; Sun, 26 Sep 2021 12:11:38 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hzuVUMg9Wxi692WKl/OGZuiPUIs864RHCBNWgimu8W1FdK7/6fEDVbirJpc0vNGnriGEhQ86yc8nEAX0ZTJa5BPDw2Drogih3H0SWHSfUj3s/xSH3kGoMQ3854pS9Zt1pz9B09p2W3PRVyfZAUb0VNq8Z7kRUZwgnKsoXH0bSDBlr2QIITE99pT0QfxZogFY+6aWgt87BP/80Ti5tlGzOZ74OGVCTXSFih2P2Ok7UGGf8MUBMGwBHekw4wgCvzB7YD9cBMKMzH71KzvALNrKtGt+PFS2b4r+9pYtSt7KFOnPp46BMHl/Gh3WedBOPu2H8fMEjrX95PJ68IZxJSFUjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=uMLfeRYnGf8abqXPY3MzR5pJHhwPDOGCBe0gVXXzp3Y=; b=WSYnsDa3353VxMQT2t2G+07+9gQG1wdszVdSxC2XQbXiq2jhWJgreE3wHfWUdUpyPra4TWXeg+yYTGq1AY5tzjXP+yX26QOVaKN+nG1qpGUwWu7uYjX+UddkqB4ukSt//d8kOAtWtFSf2Skl7X07Rxwu/soQgSn71jKGjeqBJpGbpIhogMQfSh/AkTzFW16d9eehAAWmjg9Q33J+X1VvTzOGuMA69hLS67WutPrY0cma/BrH2mOlIPNzwTUEvK65SvRkVO+e2hr3PtL3uAZp3xsct723qDnLJ7AzUxgFGTjbRXevfA8YPwDQT4XDcSHiGgR1Ni47jswJywGfMVmWSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uMLfeRYnGf8abqXPY3MzR5pJHhwPDOGCBe0gVXXzp3Y=; b=H5XvClett/uQuE2iveZUarNT2CTI4qR858YwFPUPm55GXiRJRLefZir56OfT0MnpE7kfSxCjwMlRt9oNfmqQzVBKzalLmHMygB8pgy+Brl4E/YxulP7+ZMs2D4rl5XXE/Guek4MapLmL/e7K0eh18i1RajcmxqWteNN+c2dXnabO5Nfd4nVK+RyilvBCA42PmYXJoA91ygXPbJFI6nj1y7ClAly0jYcXJ0C/xmsDKJ2iHMQwj+0wLE38Y+a2x/G6T1rq0SJ5aA6ihFbiGXAjyPhmSeZAuZH/v6dUssQ05ViVf3j7oPEdj78Vm72u7CPY3mbwzhbdA/wL+DCQvZnF1A== Original-Received: from AM9PR09MB4977.eurprd09.prod.outlook.com (2603:10a6:20b:304::20) by AM9PR09MB4802.eurprd09.prod.outlook.com (2603:10a6:20b:2de::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13; Sun, 26 Sep 2021 16:11:33 +0000 Original-Received: from AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::c55c:ece5:bed2:a9dc]) by AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::c55c:ece5:bed2:a9dc%9]) with mapi id 15.20.4544.021; Sun, 26 Sep 2021 16:11:33 +0000 In-Reply-To: <5c5bc55d-13d2-af16-52d6-6fb2406b01ab@gmx.at> (martin rudalics's message of "Sun, 26 Sep 2021 11:11:50 +0200") X-TMN: [rrn71MHFdjwyt3FLUd/h3hhLXAImIR5Y] X-ClientProxiedBy: BE0P281CA0005.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:a::15) To AM9PR09MB4977.eurprd09.prod.outlook.com (2603:10a6:20b:304::20) X-Microsoft-Original-Message-ID: <87mtnzfhak.fsf@live.com> X-MS-Exchange-MessageSentRepresentingType: 1 Original-Received: from pascal.homepc (81.232.177.30) by BE0P281CA0005.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.8 via Frontend Transport; Sun, 26 Sep 2021 16:11:32 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6a07f972-0714-4d57-7cea-08d981084e83 X-MS-TrafficTypeDiagnostic: AM9PR09MB4802: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DPdHRFTS4b8oxl1UUh/MiqVg5k/528EreuAj1xnx+hNvAhBVr+VdN8/MFdUD0cY5wxe5p+D6H8a9ZXIS/8oGXkU3FNJypU3/zrqODKXK65FjQMnlDn9XmfuP13RNmuMtCKK+YVHrMoWikRRITU5FVVCH81N3RyyhuDoShDLEiuRKCuetHxvZrE5PSc9AFzFclgHeb+3QGNe5GUx9p6U4ZSkA2QUYW+zTqBpk5MlMfxMmmSXJvdVa1dRCl0ClFdoy11aESc3EqgZ0+z5wT2OgtEkLnp2Teuu6UNNKsYinwfC8gg7LTejoIiGUvJOqw31bpVAHgobxzQhb/OEcrxM9T9gaCOggbLNIysvTauobKkWM/jSRXATdI35E3injWEKm51VlMoAALo9VoSMBQAykvgc6JrZKMZxF0h7FeiLptjaHr+h+UIQLsjqzvnVD1aJL X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: +PMc+J4b26acUxxv5edMAaUyhfwRjG4CcbG+/MRfqaqeH+OfVZ4V5tjtQN8WgOPpLqqh+8KvySRp81KskQgRcMmHZc1jJDvhoPVfGC25KsBMSn6UAa1VV287YDOOCtml2ESUWbFExy1MDVcaxaoUpw== X-OriginatorOrg: sct-15-20-3174-20-msonline-outlook-72e6e.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 6a07f972-0714-4d57-7cea-08d981084e83 X-MS-Exchange-CrossTenant-AuthSource: AM9PR09MB4977.eurprd09.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2021 16:11:32.9922 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR09MB4802 Received-SPF: pass client-ip=40.92.71.18; envelope-from=arthur.miller@live.com; helo=EUR03-DB5-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275517 Archived-At: martin rudalics writes: > here.+ (if (get-buffer-window (help-buffer)) > + (let ((help-window (get-buffer-window (help-buffer)))) > + (unless (window-dedicated-p help-window) > > Please use an idiom like > > (when (get-buffer "*Help*") > (let ((help-window (get-buffer-window "*Help*"))) > (when help-window > ... > > instead. I agree, but I don't like to see hardcoded *Help* string all over the place. I don't think it will change in near future, if ever, but since I have used this in several places, and plan to suggest some other commands for help buffer, I think we can abstract it even further into something like this: #+begin_src emacs-lisp (defun help-window () "Return help-buffer window or nil help-buffer is not currently displayed." (when (get-buffer "*Help*") (get-buffer-window (get-buffer "*Help*")))) (defmacro with-help-buffer (&rest body) "Execute the forms in BODY with HELP-BUFFER temporarily current. BODY will be executed onlu if HELP-BUFFER is displayed in a live window on the screen." (declare (indent 1) (debug t)) `(when (help-window) (with-current-buffer (help-buffer) ,@body))) #+end_src I see some problems with the latest patch I sent to Eli last night. I don't understand why it worked last night, but does not work today :), but I have probably had somewhere some state that I evaled, while I was tested. I can add those two and rework patch to use them when I am done with it. It loosk cleaner in those interactive commands.