From: Arthur Miller <arthur.miller@live.com>
To: martin rudalics <rudalics@gmx.at>
Cc: Eli Zaretskii <eliz@gnu.org>,
emacs-devel@gnu.org, larsi@gnus.org, juri@linkov.net
Subject: Re: bug#36767: 26.1; request: add more quick keys to the *Help* buffer
Date: Sun, 26 Sep 2021 18:11:31 +0200 [thread overview]
Message-ID: <AM9PR09MB4977332A30ED33BD0F52561096A69@AM9PR09MB4977.eurprd09.prod.outlook.com> (raw)
In-Reply-To: <5c5bc55d-13d2-af16-52d6-6fb2406b01ab@gmx.at> (martin rudalics's message of "Sun, 26 Sep 2021 11:11:50 +0200")
martin rudalics <rudalics@gmx.at> writes:
> here.+ (if (get-buffer-window (help-buffer))
> + (let ((help-window (get-buffer-window (help-buffer))))
> + (unless (window-dedicated-p help-window)
>
> Please use an idiom like
>
> (when (get-buffer "*Help*")
> (let ((help-window (get-buffer-window "*Help*")))
> (when help-window
> ...
>
> instead.
I agree, but I don't like to see hardcoded *Help* string all over the place. I
don't think it will change in near future, if ever, but since I have used this
in several places, and plan to suggest some other commands for help buffer, I
think we can abstract it even further into something like this:
#+begin_src emacs-lisp
(defun help-window ()
"Return help-buffer window or nil help-buffer is not currently displayed."
(when (get-buffer "*Help*")
(get-buffer-window (get-buffer "*Help*"))))
(defmacro with-help-buffer (&rest body)
"Execute the forms in BODY with HELP-BUFFER temporarily current.
BODY will be executed onlu if HELP-BUFFER is displayed in a live
window on the screen."
(declare (indent 1) (debug t))
`(when (help-window)
(with-current-buffer (help-buffer)
,@body)))
#+end_src
I see some problems with the latest patch I sent to Eli last night. I don't
understand why it worked last night, but does not work today :), but I have
probably had somewhere some state that I evaled, while I was tested.
I can add those two and rework patch to use them when I am done with it. It
loosk cleaner in those interactive commands.
next prev parent reply other threads:[~2021-09-26 16:11 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AxtnEw.onqlxb7Mkpry.ig9TynsmAb80jvlU3CY7@freemail.hu>
[not found] ` <87mtrrq7t7.fsf@gnus.org>
[not found] ` <AM9PR09MB4977DAFB86D88A4714C1C64196A29@AM9PR09MB4977.eurprd09.prod.outlook.com>
[not found] ` <87pmt0qomh.fsf@gnus.org>
[not found] ` <AM9PR09MB49770845B0C1B7CBB331E68A96A39@AM9PR09MB4977.eurprd09.prod.outlook.com>
[not found] ` <87wnn7xbdg.fsf@gnus.org>
2021-09-23 22:18 ` bug#36767: 26.1; request: add more quick keys to the *Help* buffer Arthur Miller
[not found] ` <87eed0nsez.fsf@mail.linkov.net>
[not found] ` <83bl83zp5h.fsf@gnu.org>
[not found] ` <AM9PR09MB49779C8B93EFFB329EB8E5A596A29@AM9PR09MB4977.eurprd09.prod.outlook.com>
[not found] ` <83y27nvnb4.fsf@gnu.org>
[not found] ` <AM9PR09MB497767EDF180DE0C3EE15F4396A39@AM9PR09MB4977.eurprd09.prod.outlook.com>
[not found] ` <83ilyrvgda.fsf@gnu.org>
[not found] ` <AM9PR09MB497720FA603D3B7FC4D4739196A39@AM9PR09MB4977.eurprd09.prod.outlook.com>
[not found] ` <83h7ebv39d.fsf@gnu.org>
[not found] ` <AM9PR09MB49771D1ECD11701DEFB77C7A96A39@AM9PR09MB4977.eurprd09.prod.outlook.com>
[not found] ` <838rznusle.fsf@gnu.org>
2021-09-24 7:16 ` Arthur Miller
2021-09-24 15:31 ` Juri Linkov
2021-09-24 16:12 ` Eli Zaretskii
2021-09-24 19:36 ` Arthur Miller
2021-09-24 19:39 ` Arthur Miller
2021-09-24 19:57 ` Arthur Miller
2021-09-25 6:09 ` Eli Zaretskii
2021-09-25 14:41 ` Arthur Miller
2021-09-25 14:59 ` Eli Zaretskii
2021-09-25 16:22 ` Arthur Miller
2021-09-25 16:26 ` Eli Zaretskii
2021-09-25 17:08 ` Arthur Miller
2021-09-25 17:20 ` Eli Zaretskii
2021-09-25 20:15 ` Arthur Miller
2021-09-26 21:52 ` Arthur Miller
2021-09-26 9:11 ` martin rudalics
2021-09-26 16:11 ` Arthur Miller [this message]
2021-09-26 16:54 ` [External] : " Drew Adams
2021-09-26 21:51 ` Arthur Miller
2021-09-26 22:38 ` Drew Adams
2021-09-26 22:46 ` Arthur Miller
2021-09-26 17:51 ` martin rudalics
2021-09-26 21:48 ` Arthur Miller
2021-09-27 11:07 ` Exec help commands from other buffer (was bug#36767: 26.1; request: add more quick keys to the *Help* buffer) Arthur Miller
2021-09-27 19:59 ` Arthur Miller
2021-09-24 18:34 ` [External] : Re: bug#36767: 26.1; request: add more quick keys to the *Help* buffer Drew Adams
2021-09-24 19:34 ` Arthur Miller
2021-09-24 20:20 ` Arthur Miller
2021-09-24 20:33 ` Arthur Miller
2021-09-25 18:46 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM9PR09MB4977332A30ED33BD0F52561096A69@AM9PR09MB4977.eurprd09.prod.outlook.com \
--to=arthur.miller@live.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=juri@linkov.net \
--cc=larsi@gnus.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).