From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Arthur Miller Newsgroups: gmane.emacs.devel Subject: Re: Lazy wdired preprocessing - Question Date: Wed, 24 Mar 2021 21:52:15 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19513"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: monnier@iro.umontreal.ca Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 24 22:05:14 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lPAgk-0004xF-My for ged-emacs-devel@m.gmane-mx.org; Wed, 24 Mar 2021 22:05:14 +0100 Original-Received: from localhost ([::1]:39146 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPAgg-0002tJ-3p for ged-emacs-devel@m.gmane-mx.org; Wed, 24 Mar 2021 17:05:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48726) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPAUK-00072k-D6 for emacs-devel@gnu.org; Wed, 24 Mar 2021 16:52:24 -0400 Original-Received: from mail-oln040092064097.outbound.protection.outlook.com ([40.92.64.97]:2037 helo=EUR01-DB5-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPAUF-0005Uo-Kb for emacs-devel@gnu.org; Wed, 24 Mar 2021 16:52:22 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RkRJdKt40WRqT9ujwonPLgfjCOLQEhG9CMGjYqxXFxn+roCA5cTKER5HLxDCtqEahXL/tWCsmEmvrrxoeGRT5CTFeo3RFB0fLKui9uFLhIKtMIG06qyGXN7ruoZaQGmwpXKkl/n9x/jxEoIbbtyeVJ+jCp8ODRTo+jIEtkbm7IFr9Fmb4YVd7JT95r+EjX12YbuejAMYdRSxC0nhDdy6Jnq6H3Ug/So89R3WRAYcfnpKQB/vSmDo44rEoHBQ2enYPCPIz8GwIndn4HYnP5Mh3thHrae67YmnL+y+7ssBW49xFYk2odeqto8fxo8UY9zlXYJMVarRoAK7l7GSppVe7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8Ghr4WAURWChfxLJ1u5e8jRw/br9pAu7aIBjx6VIwpg=; b=j1JFeYuyfz1lUIhIUHqZCOMs88i652/4GkWWkFife8+t2bssJRVl+eVFZcpd9KoIvnvYjan/dNeFp0OWXgbnmVupRK3Bl+NJjc5POw4zZCw1vgdb7pgdYkzGW0rkIU3AcC3XMK/34SoeEWBPtZNa3uIBsHGNgkSYJwUN8P+Td1vhl+0Cy1XaGAJ387svqQdUXK7xcy9z6paOr/rMO+74EgaqAkuIVxz987Wryq2zzAkS6plJ/sXWqwG03CJp7d817x6eGKVdEQCNqikBHe1sx6pewcsTmZy1Q2Bm7h8Pc2lVMY9p71JIMfgGkYVd7/cn3cpDS6+jB4UmCMWcSDuoOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8Ghr4WAURWChfxLJ1u5e8jRw/br9pAu7aIBjx6VIwpg=; b=r+zZSwlQLHHmW99cH37fKb4kQ/089x48+u6BpgcLab0b+eWSVcMy2SCY5eIA0BjtWpNlEj/Fwd5GLWy2GJ3sqBL2+PDYTRE3ZVzRVspYEwYRnNOUBRHty8cUMBhmT8cRVoyTwTtYy5W/fi5wk8PUxzjBeibQGl5crHraO7TWehiqMGICTsI6i5Xno8SZyvhzp9aTtvMjV7m+Kb07iRuV0vVmKrghHsHShT7BLp9ijUBbDgDLYf+8lZEfj7agXI/6Qirz8GkO7WxAmRGxbJxdNza99p95cRRAiuKfvYf8tqeXxqQJ6QdTrpFAv9plkEtfmsrVxULdJe4LLUEkoxj+YQ== Original-Received: from DB5EUR01FT025.eop-EUR01.prod.protection.outlook.com (2a01:111:e400:7e1a::4b) by DB5EUR01HT178.eop-EUR01.prod.protection.outlook.com (2a01:111:e400:7e1a::500) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25; Wed, 24 Mar 2021 20:52:16 +0000 Original-Received: from AM9PR09MB4977.eurprd09.prod.outlook.com (2a01:111:e400:7e1a::49) by DB5EUR01FT025.mail.protection.outlook.com (2a01:111:e400:7e1a::240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25 via Frontend Transport; Wed, 24 Mar 2021 20:52:16 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:E96C24F1925CEA545BABECC4354008CE7982541EE6B3F595A448A62CA29A9E06; UpperCasedChecksum:194B352016A3B0B39DD6D541F2102E06F3938D7ADD4DD7406E3F3D93DF4EE043; SizeAsReceived:7486; Count:46 Original-Received: from AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::2103:e705:bc0c:5a8b]) by AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::2103:e705:bc0c:5a8b%6]) with mapi id 15.20.3977.025; Wed, 24 Mar 2021 20:52:16 +0000 In-Reply-To: (Arthur Miller's message of "Wed, 24 Mar 2021 21:20:29 +0100") X-TMN: [cgHCJq1GxXwKHC5GM3zh1CxdnoGryEeV] X-ClientProxiedBy: AM5PR0101CA0033.eurprd01.prod.exchangelabs.com (2603:10a6:206:16::46) To AM9PR09MB4977.eurprd09.prod.outlook.com (2603:10a6:20b:304::20) X-Microsoft-Original-Message-ID: <877dlwnukg.fsf@live.com> X-MS-Exchange-MessageSentRepresentingType: 1 Original-Received: from pascal.homepc (90.230.29.56) by AM5PR0101CA0033.eurprd01.prod.exchangelabs.com (2603:10a6:206:16::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25 via Frontend Transport; Wed, 24 Mar 2021 20:52:16 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 46 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 17b82650-43a5-478c-4fd6-08d8ef06b540 X-MS-TrafficTypeDiagnostic: DB5EUR01HT178: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eDcZ7VD866sEMZOf73CjizWC/Vc2nrghAavUKaRB7aXT3Wr9UAS0COShcZsmGwYBehunkXVXfohUuBJIasLlYKJJJAGWvQTSWt+vRh9HTW54lDJo6xEtvMJModxiP+TXcWQdLV0Y115Sg6vbWR/NUMEh86+DnNXn6I7TKhJmO/3Y1LkQbiZnUPlaSyzB+3Mk5ynfpNP8OtC9JcohUU488JiVN8bnHjU++Io+U2iBCLKMedcsZY1W5SAuKB2gERvEF+RbmyZOdNmWn5UAjkfQXf2CSiZ1EdoHog7/7Ovu6PaPfSIYqfc7F69ZpQj/HOZ3lOybEQJaRYLj5H6N7SOrGMgvx4aTAyTo6YPu+S+CzZ9K2jvnnhRdK7H1TbbCbwFx X-MS-Exchange-AntiSpam-MessageData: ac1WVPw65Gprbk7Ohuv14oUaiufZZVjgpItdDe9RST+FtT6SblhkaEh4qPx4hZpZNbYbXxWx3ZyWaEt26UcbXqErq/YmuHMage9nO7FHiAn7A4HQkQ8gfPATSGDJqwng+CVD+Izy5XeJgcvA9D0dBA== X-OriginatorOrg: live.com X-MS-Exchange-CrossTenant-Network-Message-Id: 17b82650-43a5-478c-4fd6-08d8ef06b540 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2021 20:52:16.5157 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: DB5EUR01FT025.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5EUR01HT178 Received-SPF: pass client-ip=40.92.64.97; envelope-from=arthur.miller@live.com; helo=EUR01-DB5-obe.outbound.protection.outlook.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266984 Archived-At: Arthur Miller writes: I have forgott to say, I did make use make bootstrap before building Emacs. > I hope I don't bother, too much. > > There is some problem I see when building Emacs with the patch: > > It builds fine, but when I test it, it seems that I need to re-eval > after Emacs started wdired.el in order to get it to work properly. What > happeneds it that Emacs seems to run self-insert command upon entering > wdired mode anyway, despite being build with patched wdired. > > However when I eval my working file "lazy-wdired.el" it works fine. The > code is identical as one in the patch. > > I also noticed when I unload-feature lazy-wdired, so I unload all those > wdired definitions, and if I eval patched wdired.el from lisp directory which I > built Emacs with, everything also works correctly too. > > I am little bit confused, why do I need to re-evaluate wdired.el in a > freshly patched and recompiled Emacs to get this to work? > > > > -------------------- Start of forwarded message -------------------- > From: Arthur Miller > To: emacs-devel@gnu.org > Subject: Patch: Lazy wdired preprocessing > Date: Tue, 23 Mar 2021 15:52:08 +0100 > > The original thread seems to have become more of a lisp language thread, > so to make it easier, I made a new one, with more descriptive name. > > Attached is new a version of patch. Seems to correctly work with > permissions now. I have also discovered (current-column) function so I > no longer calculate columns in my own code :-). > > I have tested on my ext4 file system where my normal system is > installed, and there it works correctly. > > I have also tested on one NTFS drive, where I can not change permissions > normally and there is following behaviour, don't know if it is > acceptable or not: > > In wdired buffer I can seemingly change permission, but when I save > buffer, then permission is of course not saved and reverted dired buffer > shows correct permission. In Dolphin, it seems to work similar (I can > set pulldown menu in permissions dialog to only read, and press OK, but > it is not saved). > > There is also a question what happeneds when one have an empty folder > and switches to wdired buffer. I don't see it handled in old wdired, so > I have added an error condition for that in > wdired-change-to-wdired-mode. > > Please test it, there might be some other test condition I haven't > tested. I am attaching both the working file for easy evaluation and > test, and the patch. > > best regards > /a > > > > -------------------- End of forwarded message --------------------