From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Arthur Miller Newsgroups: gmane.emacs.devel Subject: Re: Patch proposal: display symbol source code in help buffers Date: Mon, 20 Sep 2021 20:13:41 +0200 Message-ID: References: <83bl4n3hys.fsf@gnu.org> <87fstz3g6z.fsf@no.workgroup> <9ada9a31-4e44-7941-e9a2-ada86ba4e36e@gmx.at> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4830"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 20 20:15:08 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mSNok-0000lC-VJ for ged-emacs-devel@m.gmane-mx.org; Mon, 20 Sep 2021 20:15:03 +0200 Original-Received: from localhost ([::1]:45004 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSNoj-0003p6-Iv for ged-emacs-devel@m.gmane-mx.org; Mon, 20 Sep 2021 14:15:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58152) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSNnb-00038f-2y for emacs-devel@gnu.org; Mon, 20 Sep 2021 14:13:52 -0400 Original-Received: from mail-oln040092065081.outbound.protection.outlook.com ([40.92.65.81]:30209 helo=EUR01-HE1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSNnW-0002xN-Di for emacs-devel@gnu.org; Mon, 20 Sep 2021 14:13:50 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K5BoX5rVv19e3JzHQM0M4BSw5/htMUxuQYgJs6ye7LJ3c90cCad7BCjngNVAenGYrrM1MUnlNr+nwc9Az5u90RRfYiTZewN97GvpChkqXbNETk8e4nvN5m8r9eDwxvv8eGGPgRDF5x+pxoeCZi1t5qhVRHlR4Xu33ZiHpGwLgABxtnYEPqHA8QzKKHnJMV+uthyhsA65JZltvOmBuRIO3sRRGtEg7ge/fmrkrx5dJL6Q3A72feQEKGFVc3e8389lshjh7a9x/Y5ffcYD+yqdwZI5XI9v8qLAZa5Qn9MwPHbafvzXYQHaPkIUBLTwbqLTv4dUaWgJmNx1cRKth4xlkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=wLj053A+UV26jKBINqhdU6zx8p+6Vklp04JDI5x8ZfA=; b=hWmIFTSVTukOcEn0RZZj3JFIlTKEYw+EKrtIUdZ9M+JmtNxbIHEQXBwB4EidNPCWnIdIbLKU8g087OIZGhucqvyGx/qv8pO/hllasHC/eyi9/loBV5ObJ3D2pRjdl8ERMC0NUMvP0pPEJUvPMWq1ns4Ql9YwsHMdrEjJ0h0QTXC23YEVB+Spc98I1Xf1rQkY2a1IovRrvy99x80JXu9vWrwT2laT2za9z2RYtE/KQDBXxnZAGWapqMkb4BnhI+KpiAje9B63w94ZgL0QV1t8TBBBT9u1jDvKzX4PZ8GZMI1Sywus9YCLf5lQZ+sRGchWcLsKSzMDoAP6iDHipXPRpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wLj053A+UV26jKBINqhdU6zx8p+6Vklp04JDI5x8ZfA=; b=S+Djc0WzvszU1wve3/qu4lcXOsnWH3v6xGoKrveycSi095861w+tNm29DPe/4tBat5gf+PAifMM0oFRhXu976U2cd36Pq21586vz1I19ymK+cocUlsib0Z44Jo/U3qBzNR+1e60LM1rcCMlc0Ad5+bOCXTYI/62n7wrAcEG5oyVhT98fqgfj6T00SsazSuqcCd8V+S/sDgkSQ5lT4URX37vW8eO87dOIdRfgU5Z3IDdSmS0pnr25fu0ZLJpG//Y5pstdp0RrYtULhCKVqbBn0/XRnOADP6eJxdCf7GzypxxOgmLDVLAUAtYyT6a5Jr1zPiPswccJPMI33Hrq+AE6GA== Original-Received: from AM9PR09MB4977.eurprd09.prod.outlook.com (2603:10a6:20b:304::20) by AM0PR09MB2772.eurprd09.prod.outlook.com (2603:10a6:208:124::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Mon, 20 Sep 2021 18:13:42 +0000 Original-Received: from AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::c55c:ece5:bed2:a9dc]) by AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::c55c:ece5:bed2:a9dc%9]) with mapi id 15.20.4523.018; Mon, 20 Sep 2021 18:13:42 +0000 In-Reply-To: <9ada9a31-4e44-7941-e9a2-ada86ba4e36e@gmx.at> (martin rudalics's message of "Mon, 20 Sep 2021 10:21:59 +0200") X-TMN: [BP4lj25dwCwOG8JGe+Kve04WR7/JZ+R2] X-ClientProxiedBy: AS9PR06CA0314.eurprd06.prod.outlook.com (2603:10a6:20b:45b::16) To AM9PR09MB4977.eurprd09.prod.outlook.com (2603:10a6:20b:304::20) X-Microsoft-Original-Message-ID: <87v92vjesq.fsf@live.com> X-MS-Exchange-MessageSentRepresentingType: 1 Original-Received: from pascal.homepc (81.232.177.30) by AS9PR06CA0314.eurprd06.prod.outlook.com (2603:10a6:20b:45b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Mon, 20 Sep 2021 18:13:41 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5667b299-7a8f-4b32-b6a8-08d97c6260a8 X-MS-TrafficTypeDiagnostic: AM0PR09MB2772: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: v5wWVZYglpia7fsUUWAt8Iz+2BRWBQBrBIuDMO8x6JrEm0rOwB8KN4v8mA0pNKDoRzzNbqfqbyjHYvvoOdAMKj2EKF+KywJHb3S4qfjfwfhSIS8j3MBTwKljhjvS7GJvAfEUc6WimA269NG10SyOzU4tS8zHe8qApHM9fUgu47NqK/miP3vCm1SYCCniSwwOs6TZnIAF/W7/bohcRhIpY38DbrLun+CcSds0MkI264USkQ0Mv0Sc8ZD3IYYOYCXKPncNbKRQotjHKP4WukXlk59TfNIiOya+PgIOQ7ljlbkAhtbLvo2g1Z7iarRjIOoAa1hXTGggF/HA93yudqmxCyNPsw5OHUEJQLWunfrZMADWhsOkSno15WA5/5QKDVb70JPaU1togBTQhRO2SbAaHB4jfYpxrQ6To2ksGhjDHNZFzQExqqqFp+M1WLbCZNdw X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: VqNlC6ij7i5u+dKPwxY3YwSKEP5CCCv/zNdRABKjPicwAOuVgkGYkhMrFj/EhprQ6zU/CMNeDm1VatWdgOU4hKw8yQ114IMGd3xB/cSkRzyRA33S30FqjkNIBOWtVvud8wF4ukzj5Wyrh1vbkpCVxg== X-OriginatorOrg: sct-15-20-3174-20-msonline-outlook-72e6e.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 5667b299-7a8f-4b32-b6a8-08d97c6260a8 X-MS-Exchange-CrossTenant-AuthSource: AM9PR09MB4977.eurprd09.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2021 18:13:42.5072 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR09MB2772 Received-SPF: pass client-ip=40.92.65.81; envelope-from=arthur.miller@live.com; helo=EUR01-HE1-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275161 Archived-At: martin rudalics writes: >> Lastly hitting the `s' key opens another buffer in another >> window (at least for me) and (also at least for me), at >> surprising locations in my frame. I have a UHD monitor and, >> at least the way I configured it, emacs opens up to 4 >> windows, the help buffer and the source buffer not >> necessarily adjunct. All 4 windows can carry 92 lines, so >> there is plenty of room below the text in the help buffer to >> show more info. > > If you fit the window showing *Help* to its buffer, there is no room > left. It would be nice to make it fit to N lines in height, and C columns in width, i.e. to make it fit to certain size. > . Where to pop up the location of the source and how to get rid of > it is a question we currently discuss in Bug#9054 and Bug#36767. There are so many discussions here so I wasn't following those. I really don't know what you have discussed there. I come to this from my own needs. > If and > when we reach a consensus there, we can add an option to immediately > display the source in the *Help* buffer or a window right below it (IIRC > a C source wouldn't be always available though). This shouldn't be by any mean in collision what you are saying here. What you describe, as I understand it, is to display source on-demand, in help buffer, which would be very nice too. What I have done is to display by global switch. It would be still useful to have on-demand display when global switch is off, and it would be trivial to re-build the patch to include that. I can rebuild and send new one. I have found a bug and I need to rebuild-it anyway. I can also refactor it and add an interactive function that can be boudn to a key to display only sources in help buffer. And if global switch is on, and sources are requested, it can function as a "narrow" button, i.e. fit only symbol source to the help buffer. Would that be interesting? Honestly, I dislike to display both help and entire source, because there is a duplication of the doc string. I was always disturbed by this duplication in helpful too. So I have experimented to display only the body of the function, but I don't think that looked very nice either. There is a bug repport I did about 'narrow-to-defun', and the help-mode.el I posted there, shows C sources narrowed only to it's function body.