From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: master 2de25accaf 4/4: Warn about `condition-case' with quoted condition names Date: Thu, 29 Dec 2022 16:50:37 +0100 Message-ID: References: <167231424264.29966.177874348975736593@vcs2.savannah.gnu.org> <20221229114403.7EA13C05F48@vcs2.savannah.gnu.org> <95039AA3-39F9-4EFF-BEA2-695E8AB883C3@acm.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15883"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 29 16:51:26 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pAvBm-0003wy-08 for ged-emacs-devel@m.gmane-mx.org; Thu, 29 Dec 2022 16:51:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pAvBA-0007bI-Ka; Thu, 29 Dec 2022 10:50:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAvB8-0007ag-Oh for emacs-devel@gnu.org; Thu, 29 Dec 2022 10:50:46 -0500 Original-Received: from mail238c50.megamailservers.eu ([91.136.10.248] helo=mail56c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAvB6-0001Bf-Rd for emacs-devel@gnu.org; Thu, 29 Dec 2022 10:50:46 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1672329040; bh=tjX8frzvsVLqdKYJBdEPVbjaaQOegz1Tzzbv4fSVSHM=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=lC4rX8KgiACKKT+h6T7vfEgBe7sEUuOAVimNJM820p19kVeLjzSLSqDQGlHDyMkXd 9T9F8wpHHjtOUnPX9rwFPxRiXHFpDmAQcWVbW7ivuve8KZjtbyd7eP9WbYVDalNn7G l2EK87/WVVp/5c7uR4SJeJt4fokiAUnn4yMHndW0= Feedback-ID: mattiase@acm.or Original-Received: from smtpclient.apple (c188-150-171-209.bredband.tele2.se [188.150.171.209]) (authenticated bits=0) by mail56c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 2BTFobmW081786; Thu, 29 Dec 2022 15:50:39 +0000 In-Reply-To: X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A782F1D.63ADB750.0018, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE Received-SPF: softfail client-ip=91.136.10.248; envelope-from=mattiase@acm.org; helo=mail56c50.megamailservers.eu X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302037 Archived-At: 29 dec. 2022 kl. 16.33 skrev Stefan Monnier : >> But do we know all errors statically at compile-time? >=20 > Error identifiers should have an `error-conditions` property. You left the `error-conditions` property check commented out in = `byte-compile-condition-case` so maybe it wasn't quite that = straightforward?