From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Victor Orlikowski Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fixes to allow erc-dcc-get-filter to work properly Date: Sun, 10 Feb 2019 16:07:51 +0000 Message-ID: References: <837eear9qj.fsf@gnu.org> <4BFA0AFA-B49E-4CEC-BF76-97567DE9CF31.notmuch@neverland> <83lg2pnveh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="109863"; mail-complaints-to="usenet@blaine.gmane.org" Cc: "emacs-devel@gnu.org" To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 10 17:08:40 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gsrep-000SQa-G1 for ged-emacs-devel@m.gmane.org; Sun, 10 Feb 2019 17:08:39 +0100 Original-Received: from localhost ([127.0.0.1]:60955 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gsreo-0005WN-GI for ged-emacs-devel@m.gmane.org; Sun, 10 Feb 2019 11:08:38 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36005) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gsre6-0005WI-HK for emacs-devel@gnu.org; Sun, 10 Feb 2019 11:07:55 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gsre5-0007qA-U3 for emacs-devel@gnu.org; Sun, 10 Feb 2019 11:07:54 -0500 Original-Received: from smtp-gw-18.oit.duke.edu ([152.3.189.244]:48624 helo=mail-gw-18.oit.duke.edu) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gsre5-0007pS-P8; Sun, 10 Feb 2019 11:07:53 -0500 Authentication-Results: mail-gw.oit.duke.edu; spf=none smtp.mailfrom=vjo@duke.edu; dmarc=none Original-Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02lp2056.outbound.protection.outlook.com [104.47.36.56]) by mail-gw-18.oit.duke.edu (8.16.0.27/8.16.0.27) with ESMTPS id x1AG7pTu010925 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Sun, 10 Feb 2019 11:07:52 -0500 Original-Received: from CO2PR05MB2488.namprd05.prod.outlook.com (10.166.95.146) by CO2PR05MB2632.namprd05.prod.outlook.com (10.166.200.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1622.12; Sun, 10 Feb 2019 16:07:51 +0000 Original-Received: from CO2PR05MB2488.namprd05.prod.outlook.com ([fe80::b10c:f1aa:5c08:17f7]) by CO2PR05MB2488.namprd05.prod.outlook.com ([fe80::b10c:f1aa:5c08:17f7%2]) with mapi id 15.20.1622.013; Sun, 10 Feb 2019 16:07:51 +0000 Thread-Topic: [PATCH] Fixes to allow erc-dcc-get-filter to work properly Thread-Index: AQHUu+iAz1YjTNoSkkK0QXoy4+2WEKXVkMKPgADq1ACAAMZugIAB+64A In-Reply-To: <83lg2pnveh.fsf@gnu.org> Accept-Language: en-US Content-Language: en-US x-originating-ip: [50.111.87.13] x-clientproxiedby: BN4PR12CA0020.namprd12.prod.outlook.com (2603:10b6:403:2::30) To CO2PR05MB2488.namprd05.prod.outlook.com (2603:10b6:102:10::18) x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CO2PR05MB2632; 20:mwFiH2h1DtrEKS/CSoDwWvph0NJI1rimRXD+taNDjxgMzfCWmdevA4qMJZM4YbdPyqQAFzxTWzw7akMdQ+9lfM84rQX9K1fefdyj7LfEXDarmvQXFRbf6C658uVUoZlobw5olZTwlsWvGHXVzPnI4zzLL9jYT37iT1Z9kuDYMbk= x-ms-office365-filtering-correlation-id: d44626a1-d5bc-4561-fe40-08d68f71e817 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600110)(711020)(4605077)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:CO2PR05MB2632; x-ms-traffictypediagnostic: CO2PR05MB2632: x-microsoft-antispam-prvs: x-forefront-prvs: 09443CAA7E x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(7916004)(346002)(366004)(376002)(396003)(136003)(39860400002)(199004)(189003)(6506007)(478600001)(14444005)(4744005)(25786009)(88552002)(97736004)(6346003)(68736007)(486006)(14454004)(476003)(6916009)(256004)(3846002)(386003)(7736002)(450100002)(33716001)(305945005)(26005)(102836004)(4326008)(6116002)(75432002)(106356001)(105586002)(33896004)(2906002)(52116002)(99286004)(316002)(786003)(66066001)(86362001)(71190400001)(6512007)(9686003)(6436002)(8936002)(71200400001)(446003)(81166006)(81156014)(6246003)(11346002)(186003)(8676002)(93886005)(76176011)(229853002)(53936002)(6486002); DIR:OUT; SFP:1102; SCL:1; SRVR:CO2PR05MB2632; H:CO2PR05MB2488.namprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: duke.edu does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: lQdC1mU1gGJLMcSoBU7qkWjGqAeweUY7Naiuqpf+GKGnx2/HQf/Cgs5mS01g6dkHrAzLWJ4BKboG+SHhOC/0Ldffg/nKCDVn/gIl7ss1/ocOPeTO8f7Pezd/4sZBxTjrSP4sXLkFFXmXDN/B+IIelxkirvlvEjOGKsaWrkpBPfIUEtmzzBHciEQjlVBl5NursHCJBKroOWjSiN1QRsJyds8ml9h94xCwFH/UGkf3St2kQKFUS8Yn5YSPAZdwFKHcLihVhH4c2Dl0QTWABlrLTwNUsR4sxceL5Xldbp0jnPJeAzzittACS4scVWwLcDuBk03+0sDzalYZxAckvpi675qb2IVgJNC8oNKLObqyO4NOq317BBF7uJjvCYj7uqcsTjSLz3A+OGwhGNGCu+2nyxWOYFdaCGn53PegkhPf9Ck= X-OriginatorOrg: duke.edu X-MS-Exchange-CrossTenant-Network-Message-Id: d44626a1-d5bc-4561-fe40-08d68f71e817 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2019 16:07:50.4654 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: cb72c54e-4a31-4d9e-b14a-1ea36dfac94c X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR05MB2632 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-02-10_14:, , signatures=0 X-Proofpoint-Spam-Reason: safe X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 152.3.189.244 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233191 Archived-At: On Sat, Feb 09, 2019, at 04:49 AM, Eli Zaretskii wrote: > As you see, the process whose filter is erc-dcc-get-filter is set up > so that the name of its process-buffer is derived from > erc-dcc-file-name, but I don't see the buffer-file-name of that buffer > being set anywhere. If I'm right, then your change should use > buffer-name (the function) instead of buffer-file-name. Can you > verify that buffer-name returns the name of erc-dcc-file-name, and > that using that return value resolves the problems you saw? I can confirm that using '(buffer-name)' instead of 'erc-dcc-file-name' works *perfectly*. Shall I submit a new patch, using that instead? Thanks, Victor --=20 Victor J. Orlikowski <> vjo@(ee.|cs.)?duke.edu