unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: "'CHENG Gao'" <chenggao@gmail.com>, <emacs-devel@gnu.org>
Subject: RE: Info about color-values need be revised
Date: Sun, 16 Aug 2009 08:30:53 -0700	[thread overview]
Message-ID: <AD12392D509C4AE9A95DEE99ECDC77DC@us.oracle.com> (raw)
In-Reply-To: <m2prawkquy.fsf@cyberhut.org>

> In ELISP manual, info about color-values is not true any more with NS
> port merged. It says return value is (R G B).
> 
> In NS port, color-values uses function xw-color-values:
> The return value is (R G B Alpha).

Ouch! Why is that? Why does a platform-specific function change the meaning of a
generic function that way? And why should the generic function's signature be
changed accordingly (breaking existing code)?

Code that uses `color-values' depends on its return value being a 3-element
list. That includes any NS code that uses `color-values' (as opposed to
`xw-color-values'). Seems like any NS code that needs the Alpha info should call
`xw-color-values' directly (or some other NS-specific function) - and
`color-values' should be left alone.





  reply	other threads:[~2009-08-16 15:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-16 10:14 Info about color-values need be revised CHENG Gao
2009-08-16 15:30 ` Drew Adams [this message]
2009-08-16 17:32   ` CHENG Gao
2009-08-19  3:47   ` YAMAMOTO Mitsuharu
2009-08-19  4:22     ` David Reitter
2009-08-19  4:57       ` YAMAMOTO Mitsuharu
2009-08-19 13:18     ` Stefan Monnier
2009-08-19 13:39     ` Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AD12392D509C4AE9A95DEE99ECDC77DC@us.oracle.com \
    --to=drew.adams@oracle.com \
    --cc=chenggao@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).