unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: master 0910230be6e: ; Prefer HTTPS to HTTP in more links
       [not found] <20230802214156.1EF72C038BC@vcs2.savannah.gnu.org>
@ 2023-08-03  5:56 ` Ruijie Yu via Emacs development discussions.
  2023-08-03  6:37   ` Yuri Khan
  0 siblings, 1 reply; 8+ messages in thread
From: Ruijie Yu via Emacs development discussions. @ 2023-08-03  5:56 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: emacs-devel

Hello Stefan,

I believe there are some places where you modified, where http is indeed intended rather than https.  For example, doc/misc/org.org tries to tell readers that Org supports many protocols, one of which is http. 

--
Best, 


RY

> On Aug 3, 2023, at 05:42, Stefan Kangas <stefankangas@gmail.com> wrote:
> 
> branch: master
> commit 0910230be6ee858d8d8849a1fc9559bfd163dc38
> Author: Stefan Kangas <stefankangas@gmail.com>
> Commit: Stefan Kangas <stefankangas@gmail.com>
> 
>    ; Prefer HTTPS to HTTP in more links
> ---
> ChangeLog.4                     |  4 ++--
> doc/misc/org.org                |  8 ++++----
> doc/misc/tramp.texi             |  2 +-
> doc/misc/url.texi               | 10 +++++-----
> lisp/ChangeLog.16               |  3 +--
> lisp/emacs-lisp/oclosure.el     |  2 +-
> lisp/erc/erc-nicks.el           |  2 +-
> lisp/net/newst-backend.el       | 12 ++++++------
> lisp/net/newsticker.el          |  4 ++--
> lisp/nxml/nxml-maint.el         |  2 +-
> lisp/obsolete/iswitchb.el       |  2 +-
> lisp/term.el                    |  2 +-
> lisp/textmodes/less-css-mode.el |  2 +-
> lisp/textmodes/remember.el      |  2 +-
> lisp/textmodes/rst.el           |  2 +-
> src/ChangeLog.12                |  2 +-
> src/w32fns.c                    |  4 ++--
> src/w32term.h                   |  2 +-
> 18 files changed, 33 insertions(+), 34 deletions(-)
> 
> diff --git a/ChangeLog.4 b/ChangeLog.4
> index 9d64446d68e..372b03b32b2 100644
> --- a/ChangeLog.4
> +++ b/ChangeLog.4
> @@ -116226,7 +116226,7 @@
> 
>    Do not quote lambda expressions
> 
> -    http://emacs.stackexchange.com/a/3596
> +    https://emacs.stackexchange.com/a/3596
> 
>    Quoting lambda expressions is at best redundant and at worst
>    detrimental; this commit removes all use of the sharp-quote to reduce
> @@ -116960,7 +116960,7 @@
> 
>    This change follows the regexp for require on emacs truck. See line
>    2327 on font-lock.el in the following patch.
> -    http://bzr.savannah.gnu.org/lh/emacs/trunk/revision/111821
> +    https://bzr.savannah.gnu.org/lh/emacs/trunk/revision/111821
> 
> 2013-09-04  John Wiegley  <johnw@newartisans.com>
> 
> diff --git a/doc/misc/org.org b/doc/misc/org.org
> index d8bbcb4d0c5..5562a13a005 100644
> --- a/doc/misc/org.org
> +++ b/doc/misc/org.org
> @@ -3284,7 +3284,7 @@ options:
> 
> | Link Type  | Example                                                  |
> |------------+----------------------------------------------------------|
> -| http       | =http://staff.science.uva.nl/c.dominik/=                 |
> +| http       | =https://staff.science.uva.nl/c.dominik/=                 |
> | https      | =https://orgmode.org/=                                   |
> | doi        | =doi:10.1000/182=                                        |
> | file       | =file:/home/dominik/images/jupiter.jpg=                  |
> @@ -3619,7 +3619,7 @@ replacement text.  Here is an example:
> 
> #+begin_src emacs-lisp
> (setq org-link-abbrev-alist
> -      '(("bugzilla"        . "http://10.1.2.9/bugzilla/show_bug.cgi?id=")
> +      '(("bugzilla"        . "https://10.1.2.9/bugzilla/show_bug.cgi?id=")
>         ("Nu Html Checker" . "https://validator.w3.org/nu/?doc=%h")
>         ("duckduckgo"      . "https://duckduckgo.com/?q=%s")
>         ("omap"            . "https://nominatim.openstreetmap.org/search?q=%s&polygon=1")
> @@ -20693,8 +20693,8 @@ adding ~:rewrites~ rules like this:
> 
> #+texinfo: @noindent
> Since =example.com/$= is used as a regular expression, it maps
> -=http://example.com/=, =https://example.com=,
> -=http://www.example.com/= and similar to
> +=https://example.com/=, =https://example.com=,
> +=https://www.example.com/= and similar to
> =/home/user/example/index.php=.
> 
> The ~:rewrites~ rules are searched as a last resort if and only if no
> diff --git a/doc/misc/tramp.texi b/doc/misc/tramp.texi
> index e518330c9b0..291d6600af5 100644
> --- a/doc/misc/tramp.texi
> +++ b/doc/misc/tramp.texi
> @@ -375,7 +375,7 @@ From behind a proxy:
> 
> @example
> @group
> -$ git config --global http.proxy http://user:pwd@@proxy.server.com:8080
> +$ git config --global http.proxy https://user:pwd@@proxy.server.com:8080
> $ git clone https://git.savannah.gnu.org/r/tramp.git
> @end group
> @end example
> diff --git a/doc/misc/url.texi b/doc/misc/url.texi
> index 2f5f994b474..b5a6cb0e6a1 100644
> --- a/doc/misc/url.texi
> +++ b/doc/misc/url.texi
> @@ -896,8 +896,8 @@ Creates a cache file name from @var{url} using MD5 hashing.
> This is creates entries with very few cache collisions and is fast.
> @cindex MD5
> @smallexample
> -(url-cache-create-filename-using-md5 "http://www.example.com/foo/bar")
> -  @result{} "/home/fx/.url/cache/fx/http/com/example/www/b8a35774ad20db71c7c3409a5410e74f"
> +(url-cache-create-filename-using-md5 "https://www.example.com/foo/bar")
> +  @result{} "/home/fx/.url/cache/fx/https/com/example/www/b8a35774ad20db71c7c3409a5410e74f"
> @end smallexample
> @end defun
> 
> @@ -906,8 +906,8 @@ Creates a cache file name from @var{url} more obviously connected to
> @var{url} than for @code{url-cache-create-filename-using-md5}, but
> more likely to conflict with other files.
> @smallexample
> -(url-cache-create-filename-human-readable "http://www.example.com/foo/bar")
> -  @result{} "/home/fx/.url/cache/fx/http/com/example/www/foo/bar"
> +(url-cache-create-filename-human-readable "https://www.example.com/foo/bar")
> +  @result{} "/home/fx/.url/cache/fx/https/com/example/www/foo/bar"
> @end smallexample
> @end defun
> 
> @@ -1159,7 +1159,7 @@ opened by the URL library.
> @c linked with the resolver libraries, it will not be able to get to any
> @c machines off the local network.  This is characterized by being able
> @c to reach someplace with a raw ip number, but not its hostname
> -@c (@url{http://129.79.254.191/} works, but
> +@c (@url{https://129.79.254.191/} works, but
> @c @url{https://www.cs.indiana.edu/} doesn't).  This used to happen on
> @c SunOS4 and Ultrix, but is now probably now rare.  If Emacs can't be
> @c rebuilt linked against the resolver library, it can use the external
> diff --git a/lisp/ChangeLog.16 b/lisp/ChangeLog.16
> index 6dda3703e6d..f7dcda87466 100644
> --- a/lisp/ChangeLog.16
> +++ b/lisp/ChangeLog.16
> @@ -10665,8 +10665,7 @@
>    * textmodes/rst.el: Add comments.
>    (rst-transition, rst-adornment): New faces.
>    (rst-adornment-faces-alist): Make default safe to reevaluate.
> -    Fixes
> -    http://sourceforge.net/tracker/?func=detail&atid=422030&aid=3479603&group_id=38414.
> +    Fixes https://sourceforge.net/p/docutils/bugs/180/.
>    Improve customization tags.
>    (rst-define-level-faces): Clarify meaning.
> 
> diff --git a/lisp/emacs-lisp/oclosure.el b/lisp/emacs-lisp/oclosure.el
> index 40f1f54eed0..466822e0e06 100644
> --- a/lisp/emacs-lisp/oclosure.el
> +++ b/lisp/emacs-lisp/oclosure.el
> @@ -50,7 +50,7 @@
> ;; - coercion wrappers, as in "Threesomes, with and without blame"
> ;;   https://dl.acm.org/doi/10.1145/1706299.1706342, or
> ;;   "On the Runtime Complexity of Type-Directed Unboxing"
> -;;   http://sv.c.titech.ac.jp/minamide/papers.html
> +;;   https://sv.c.titech.ac.jp/minamide/papers.html
> ;; - An efficient `negate' operation such that
> ;;   (negate (negate f)) returns just `f' and (negate #'<) returns #'>=.
> ;; - Autoloads (tho currently our bytecode functions (and hence OClosures)
> diff --git a/lisp/erc/erc-nicks.el b/lisp/erc/erc-nicks.el
> index 67f513f8d3e..a7d0b0769f2 100644
> --- a/lisp/erc/erc-nicks.el
> +++ b/lisp/erc/erc-nicks.el
> @@ -61,7 +61,7 @@
> ;; 2007/09 - erc-highlight-nicknames.el
> ;;           Initial release by by André Riemann
> 
> -;; [1] <http://www.github.com/leathekd/erc-hl-nicks>
> +;; [1] <https://www.github.com/leathekd/erc-hl-nicks>
> ;; [2] <https://www.emacswiki.org/emacs/ErcHighlightNicknames>
> 
> ;;; Code:
> diff --git a/lisp/net/newst-backend.el b/lisp/net/newst-backend.el
> index a68a6bf1a24..31dc8d8e177 100644
> --- a/lisp/net/newst-backend.el
> +++ b/lisp/net/newst-backend.el
> @@ -81,15 +81,15 @@ considered to be running if the newsticker timer list is not empty."
>     ("The Register"
>      "https://www.theregister.co.uk/headlines.rss")
>     ("slashdot"
> -     "http://rss.slashdot.org/Slashdot/slashdot"
> +     "https://rss.slashdot.org/Slashdot/slashdot"
>      nil
>      3600)                        ;/. will ban you if under 3600 seconds!
>     ("Wired News"
>      "https://www.wired.com/feed/rss")
>     ("Heise News (german)"
> -     "http://www.heise.de/newsticker/heise.rdf")
> +     "https://www.heise.de/newsticker/heise.rdf")
>     ("Tagesschau (german)"
> -     "http://www.tagesschau.de/newsticker.rdf"
> +     "https://www.tagesschau.de/newsticker.rdf"
>      nil
>      1800))
>   "Default URL list in raw form.
> @@ -1168,7 +1168,7 @@ URL `http://www.atompub.org/2005/08/17/draft-ietf-atompub-format-11.html'"
>                       ;; allows for integrating (x)html into the atom
>                       ;; structure but we need the raw html string.
>                       ;; e.g. https://www.heise.de/open/news/news-atom.xml
> -                      ;; http://feeds.feedburner.com/ru_nix_blogs
> +                      ;; https://feeds.feedburner.com/ru_nix_blogs
>                       (or (newsticker--unxml
>                            (car (xml-node-children
>                                  (car (xml-get-children node 'content)))))
> @@ -1302,7 +1302,7 @@ For the RSS 0.92 specification see URL `http://backend.userland.com/rss092'."
> Return value as well as arguments NAME, TIME, and TOPNODE are the
> same as in `newsticker--parse-atom-1.0'.
> 
> -For the RSS 1.0 specification see URL `http://web.resource.org/rss/1.0/spec'."
> +For the RSS 1.0 specification see URL `https://web.resource.org/rss/1.0/spec'."
>   (newsticker--debug-msg "Parsing RSS 1.0 feed %s" name)
>   (let* ((channelnode (car (xml-get-children topnode 'channel)))
>          is-new-feed has-new-items)
> @@ -1361,7 +1361,7 @@ For the RSS 1.0 specification see URL `http://web.resource.org/rss/1.0/spec'."
> Return value as well as arguments NAME, TIME, and TOPNODE are the
> same as in `newsticker--parse-atom-1.0'.
> 
> -For the RSS 2.0 specification see URL `http://blogs.law.harvard.edu/tech/rss'."
> +For the RSS 2.0 specification see URL `https://cyber.harvard.edu/rss/'."
>   (newsticker--debug-msg "Parsing RSS 2.0 feed %s" name)
>   (let* ((channelnode (car (xml-get-children topnode 'channel)))
>          is-new-feed has-new-items)
> diff --git a/lisp/net/newsticker.el b/lisp/net/newsticker.el
> index 938683a12a1..c86174b6d8e 100644
> --- a/lisp/net/newsticker.el
> +++ b/lisp/net/newsticker.el
> @@ -47,9 +47,9 @@
> ;;  * RSS 0.92
> ;;    (see http://backend.userland.com/rss092)
> ;;  * RSS 1.0
> -;;    (see http://purl.org/rss/1.0/spec)
> +;;    (see https://web.resource.org/rss/1.0/spec)
> ;;  * RSS 2.0
> -;;    (see http://blogs.law.harvard.edu/tech/rss)
> +;;    (see https://cyber.harvard.edu/rss/)
> ;; as well as the following Atom formats:
> ;;  * Atom 0.3
> ;;  * Atom 1.0
> diff --git a/lisp/nxml/nxml-maint.el b/lisp/nxml/nxml-maint.el
> index 24b38ed0635..24eb711eb99 100644
> --- a/lisp/nxml/nxml-maint.el
> +++ b/lisp/nxml/nxml-maint.el
> @@ -26,7 +26,7 @@
> 
> ;;; Parsing target repertoire files from ucs-fonts.
> ;; This is for converting the TARGET? files in
> -;; http://www.cl.cam.ac.uk/~mgk25/download/ucs-fonts.tar.gz
> +;; https://www.cl.cam.ac.uk/~mgk25/download/ucs-fonts.tar.gz
> ;; into a glyph set.
> 
> (defun nxml-insert-target-repertoire-glyph-set (file var)
> diff --git a/lisp/obsolete/iswitchb.el b/lisp/obsolete/iswitchb.el
> index 6d316fdf1cc..59e6c0403a2 100644
> --- a/lisp/obsolete/iswitchb.el
> +++ b/lisp/obsolete/iswitchb.el
> @@ -251,7 +251,7 @@
>   :group 'convenience
>   :group 'completion
>   :link '(emacs-commentary-link :tag "Commentary" "iswitchb.el")
> -  :link '(url-link "http://www.anc.ed.ac.uk/~stephen/emacs/")
> +  :link '(url-link "https://www.anc.ed.ac.uk/~stephen/emacs/")
>   :link '(emacs-library-link :tag "Lisp File" "iswitchb.el"))
> 
> (defcustom iswitchb-case case-fold-search
> diff --git a/lisp/term.el b/lisp/term.el
> index 73f583ff718..3e7745b94c9 100644
> --- a/lisp/term.el
> +++ b/lisp/term.el
> @@ -2961,7 +2961,7 @@ See `term-prompt-regexp'."
> ;; It emulates (most of the features of) a VT100/ANSI-style terminal.
> 
> ;; References:
> -;; [ctlseqs]: http://invisible-island.net/xterm/ctlseqs/ctlseqs.html
> +;; [ctlseqs]: https://invisible-island.net/xterm/ctlseqs/ctlseqs.html
> ;; [ECMA-48]: https://www.ecma-international.org/publications/standards/Ecma-048.htm
> ;; [vt100]: https://vt100.net/docs/vt100-ug/chapter3.html
> 
> diff --git a/lisp/textmodes/less-css-mode.el b/lisp/textmodes/less-css-mode.el
> index c3905afb4e7..2e4d71fb631 100644
> --- a/lisp/textmodes/less-css-mode.el
> +++ b/lisp/textmodes/less-css-mode.el
> @@ -215,7 +215,7 @@ directory by default."
> ;;;###autoload (add-to-list 'auto-mode-alist '("\\.less\\'" . less-css-mode))
> ;;;###autoload
> (define-derived-mode less-css-mode css-mode "Less"
> -  "Major mode for editing Less files (http://lesscss.org/).
> +  "Major mode for editing Less files (https://lesscss.org/).
> Special commands:
> \\{less-css-mode-map}"
>   (font-lock-add-keywords nil less-css-font-lock-keywords)
> diff --git a/lisp/textmodes/remember.el b/lisp/textmodes/remember.el
> index 95e18b7d1d5..84a0185f7b5 100644
> --- a/lisp/textmodes/remember.el
> +++ b/lisp/textmodes/remember.el
> @@ -7,7 +7,7 @@
> ;; Created: 29 Mar 1999
> ;; Old-Version: 2.0
> ;; Keywords: data memory todo pim
> -;; URL: http://gna.org/projects/remember-el/
> +;; URL: http://gna.org/projects/remember-el/ [dead link]
> 
> ;; This file is part of GNU Emacs.
> 
> diff --git a/lisp/textmodes/rst.el b/lisp/textmodes/rst.el
> index 9d68feed0e0..6108e80363c 100644
> --- a/lisp/textmodes/rst.el
> +++ b/lisp/textmodes/rst.el
> @@ -1473,7 +1473,7 @@ for modes derived from Text mode, like Mail mode."
>   :version "21.1")
> 
> ;; FIXME: Default must match suggestion in
> -;;        http://sphinx-doc.org/rest.html#sections for Python documentation.
> +;;        https://sphinx-doc.org/rest.html#sections for Python documentation.
> (defcustom rst-preferred-adornments '((?= over-and-under 1)
>                      (?= simple 0)
>                      (?- simple 0)
> diff --git a/src/ChangeLog.12 b/src/ChangeLog.12
> index 74df9809261..fdb7a2e659b 100644
> --- a/src/ChangeLog.12
> +++ b/src/ChangeLog.12
> @@ -7077,7 +7077,7 @@
> 
>    * .gdbinit: Use "set $dummy = ..." to avoid warnings from GDB 7.5
>    and later about non-assignments with no effect.  See discussion at
> -    http://sourceware.org/ml/gdb-patches/2012-08/msg00518.html for
> +    https://sourceware.org/ml/gdb-patches/2012-08/msg00518.html for
>    details.
> 
> 2012-08-20  Dmitry Antipov  <dmantipov@yandex.ru>
> diff --git a/src/w32fns.c b/src/w32fns.c
> index dcf9a212bdd..07b389df84a 100644
> --- a/src/w32fns.c
> +++ b/src/w32fns.c
> @@ -3852,7 +3852,7 @@ deliver_wm_chars (int do_translate, HWND hwnd, UINT msg, UINT wParam,
> 
>       /* What follows is just heuristics; the correct treatment requires
>     non-destructive ToUnicode():
> -       http://search.cpan.org/~ilyaz/UI-KeyboardLayout/lib/UI/KeyboardLayout.pm#Can_an_application_on_Windows_accept_keyboard_events?_Part_IV:_application-specific_modifiers
> +       https://metacpan.org/dist/UI-KeyboardLayout/view/lib/UI/KeyboardLayout.pm#Can-an-application-on-Windows-accept-keyboard-events?-Part-IV:-application-specific-modifiers
> 
>     What one needs to find is:
>       * which of the present modifiers AFFECT the resulting char(s)
> @@ -3914,7 +3914,7 @@ deliver_wm_chars (int do_translate, HWND hwnd, UINT msg, UINT wParam,
>     character is the same for AltGr-* (=rAlt-*) and Ctrl-Alt-* (in any
>     combination of handedness).  For description of masks, see
> 
> -       http://search.cpan.org/~ilyaz/UI-KeyboardLayout/lib/UI/KeyboardLayout.pm#Keyboard_input_on_Windows,_Part_I:_what_is_the_kernel_doing?
> +       https://metacpan.org/dist/UI-KeyboardLayout/view/lib/UI/KeyboardLayout.pm#Keyboard-input-on-Windows,-Part-I:-what-is-the-kernel-doing?
> 
>     By default, Emacs was using these coincidences via the following
>     heuristics: it was treating:
> diff --git a/src/w32term.h b/src/w32term.h
> index 69ef297cbcc..68237bfff1d 100644
> --- a/src/w32term.h
> +++ b/src/w32term.h
> @@ -29,7 +29,7 @@ along with GNU Emacs.  If not, see <https://www.gnu.org/licenses/>.  */
>    calls us.  The ALIGN_STACK attribute forces GCC to emit a preamble
>    code to re-align the stack at function entry.  Further details
>    about this can be found in
> -   http://www.peterstock.co.uk/games/mingw_sse/.  */
> +   https://www.peterstock.co.uk/games/mingw_sse/.  */
> #ifdef __GNUC__
> # if USE_STACK_LISP_OBJECTS && !defined _WIN64 && !defined __x86_64__    \
>   && __GNUC__ + (__GNUC_MINOR__ > 1) >= 5
> 




^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: master 0910230be6e: ; Prefer HTTPS to HTTP in more links
  2023-08-03  5:56 ` master 0910230be6e: ; Prefer HTTPS to HTTP in more links Ruijie Yu via Emacs development discussions.
@ 2023-08-03  6:37   ` Yuri Khan
  2023-08-03  6:59     ` Po Lu
                       ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Yuri Khan @ 2023-08-03  6:37 UTC (permalink / raw)
  To: Ruijie Yu; +Cc: Stefan Kangas, emacs-devel

On Thu, 3 Aug 2023 at 12:58, Ruijie Yu via Emacs development
discussions. <emacs-devel@gnu.org> wrote:

> I believe there are some places where you modified, where http is indeed intended rather than https.  For example, doc/misc/org.org tries to tell readers that Org supports many protocols, one of which is http.

To expand on that:

> > diff --git a/doc/misc/tramp.texi b/doc/misc/tramp.texi
> > index e518330c9b0..291d6600af5 100644
> > --- a/doc/misc/tramp.texi
> > +++ b/doc/misc/tramp.texi
> > @@ -375,7 +375,7 @@ From behind a proxy:
> >
> > @example
> > @group
> > -$ git config --global http.proxy http://user:pwd@@proxy.server.com:8080
> > +$ git config --global http.proxy https://user:pwd@@proxy.server.com:8080
> > $ git clone https://git.savannah.gnu.org/r/tramp.git
> > @end group
> > @end example

This looks suspicious, too. A proxy running on port 8080 and referred
to in a git http.proxy config variable is likely to be an http proxy.

> > @@ -1159,7 +1159,7 @@ opened by the URL library.
> > @c linked with the resolver libraries, it will not be able to get to any
> > @c machines off the local network.  This is characterized by being able
> > @c to reach someplace with a raw ip number, but not its hostname
> > -@c (@url{http://129.79.254.191/} works, but
> > +@c (@url{https://129.79.254.191/} works, but
> > @c @url{https://www.cs.indiana.edu/} doesn't).  This used to happen on
> > @c SunOS4 and Ultrix, but is now probably now rare.  If Emacs can't be
> > @c rebuilt linked against the resolver library, it can use the external

An https connection by IP address is unlikely to “work” (though it
will fail with a different diagnostic). The server will present a TLS
certificate for a certain domain name, and the client will reject it
because the domain name presented does not exactly match the IP
address.

(Also, Gmail’s spell checker says “is now probably now rare” is
probably a typo.)



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: master 0910230be6e: ; Prefer HTTPS to HTTP in more links
  2023-08-03  6:37   ` Yuri Khan
@ 2023-08-03  6:59     ` Po Lu
  2023-08-04  7:48       ` Stefan Kangas
  2023-08-03  7:53     ` Michael Albinus
  2023-08-04  7:29     ` Stefan Kangas
  2 siblings, 1 reply; 8+ messages in thread
From: Po Lu @ 2023-08-03  6:59 UTC (permalink / raw)
  To: Yuri Khan; +Cc: Ruijie Yu, Stefan Kangas, emacs-devel

Yuri Khan <yuri.v.khan@gmail.com> writes:
I don't see the need to obstinately update HTTP links to their HTTPS
counterparts.  We should make these changes one link at a time,
deferring them to when (and if) their webmasters discontinue plain HTTP
access.

Indiscriminately editing links to read `https' will inevitably break
links to sites that only support HTTP, and result in other problems like
those the two of you illustrated.



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: master 0910230be6e: ; Prefer HTTPS to HTTP in more links
  2023-08-03  6:37   ` Yuri Khan
  2023-08-03  6:59     ` Po Lu
@ 2023-08-03  7:53     ` Michael Albinus
  2023-08-04  7:50       ` Andreas Schwab
  2023-08-04  7:29     ` Stefan Kangas
  2 siblings, 1 reply; 8+ messages in thread
From: Michael Albinus @ 2023-08-03  7:53 UTC (permalink / raw)
  To: Yuri Khan; +Cc: Ruijie Yu, Stefan Kangas, emacs-devel

Yuri Khan <yuri.v.khan@gmail.com> writes:

Hi Yuri,

>> > @example
>> > @group
>> > -$ git config --global http.proxy http://user:pwd@@proxy.server.com:8080
>> > +$ git config --global http.proxy https://user:pwd@@proxy.server.com:8080
>> > $ git clone https://git.savannah.gnu.org/r/tramp.git
>> > @end group
>> > @end example
>
> This looks suspicious, too. A proxy running on port 8080 and referred
> to in a git http.proxy config variable is likely to be an http proxy.

The git http.proxy config variable is good for both http_proxy and
https_proxy environment variables. And I wouldn't care too much about
the 8080 port; it's just an example.

Best regards, Michael.



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: master 0910230be6e: ; Prefer HTTPS to HTTP in more links
  2023-08-03  6:37   ` Yuri Khan
  2023-08-03  6:59     ` Po Lu
  2023-08-03  7:53     ` Michael Albinus
@ 2023-08-04  7:29     ` Stefan Kangas
  2023-08-04  7:37       ` Eli Zaretskii
  2 siblings, 1 reply; 8+ messages in thread
From: Stefan Kangas @ 2023-08-04  7:29 UTC (permalink / raw)
  To: Yuri Khan; +Cc: Ruijie Yu, emacs-devel

> > I believe there are some places where you modified, where http is indeed intended rather than https.  For example, doc/misc/org.org tries to tell readers that Org supports many protocols, one of which is http.

True.  It's not the best example though, as it now redirects to the
https version.

(Are we sure we need an example for HTTP when we already have an HTTPS
one?  HTTPS implies HTTP, doesn't it?)

> An https connection by IP address is unlikely to “work” (though it
> will fail with a different diagnostic). The server will present a TLS
> certificate for a certain domain name, and the client will reject it
> because the domain name presented does not exactly match the IP
> address.
>
> (Also, Gmail’s spell checker says “is now probably now rare” is
> probably a typo.)

That section has been commented out since 2007.  Perhaps it should
simply be removed.



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: master 0910230be6e: ; Prefer HTTPS to HTTP in more links
  2023-08-04  7:29     ` Stefan Kangas
@ 2023-08-04  7:37       ` Eli Zaretskii
  0 siblings, 0 replies; 8+ messages in thread
From: Eli Zaretskii @ 2023-08-04  7:37 UTC (permalink / raw)
  To: Stefan Kangas, Ihor Radchenko; +Cc: yuri.v.khan, ruijie, emacs-devel

> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Fri, 4 Aug 2023 09:29:12 +0200
> Cc: Ruijie Yu <ruijie@netyu.xyz>, emacs-devel@gnu.org
> 
> > > I believe there are some places where you modified, where http is indeed intended rather than https.  For example, doc/misc/org.org tries to tell readers that Org supports many protocols, one of which is http.
> 
> True.  It's not the best example though, as it now redirects to the
> https version.
> 
> (Are we sure we need an example for HTTP when we already have an HTTPS
> one?  HTTPS implies HTTP, doesn't it?)

Ihor, any comments on this part?

Thanks.



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: master 0910230be6e: ; Prefer HTTPS to HTTP in more links
  2023-08-03  6:59     ` Po Lu
@ 2023-08-04  7:48       ` Stefan Kangas
  0 siblings, 0 replies; 8+ messages in thread
From: Stefan Kangas @ 2023-08-04  7:48 UTC (permalink / raw)
  To: Po Lu; +Cc: Yuri Khan, Ruijie Yu, emacs-devel

Po Lu <luangruo@yahoo.com> writes:

> I don't see the need to obstinately update HTTP links to their HTTPS
> counterparts.

Encryption protects users from certain kinds of Internet surveillance,
as well as snooping of sensitive user data.  Therefore, I think that
it's better to be proactive about preferring HTTPS when possible.

But nearly all links in Emacs have already been changed, so we can
probably agree to disagree about this.

> Indiscriminately editing links to read `https' will inevitably break
> links to sites that only support HTTP,

Yes, of course.  That's why I left many URIs alone, as testing them
showed that they are HTTP only.



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: master 0910230be6e: ; Prefer HTTPS to HTTP in more links
  2023-08-03  7:53     ` Michael Albinus
@ 2023-08-04  7:50       ` Andreas Schwab
  0 siblings, 0 replies; 8+ messages in thread
From: Andreas Schwab @ 2023-08-04  7:50 UTC (permalink / raw)
  To: Michael Albinus; +Cc: Yuri Khan, Ruijie Yu, Stefan Kangas, emacs-devel

On Aug 03 2023, Michael Albinus wrote:

> Yuri Khan <yuri.v.khan@gmail.com> writes:
>
> Hi Yuri,
>
>>> > @example
>>> > @group
>>> > -$ git config --global http.proxy http://user:pwd@@proxy.server.com:8080
>>> > +$ git config --global http.proxy https://user:pwd@@proxy.server.com:8080
>>> > $ git clone https://git.savannah.gnu.org/r/tramp.git
>>> > @end group
>>> > @end example
>>
>> This looks suspicious, too. A proxy running on port 8080 and referred
>> to in a git http.proxy config variable is likely to be an http proxy.
>
> The git http.proxy config variable is good for both http_proxy and
> https_proxy environment variables. And I wouldn't care too much about
> the 8080 port; it's just an example.

But a proxy certainly won't support both encrypted and unencrypted
accesses over the same port (this is independent of the protocol of the
proxied URL).

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."



^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2023-08-04  7:50 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20230802214156.1EF72C038BC@vcs2.savannah.gnu.org>
2023-08-03  5:56 ` master 0910230be6e: ; Prefer HTTPS to HTTP in more links Ruijie Yu via Emacs development discussions.
2023-08-03  6:37   ` Yuri Khan
2023-08-03  6:59     ` Po Lu
2023-08-04  7:48       ` Stefan Kangas
2023-08-03  7:53     ` Michael Albinus
2023-08-04  7:50       ` Andreas Schwab
2023-08-04  7:29     ` Stefan Kangas
2023-08-04  7:37       ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).