From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: Initial fontification in sh-mode with tree-sittter Date: Mon, 31 Oct 2022 17:33:51 -0700 Message-ID: References: <48F9C464-0F5F-4BF9-A27F-92F4F34FF0A8@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23456"; mail-complaints-to="usenet@ciao.gmane.io" Cc: =?utf-8?Q?Jo=C3=A3o_Paulo_Labegalini_de_Carvalho?= , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Nov 01 01:34:41 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1opfEn-0005vM-Hf for ged-emacs-devel@m.gmane-mx.org; Tue, 01 Nov 2022 01:34:41 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1opfE8-0001CE-8h; Mon, 31 Oct 2022 20:34:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opfE5-0001Bt-NW for emacs-devel@gnu.org; Mon, 31 Oct 2022 20:33:57 -0400 Original-Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1opfE3-0005k8-9b for emacs-devel@gnu.org; Mon, 31 Oct 2022 20:33:56 -0400 Original-Received: by mail-pg1-x536.google.com with SMTP id q1so12070871pgl.11 for ; Mon, 31 Oct 2022 17:33:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bmdhkQ8gDSKQsOL55NmtoqzmJRCOrxZz0q014YVZUHI=; b=k3gH2s1mN0qhkpeKsmP6aI8vuwAblwbY5Mp0t6oLNnfRN/tLvpO8UUDM2M9eBXUGt3 5zOJRgQutw+Fz6fIaOTXotrnftUJmoXScRokzAC1CmZNT2t3OlCKDLN8jbDLaKJ+M3QO qW+5AVSMxUO0EoGnYIDBG/BXAiMJDggHUNH/jaepTXdB228b0J7oXCydCBYhUbYbMDNU RQvA9s2jm7H1xMyDIBZ8elHRzY40a6NiQPuWatA+y0YrtB6Mc6biP40umqYBu5BTi3RV dX4kFoqtMka9/J8XPGXcWxsfw5RwZoT5lE79yLmQtY8/BRj3vLqP2IC+zc6ZVUDeF4AU Xy5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bmdhkQ8gDSKQsOL55NmtoqzmJRCOrxZz0q014YVZUHI=; b=VRSToi+ZdrHQuARjxDLjvl6EolxCNqt5Nv4AdmOSAegwFEDX2g6QrKAhCxUIF0aZmy ShX7q+r1WTo3OQA2soc+ANLLmfahgLe4Cvdpr2rYTip8M30ic7UsrsIdAwXvVgil4Idv ICkLwrD8+mvcfBxecW/yJnOeVY1lSIoh30NaMbZZ4LTLJqhXhq+aD809DxQHK+KAcM1G Wc2gifirn2Umov1Yv+J7YgvzbJkqUQ3KED4hH5riensgSn52c9ZvJb1TT/DX62fqGz7X YxkkBF3TdPc+kVE1WMWkybUJgIhlajoOELKWCEnxX9odqLzIWw/3Sxw7ajp19bQFEqrp 8rBA== X-Gm-Message-State: ACrzQf2WJL5xcHzgNT2/YrWIQvVmNWgez/RE6Qu/CO626fB7Xh6zh+PO kaniduXUOWw95I7gB/K65Vw= X-Google-Smtp-Source: AMsMyM5PQNBFDtQcSawSXPl8tciRYetrD7DGjIJQmb06tba7HVNvkoOH8TFKHD4rZ+ea/JywQYOn8Q== X-Received: by 2002:a05:6a00:150e:b0:56c:83b3:d148 with SMTP id q14-20020a056a00150e00b0056c83b3d148mr17266970pfu.48.1667262833438; Mon, 31 Oct 2022 17:33:53 -0700 (PDT) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id i7-20020a170902c94700b00186a437f4d7sm5015656pla.147.2022.10.31.17.33.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 31 Oct 2022 17:33:53 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3696.120.41.1.1) Received-SPF: pass client-ip=2607:f8b0:4864:20::536; envelope-from=casouri@gmail.com; helo=mail-pg1-x536.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298899 Archived-At: > On Oct 28, 2022, at 11:12 AM, Stefan Monnier = wrote: >=20 >>> This way, users can set a vague global "level" preference as a good >>> baseline, which they can more finely tune according to their own >>> preference by controlling individual features for specific modes. >> I should probably add some convenient functions user can use to = add/remove >> feature from that list, since its not a plain list, but rather a list >> of list. >=20 > I think this var should be provided by the major mode and not touched > by users. >=20 > Instead we should provide another config var for users where they can > individually enable/disable specific features for specific major = modes. How about: (add-hook 'xxx-mode-hook (lambda () (setq-local treesit-font-lock-disabled-features = '(features...)) (treesit-font-lock-recompute-features))) Or (add-hook 'xxx-mode-hook (lambda () (treesit-font-lock-set-disabled-features 'features...))) ? You probably don=E2=80=99t need to set enabled features, because you can = set maximum-decoration to a high value and specify what to disable. And = maximum-decoration is infinity by default. BTW, I=E2=80=99m trying to think of a better prefix than font-lock for = these functions and variables, maybe =E2=80=9Cfontify=E2=80=9D? Like treesit-fontify-region-function treesit-fontify-rules treesit-fontify-settings treesit-fontify-feature-list It being a verb is a bit strange, but =E2=80=9Cfontification=E2=80=9D is = too long. Actually, what does =E2=80=9Clock=E2=80=9D even mean in font = lock? Yuan=