From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Newsgroups: gmane.emacs.devel Subject: Re: kill-new may replace the wrong item Date: Fri, 4 Jun 2010 00:31:36 +0100 Message-ID: References: <87d3wasfpf.fsf@mail.jurta.org> <87y6exp5zi.fsf@mail.jurta.org> <874ohjj4x2.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 X-Trace: dough.gmane.org 1275607910 7710 80.91.229.12 (3 Jun 2010 23:31:50 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 3 Jun 2010 23:31:50 +0000 (UTC) Cc: emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 04 01:31:49 2010 connect(): No such file or directory Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OKJt7-0003IZ-Am for ged-emacs-devel@m.gmane.org; Fri, 04 Jun 2010 01:31:49 +0200 Original-Received: from localhost ([127.0.0.1]:51056 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OKJt6-00070h-PN for ged-emacs-devel@m.gmane.org; Thu, 03 Jun 2010 19:31:48 -0400 Original-Received: from [140.186.70.92] (port=57286 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OKJsx-0006yI-Fv for emacs-devel@gnu.org; Thu, 03 Jun 2010 19:31:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OKJsw-0007f0-E8 for emacs-devel@gnu.org; Thu, 03 Jun 2010 19:31:39 -0400 Original-Received: from mail-ww0-f41.google.com ([74.125.82.41]:58406) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OKJsw-0007eS-A5 for emacs-devel@gnu.org; Thu, 03 Jun 2010 19:31:38 -0400 Original-Received: by wwb24 with SMTP id 24so575331wwb.0 for ; Thu, 03 Jun 2010 16:31:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=F6vymW+F6nOqgZbw8eAHItEej02b423JBdv7BMwplUQ=; b=aS56VVYicS0VVVxI0DFIOuvLVUb4jyg9T1zSpfB4iWfszV1Ud2DDBklZJkEb29urBB tYyh4dgadc071AaC+Y8n12u8L2mKfFjKp9a0Skl3lC3B+ZjKjmx1LIxsMXh6xw0fDP3j O0NyyjwfgqiX4ZQDABpmqVOo2DtbgLaeOAo6o= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=GCyzciMVGGA92WeSbtBwREMOCYzeBscV9/d+oDq8lNGZkRsPz8q12/aEhx77/roFbU kcrffpLXhzOZbw9C/IT4dX/C/JguQcE6LyI+IBDXdufLHN5kg1N7+HRos6m6eubISHvg 7eC0Pma/h7tKzkYPA6Tf1MDun6rGh8YvUYnCc= Original-Received: by 10.216.159.80 with SMTP id r58mr1567383wek.48.1275607896495; Thu, 03 Jun 2010 16:31:36 -0700 (PDT) Original-Received: by 10.216.179.75 with HTTP; Thu, 3 Jun 2010 16:31:36 -0700 (PDT) In-Reply-To: <874ohjj4x2.fsf@mail.jurta.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:125490 Archived-At: On 3 June 2010 20:17, Juri Linkov wrote: >> All I am trying to point out is there's something incorrect there. > > The whole implementation of `kill-do-not-save-duplicates' is incorrect. > It should do nothing instead of setting `replace' to t and replacing the > same string with itself (that may override the value pushed from > `interprogram-paste' to `kill-ring'). > > I believe this patch will provide the consistent interaction between > `kill-do-not-save-duplicates' and `save-interprogram-paste-before-kill'. > Before pushing a string to kill-ring it compares the head of kill-ring with > the string from interprogram-paste and later with the input argument `string': [patch] Thanks for fixing this. Leo