From: Juanma Barranquero <lekktu@gmail.com>
To: Lennart Borgman <lennart.borgman@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: System calls without error checks in w32
Date: Sun, 30 May 2010 21:24:33 +0200 [thread overview]
Message-ID: <AANLkTintgr1mOZtJ6zsLA4sfX0OYeLa9CTq9rmQSKyeh@mail.gmail.com> (raw)
In-Reply-To: <AANLkTil-T_URLzHSRdGozw37igbEFXiq-3PYSvrKNwrE@mail.gmail.com>
On Sun, May 30, 2010 at 20:02, Lennart Borgman
<lennart.borgman@gmail.com> wrote:
> My intention is to get a chance to know why a system call failed. That
> is a way to find those errors that are a bit harder to find than those
> you may see directly by inspecting the code.
If you have DebPrint for every system call, and some of them return
trivial errors, debugging will sometimes be harder just because of the
noise.
> System calls, however is like a black box. You have to follow the
> rules for calling the black box, but do not know exactly what is
> inside, you can only watch the outcome to learn more.
I think you'll see that many system calls won't ever return an error
(because the error conditions are pretty infrequent). Some of them
will, for example system calls related to file manipulation (because
of nonexistent or nonaccesible files, etc.); it would be interesting
to know how many of those don't have already checking in place.
> One example of this is when I see Emacs going totally weird. That
> happens quite often and I am not sure what is happening. It might in
> my cases be problems with edebug or it might be problems with the
> system calls that makes the depends on resource exhaustion in the
> black system box.
Does that happen to you with your patched Emacs, or unpatched? Because
I see occasional crashes, but not nearly as frequently as it seems to
happen to you (not by a loooong shot), and I have not seem "weird"
behavior (unresponsive Emacs, looping, etc.) perhaps for years.
> To be able to fix it I need some kind of logging of
> the system calls.
Because you somehow assume that the trouble is likely related to bad
system calls; most Emacs bugs aren't.
>> This is even worse, because it's impossible to understand what this
>> does without looking up the magical W32DEBPRINT macro.
>
>
> I think it has some advantages, actually. It is easy to see and
> distinguish from the normal code. It can be a null op in non-debugging
> compilations.
IMHO is horribly ugly. If you're going to have error checks, better to
have them on the clear.
Juanma
next prev parent reply other threads:[~2010-05-30 19:24 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-29 2:38 System calls without error checks in w32 Lennart Borgman
2010-05-29 17:43 ` Eli Zaretskii
2010-05-29 18:42 ` Lennart Borgman
2010-05-29 19:35 ` Eli Zaretskii
2010-05-29 20:02 ` Lennart Borgman
2010-05-29 21:25 ` Eli Zaretskii
2010-05-29 21:30 ` Lennart Borgman
2010-05-30 3:02 ` Eli Zaretskii
2010-05-30 3:26 ` Lennart Borgman
2010-05-30 17:36 ` Eli Zaretskii
2010-05-30 18:02 ` Lennart Borgman
2010-05-30 19:24 ` Juanma Barranquero [this message]
2010-05-30 22:37 ` Lennart Borgman
2010-05-30 23:03 ` Juanma Barranquero
2010-05-30 23:28 ` Lennart Borgman
2010-05-31 0:10 ` Juanma Barranquero
2010-05-31 0:58 ` Lennart Borgman
2010-05-31 2:02 ` Juanma Barranquero
2010-05-31 2:36 ` Lennart Borgman
2010-05-31 3:06 ` Juanma Barranquero
2010-05-31 3:05 ` Eli Zaretskii
-- strict thread matches above, loose matches on Subject: below --
2010-05-31 9:18 grischka
2010-06-05 17:15 ` Jason Rumney
2010-06-07 10:37 ` grischka
2010-06-07 14:54 ` Stephen J. Turnbull
2010-06-07 15:23 ` Lennart Borgman
2010-06-07 17:21 ` grischka
2010-06-07 17:30 ` Lennart Borgman
2010-06-07 18:54 ` grischka
2010-06-08 0:32 ` Lennart Borgman
2010-06-08 0:34 ` Lennart Borgman
2010-06-07 19:56 ` Stefan Monnier
2010-06-07 23:35 ` Lennart Borgman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTintgr1mOZtJ6zsLA4sfX0OYeLa9CTq9rmQSKyeh@mail.gmail.com \
--to=lekktu@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=lennart.borgman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).