From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: imagemagick support on W32 Date: Fri, 1 Oct 2010 05:16:55 +0200 Message-ID: References: <4CA53CE5.1020702@gmail.com> <4CA54727.6010900@gmail.com> <4CA54834.4020106@gmail.com> <4CA54E67.5040703@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1285903079 21256 80.91.229.12 (1 Oct 2010 03:17:59 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 1 Oct 2010 03:17:59 +0000 (UTC) Cc: emacs-devel@gnu.org To: Christoph Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 01 05:17:58 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P1W8D-00019s-9L for ged-emacs-devel@m.gmane.org; Fri, 01 Oct 2010 05:17:57 +0200 Original-Received: from localhost ([127.0.0.1]:39800 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P1W8C-00018k-LN for ged-emacs-devel@m.gmane.org; Thu, 30 Sep 2010 23:17:56 -0400 Original-Received: from [140.186.70.92] (port=54545 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P1W7u-00010y-3H for emacs-devel@gnu.org; Thu, 30 Sep 2010 23:17:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P1W7s-0006LZ-SY for emacs-devel@gnu.org; Thu, 30 Sep 2010 23:17:38 -0400 Original-Received: from mail-iw0-f169.google.com ([209.85.214.169]:38550) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P1W7s-0006LV-Md for emacs-devel@gnu.org; Thu, 30 Sep 2010 23:17:36 -0400 Original-Received: by iwn33 with SMTP id 33so5023679iwn.0 for ; Thu, 30 Sep 2010 20:17:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=qfgETx5YivG2CUlHcK9SHP5I4pkoJOlvlrzntDOkOOM=; b=Qs2//rnfMCgn3pVBnh7bzS2asgWoh/QdE0Xcrls+/NFjGQR0arp1UpCsPw2wb7pKtk sQ1zRXPpcPhhverBVwnha8lIpSfDvvw7wEX4TvZqIYwxDqbnbby9iA57bMIkcIbksOcF Y/SLC6OIZm2PR6/mzCAXjXQD0FGyUQIiE+nbo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=SuftiBD9vX0th9GI/ve8uVQaN0myUqm9kgF8o0+KMrw6/FKByR5s3O65Z6AtR+hRIs /X6KdBEvJQGe99ucqyxceIlrQmnVzmlSMVQZi2QY0JO6YmD7iLLIZF8TUyEwLdKWTMiK VYa+LsJIAV303PnTLvDDGIl4ye3E3qqjKAfZY= Original-Received: by 10.231.12.77 with SMTP id w13mr4359062ibw.80.1285903055892; Thu, 30 Sep 2010 20:17:35 -0700 (PDT) Original-Received: by 10.231.196.71 with HTTP; Thu, 30 Sep 2010 20:16:55 -0700 (PDT) In-Reply-To: <4CA54E67.5040703@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:131126 Archived-At: On Fri, Oct 1, 2010 at 04:58, Christoph wrote: > And if it is missing...does something like this come close? Yes, something like that, assuming you're trying to use ImageMagick DLLs and not linking statically. > Note: I wasn't sure about the #else clause for HAVE_NTGUI. Looks like for > other image libraries the function names are aliased with fn_FUNCTIONNAME= ? The code in image.c calls the image functions through the fn_ function "pointers". On HAVE_NTGUI, macros DEF_IMGLIB_FN and LOAD_IMGLIB_FN create and set such pointers. On ! HAVE_NTGUI, such pointers are simply redefined to refer to the original, statically linked functions. So, the code that currently calls ImageMagick functions directly, like NewMagickWand, MagickPingImage, etc, should be changed to call fn_NewMagickWand, fn_MagickPingImage, etc. One issue: /* Try loading ImageMagick library under probable names. */ if (!(library =3D w32_delayed_load (libraries, Qimagemagick))) return 0; You'll have to add the imagemagick libraries to image-library-alist, of course. But, what is the intention of ImageMagick here? To substitute libpng, jpeglib, etc? If so, something will have to be done with respect to image-type-available-p (or, more specifically, init-image-library) so Emacs "knows" that png, jpeg, tiff, etc are really available. But perhaps I'm misinterpreting the intention of ImageMagick? Hope this helps, =C2=A0 =C2=A0 Juanma