From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: bookmark from gnus article wrong modification Date: Fri, 16 Jul 2010 23:48:47 -0400 Message-ID: References: <87vd8ftvm1.fsf@tux.homenetwork> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1279338542 20820 80.91.229.12 (17 Jul 2010 03:49:02 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 17 Jul 2010 03:49:02 +0000 (UTC) Cc: emacs-devel@gnu.org To: Thierry Volpiatto Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 17 05:49:00 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OZyOY-0003zR-5x for ged-emacs-devel@m.gmane.org; Sat, 17 Jul 2010 05:48:58 +0200 Original-Received: from localhost ([127.0.0.1]:45369 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OZyOX-000259-8L for ged-emacs-devel@m.gmane.org; Fri, 16 Jul 2010 23:48:57 -0400 Original-Received: from [140.186.70.92] (port=58873 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OZyOR-00024r-0N for emacs-devel@gnu.org; Fri, 16 Jul 2010 23:48:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OZyOP-0007Be-KV for emacs-devel@gnu.org; Fri, 16 Jul 2010 23:48:50 -0400 Original-Received: from mail-vw0-f41.google.com ([209.85.212.41]:57511) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OZyOP-0007BO-HW for emacs-devel@gnu.org; Fri, 16 Jul 2010 23:48:49 -0400 Original-Received: by vws1 with SMTP id 1so3587727vws.0 for ; Fri, 16 Jul 2010 20:48:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=+7GJQpCugDl+eWnvMVFjoi6eA1FL2+lhmeU8w0qQe+U=; b=QbVZoSe+oSCzoz9MerooV00X6Qa37fN/sMx35uiR20zwrh27ZNJ8K3LHtjW1qFFe93 HMd1WfoIXBL/mo6qdnIIK1WRW1wpg2b1xDbJPjCAb/Azi2UDNqFCCPFeLIJtjytNH3NM pnQRMzmjA+adKNtq/G3DJVtGpq9J2k3I1H9WI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=wFCFDY6GrrqQo2XR3oJnv5b1Hb9E0oG6iYJYfYa50p9SleMp+URKjR8GtCY7yYRCgw ZbhI5xKVbUiYutkrwZr/akJ+BIGgJTxJlSIvlniAWquYb6l6nxjgGbYcnktGPrVBkMAO 3DYFSAjYCSkg61O/n8Nthwk+lkaGs4ZLzmgWM= Original-Received: by 10.220.162.148 with SMTP id v20mr1061418vcx.176.1279338527459; Fri, 16 Jul 2010 20:48:47 -0700 (PDT) Original-Received: by 10.220.200.198 with HTTP; Fri, 16 Jul 2010 20:48:47 -0700 (PDT) In-Reply-To: <87vd8ftvm1.fsf@tux.homenetwork> X-Google-Sender-Auth: ihsj-k65nqERo2qN7jdVLSZDlws X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:127478 Archived-At: On Fri, Jul 16, 2010 at 9:16 AM, Thierry Volpiatto wrote: > Hi, > the last modification for compatibility with older emacs in gnus-sum.el > is wrong. > You should use the value of pos what is set to point IN THE ARTICLE > BUFFER. > If you use just (point) it will record the value of point in the summary > buffer what is wrong and not what we want: Thanks, Thierry. I'm on the road right now but will take care of this once not traveling. On my list! -Karl > ,---- > | =A0 =A0 =A0 `(,subject > | =A0 =A0 =A0 ,@(condition-case nil > | =A0 =A0 =A0 =A0 =A0 =A0 (bookmark-make-record-default 'no-file 'no-cont= ext (point)) > | =A0 =A0 =A0 =A0 =A0 (wrong-number-of-arguments > | =A0 =A0 =A0 =A0 =A0 =A0(bookmark-make-record-default 'point-only))) > `---- > > See precedent patchs for example. > > Also this change add tabs that also is wrong i think (you should > untabify). > > This changes occur in: > > ,---- > | changeset: =A0 109420:8fa1cd12c77f > | user: =A0 =A0 =A0 =A0Katsumi Yamaoka > | date: =A0 =A0 =A0 =A0Thu Jul 15 00:54:06 2010 +0000 > | summary: =A0 =A0 Make gnus-summary-bookmark-make-record work for Emacs = 23 as well. > `---- > > > -- > Thierry Volpiatto > Get my Gnupg key: > gpg --keyserver pgp.mit.edu --recv-keys 59F29997 > > >