From: Karl Fogel <kfogel@red-bean.com>
To: Thierry Volpiatto <thierry.volpiatto@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: bookmark from gnus article wrong modification
Date: Fri, 16 Jul 2010 23:48:47 -0400 [thread overview]
Message-ID: <AANLkTinRAeO2N63G-M10qIMYyMhshjHRikhXMIUgGRda@mail.gmail.com> (raw)
In-Reply-To: <87vd8ftvm1.fsf@tux.homenetwork>
On Fri, Jul 16, 2010 at 9:16 AM, Thierry Volpiatto
<thierry.volpiatto@gmail.com> wrote:
> Hi,
> the last modification for compatibility with older emacs in gnus-sum.el
> is wrong.
> You should use the value of pos what is set to point IN THE ARTICLE
> BUFFER.
> If you use just (point) it will record the value of point in the summary
> buffer what is wrong and not what we want:
Thanks, Thierry. I'm on the road right now but will take care of this
once not traveling. On my list!
-Karl
> ,----
> | `(,subject
> | ,@(condition-case nil
> | (bookmark-make-record-default 'no-file 'no-context (point))
> | (wrong-number-of-arguments
> | (bookmark-make-record-default 'point-only)))
> `----
>
> See precedent patchs for example.
>
> Also this change add tabs that also is wrong i think (you should
> untabify).
>
> This changes occur in:
>
> ,----
> | changeset: 109420:8fa1cd12c77f
> | user: Katsumi Yamaoka <yamaoka@jpl.org>
> | date: Thu Jul 15 00:54:06 2010 +0000
> | summary: Make gnus-summary-bookmark-make-record work for Emacs 23 as well.
> `----
>
>
> --
> Thierry Volpiatto
> Get my Gnupg key:
> gpg --keyserver pgp.mit.edu --recv-keys 59F29997
>
>
>
next prev parent reply other threads:[~2010-07-17 3:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-16 13:16 bookmark from gnus article wrong modification Thierry Volpiatto
2010-07-17 3:48 ` Karl Fogel [this message]
2010-07-20 1:22 ` Katsumi Yamaoka
2010-07-20 4:38 ` Thierry Volpiatto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinRAeO2N63G-M10qIMYyMhshjHRikhXMIUgGRda@mail.gmail.com \
--to=kfogel@red-bean.com \
--cc=emacs-devel@gnu.org \
--cc=thierry.volpiatto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).