From: Deniz Dogan <deniz.a.m.dogan@gmail.com>
To: Fran Litterio <flitterio@gmail.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Patch to fix ERC mode's IRC protocol logging
Date: Tue, 20 Jul 2010 01:21:26 +0200 [thread overview]
Message-ID: <AANLkTin17WYFrYZ3C7IjewvaFEJ4H154fVhubr5uR8Hj@mail.gmail.com> (raw)
In-Reply-To: <AANLkTimwNZguwQdjE1g5KeJKta3OnpAf7yhFaijl0IKX@mail.gmail.com>
2010/7/19 Fran Litterio <flitterio@gmail.com>:
> The below patch fixes a problem in ERC where erc-toggle-debug-irc-protocol
> was not logging inbound protocol data. It also changes the key to interactively
> toggle protocol logging so that it doesn't interfere with View mode bindings.
> --
> Fran
>
>
> --- lisp/erc/erc.el~ 2010-07-15 12:10:04.000000000 -0400
> +++ lisp/erc/erc.el 2010-07-19 13:06:51.656250000 -0400
> @@ -2306,14 +2306,14 @@
> (insert (erc-make-notice "This buffer displays all IRC protocol
> traffic exchanged with each server.\n"))
> (insert (erc-make-notice "Kill this buffer to terminate
> protocol logging.\n\n")))
> (use-local-map (make-sparse-keymap))
> - (local-set-key (kbd "RET") 'erc-toggle-debug-irc-protocol))
> + (local-set-key (kbd "t") 'erc-toggle-debug-irc-protocol))
> (add-hook 'kill-buffer-hook
> #'(lambda () (setq erc-debug-irc-protocol nil))
> nil 'local)
> (goto-char (point-max))
> (let ((inhibit-read-only t))
> (insert (erc-make-notice
> - (format "IRC protocol logging %s at %s -- Press ENTER to
> toggle logging.\n"
> + (format "IRC protocol logging %s at %s -- Press 't' to
> toggle logging.\n"
> (if erc-debug-irc-protocol "disabled" "enabled")
> (current-time-string))))))
> (setq erc-debug-irc-protocol (not erc-debug-irc-protocol))
>
>
>
> --- lisp/erc/erc-backend.el~ 2010-07-15 12:10:04.000000000 -0400
> +++ lisp/erc/erc-backend.el 2010-07-19 13:06:49.234375000 -0400
> @@ -574,6 +574,7 @@
> nil
> (substring erc-server-filter-data
> (match-end 0))))
> + (erc-log-irc-protocol line nil)
> (erc-parse-server-response process line)))))))
>
> (defsubst erc-server-reconnect-p (event)
>
>
Thank you! You should probably also send it to erc-discuss@gnu.org in
case the ERC mantainer doesn't read emacs-devel.
--
Deniz Dogan
next prev parent reply other threads:[~2010-07-19 23:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-19 17:19 Patch to fix ERC mode's IRC protocol logging Fran Litterio
2010-07-19 23:21 ` Deniz Dogan [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-07-20 2:55 Francis Litterio
2010-07-20 3:22 ` Deniz Dogan
2010-08-04 17:27 ` Michael Olson
2010-08-08 22:14 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTin17WYFrYZ3C7IjewvaFEJ4H154fVhubr5uR8Hj@mail.gmail.com \
--to=deniz.a.m.dogan@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=flitterio@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).