[PATCH] Fix for bug 6622, nxml-mode Indentation Behavior

[PATCH] Fix for bug 6622, nxml-mode Indentation Behavior

[Geoff Gole]

Typing a / in nxml-mode is supposed to indent the current line.
Setting nxml-slash-auto-complete-flag incorrectly prevents that from
happening. A patch is below.

*** /usr/local/share/emacs/23.2/lisp/nxml/nxml-mode.el.gz
--- /tmp/buffer-content-33187GX
*************** on the line, reindent the line."
*** 1212,1218 ****
  			   (eq (point) (1- slash-pos)))))
      (self-insert-command (prefix-numeric-value arg))
      (unless arg
!       (if nxml-slash-auto-complete-flag
  	  (if end-tag-p
  	      (condition-case err
  		  (let ((start-tag-end
--- 1212,1218 ----
  			   (eq (point) (1- slash-pos)))))
      (self-insert-command (prefix-numeric-value arg))
      (unless arg
!       (when nxml-slash-auto-complete-flag
  	  (if end-tag-p
  	      (condition-case err
  		  (let ((start-tag-end
*************** on the line, reindent the line."
*** 1232,1240 ****
  		(nxml-scan-error nil))
  	    (when (and (eq (nxml-token-before) (point))
  		       (eq xmltok-type 'partial-empty-element))
! 	      (insert ">")))
  	(when (and end-tag-p at-indentation)
! 	  (nxml-indent-line))))))

  (defun nxml-balanced-close-start-tag-block ()
    "Close the start-tag before point with `>' and insert a balancing end-tag.
--- 1232,1240 ----
  		(nxml-scan-error nil))
  	    (when (and (eq (nxml-token-before) (point))
  		       (eq xmltok-type 'partial-empty-element))
! 	      (insert ">"))))
  	(when (and end-tag-p at-indentation)
! 	  (nxml-indent-line)))))

  (defun nxml-balanced-close-start-tag-block ()
    "Close the start-tag before point with `>' and insert a balancing end-tag.

Re: [PATCH] Fix for bug 6622, nxml-mode Indentation Behavior

[Glenn Morris]

Geoff Gole wrote:

> Typing a / in nxml-mode is supposed to indent the current line.
> Setting nxml-slash-auto-complete-flag incorrectly prevents that from
> happening. A patch is below.

Thanks, but if you've got a fix for bug N, please send it to bug N,
not here. Otherwise how is someone reading bug N to know that you
wrote a patch for it? Splitting things across two lists just causes
more work.

Re: [PATCH] Fix for bug 6622, nxml-mode Indentation Behavior

[Geoff Gole]

>
> Thanks, but if you've got a fix for bug N, please send it to bug N,
> not here. Otherwise how is someone reading bug N to know that you
> wrote a patch for it? Splitting things across two lists just causes
> more work.
>

Sorry, that was a dumb mistake. When I started the bug report didn't
exist, and I didn't amend the existing mail properly after noticing
that it did.

I'll send a copy to the bug.

Re: [PATCH] Fix for bug 6622, nxml-mode Indentation Behavior

[Glenn Morris]

Geoff Gole wrote:

> When I started the bug report didn't exist,[...]

I thought you were just super-efficient! :)