From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lennart Borgman Newsgroups: gmane.emacs.devel Subject: Re: Eliminating a couple of independent face definitions Date: Wed, 2 Feb 2011 05:11:34 +0100 Message-ID: References: <87oc6vm67v.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1296619928 22496 80.91.229.12 (2 Feb 2011 04:12:08 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 2 Feb 2011 04:12:08 +0000 (UTC) Cc: emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 02 05:12:04 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PkU4Z-0007jz-TH for ged-emacs-devel@m.gmane.org; Wed, 02 Feb 2011 05:12:04 +0100 Original-Received: from localhost ([127.0.0.1]:52196 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PkU4Z-0007gG-0m for ged-emacs-devel@m.gmane.org; Tue, 01 Feb 2011 23:12:03 -0500 Original-Received: from [140.186.70.92] (port=44910 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PkU4U-0007fy-8S for emacs-devel@gnu.org; Tue, 01 Feb 2011 23:11:59 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PkU4T-0008QZ-5k for emacs-devel@gnu.org; Tue, 01 Feb 2011 23:11:58 -0500 Original-Received: from mail-ew0-f41.google.com ([209.85.215.41]:45570) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PkU4S-0008QQ-UH for emacs-devel@gnu.org; Tue, 01 Feb 2011 23:11:57 -0500 Original-Received: by ewy27 with SMTP id 27so3394183ewy.0 for ; Tue, 01 Feb 2011 20:11:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type:content-transfer-encoding; bh=xCn/z3XL4TC0PXlKFDdUosqDtqvH7ZKiFfDi1KdkCeU=; b=JWgWEiU+Hv4ZTMrf0RN+Kugnv0XoeMSdoM+xj5vy09es7sJYNXwLtwnl+Wb/pbLq+c YIxW8A61XkpxHbOdAFZqKapjkkad72Im2VGA5uTx54RgQK2CWdNWNZbnJNFNwkdVAsj5 PUytmKK0qjYlWJ4Xq0ZPPDZXkDOFAYdkSzHhI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=hDs+WPYAHfbaPy1KJ93Md3mbKTxQd0TzBqK6i6p2i5fLdVnYoW/VZLP3ieHh4uPDWw rTvWTmMV5FKuSiPchlSIRH3NtRW6cYLpRDDYnNJtFcn+8AQGYCD0+8DLuryg4ighegqU 90YFz/z5iZKtAWT8yjC++IZenWr7j4RjG+AnQ= Original-Received: by 10.213.29.77 with SMTP id p13mr11261423ebc.2.1296619916154; Tue, 01 Feb 2011 20:11:56 -0800 (PST) Original-Received: by 10.213.36.11 with HTTP; Tue, 1 Feb 2011 20:11:34 -0800 (PST) In-Reply-To: <87oc6vm67v.fsf@stupidchicken.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.215.41 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:135451 Archived-At: On Wed, Feb 2, 2011 at 5:05 AM, Chong Yidong wrote: > It would be nice if almost all faces in packaged included with Emacs > inherit from the basic or font-lock faces. =C2=A0Most faces already do th= is. > This way, users don't have to specify as much when they write a Custom > theme or their own personal face customizations. > > I'd like to inherit-ize most of the remaining faces that don't already > do this. =C2=A0For instance, compilation-warning is currently "Orange", a= nd > compilation-info is "Green3"; I want to make them inherit from > font-lock-doc-face and font-lock comment-face respectively. =C2=A0(The re= st > of the compilation-mode already inherit from font-lock faces.) > > There are a few more similar changes here and there. =C2=A0Any objection? Yes. It is really good to try to merge some faces, but the specific merges you mentioned seems a bit unfortunate. The colors were obviously chosen to fit into those used in society for "ok" and "warning". Why not create new faces for such things? (I do not think the font-lock faces have the same meaning tighed to them, but maybe I am wrong there.)