From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Deniz Dogan Newsgroups: gmane.emacs.devel Subject: Re: Patch to fix ERC mode's IRC protocol logging Date: Tue, 20 Jul 2010 05:22:53 +0200 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1279596316 6949 80.91.229.12 (20 Jul 2010 03:25:16 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 20 Jul 2010 03:25:16 +0000 (UTC) Cc: emacs-devel@gnu.org To: Francis Litterio Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 20 05:25:13 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ob3SC-0003Sq-Q4 for ged-emacs-devel@m.gmane.org; Tue, 20 Jul 2010 05:25:13 +0200 Original-Received: from localhost ([127.0.0.1]:60950 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ob3SC-0006KJ-5E for ged-emacs-devel@m.gmane.org; Mon, 19 Jul 2010 23:25:12 -0400 Original-Received: from [140.186.70.92] (port=47547 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ob3QT-00061B-GH for emacs-devel@gnu.org; Mon, 19 Jul 2010 23:23:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Ob3QS-0006U0-H1 for emacs-devel@gnu.org; Mon, 19 Jul 2010 23:23:25 -0400 Original-Received: from mail-ww0-f49.google.com ([74.125.82.49]:47485) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ob3QS-0006To-8b for emacs-devel@gnu.org; Mon, 19 Jul 2010 23:23:24 -0400 Original-Received: by wwb17 with SMTP id 17so997287wwb.30 for ; Mon, 19 Jul 2010 20:23:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=v8OMJbtLkpaBhDXhLNHnSpveb4tBGZT0nbC+Gegzkh8=; b=KyD7DcADo2qx5+smwKVolNpy4zS7PWaKwnCzCuiLsQrB4o2oRVCp8lQTnSL5EBI2Zc DtbVVrX7eBzG2gN57SIeRMcFjiXUXmuO49Wlb2pw0oKp3tNN9m4ZO5Liitklr87Cjs5j yOtVE+Xd2N47uoFzM13fnfmEK6eSk7CWuXI3A= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=YM+OdpiD6PjzIOgAmaGfRkWyxffOMcnoiXGUlm6yjh071dZJ6ttRZSlPOa+5USaxL/ EFdUKX233G0StRf3ferfnGziMZpvu7uHB0aGXvG9n7dK19Q2UN5SxZS0P2DVk6jVzJfI UzjqTgUJyN1dF5KPUTMMU3gjKp7cYTXxNIWpo= Original-Received: by 10.216.28.196 with SMTP id g46mr4754915wea.43.1279596203246; Mon, 19 Jul 2010 20:23:23 -0700 (PDT) Original-Received: by 10.216.175.76 with HTTP; Mon, 19 Jul 2010 20:22:53 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:127600 Archived-At: 2010/7/20 Francis Litterio : > Deniz Dogan wrote: > >> 2010/7/19 Fran Litterio: >> > The below patch fixes a problem in ERC where erc-toggle-debug-irc-prot= ocol >> > was not logging inbound protocol data. It also changes the key to inte= ractively >> > toggle protocol logging so that it doesn't interfere with View mode bi= ndings. > >> Thank you! You should probably also send it to erc-discuss gnu.org = in >> case the ERC mantainer doesn't read emacs-devel. > > Do patches for ERC have to go into the upstream ERC source first in > order to make it into Emacs? =A0I thought that since ERC was now part of > Emacs, patches can go directly into the Emacs source. I guess I have the same understanding as you, but it may be more likely that you receive more feedback on the patch from erc-discuss. --=20 Deniz Dogan